From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97850C3F2D7 for ; Tue, 3 Mar 2020 15:43:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6AF3720866 for ; Tue, 3 Mar 2020 15:43:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="MhJmo47z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730110AbgCCPnv (ORCPT ); Tue, 3 Mar 2020 10:43:51 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:25286 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730114AbgCCPnv (ORCPT ); Tue, 3 Mar 2020 10:43:51 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1583250230; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=0RtZ3Aoyz/ucJdUBS4KVjKUFDbZ/LAxf/VkAI5mTDEI=; b=MhJmo47z82wLTw0vHC5AI89PEPE/urifKvGRJgAG347defM6ldebzpolwSnyGGbm51oN13my 24Btz5pQheOq7mB8rmJZXpg5IuHKquOEQLKMAD7/R7buU1VNIybrsYMAknALiv8Qki4MGGNa fSl/a/35lPH81MJqaiiKlOOYokE= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e5e7b1e.7f27a42232d0-smtp-out-n03; Tue, 03 Mar 2020 15:43:26 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E1AB1C447A2; Tue, 3 Mar 2020 15:43:24 +0000 (UTC) Received: from jcrouse1-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcrouse) by smtp.codeaurora.org (Postfix) with ESMTPSA id 52BD4C43383; Tue, 3 Mar 2020 15:43:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 52BD4C43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=jcrouse@codeaurora.org Date: Tue, 3 Mar 2020 08:43:21 -0700 From: Jordan Crouse To: Sam Ravnborg Cc: Sean Paul , devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, smasetty@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , freedreno@lists.freedesktop.org Subject: Re: [Freedreno] [PATCH v3 1/2] dt-bindings: display: msm: Convert GMU bindings to YAML Message-ID: <20200303154321.GA24212@jcrouse1-lnx.qualcomm.com> Mail-Followup-To: Sam Ravnborg , Sean Paul , devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, smasetty@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , freedreno@lists.freedesktop.org References: <1583173424-21832-1-git-send-email-jcrouse@codeaurora.org> <1583173424-21832-2-git-send-email-jcrouse@codeaurora.org> <20200302204906.GA32123@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200302204906.GA32123@ravnborg.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Mar 02, 2020 at 09:49:06PM +0100, Sam Ravnborg wrote: > Hi Jordan. > > On Mon, Mar 02, 2020 at 11:23:43AM -0700, Jordan Crouse wrote: > > Convert display/msm/gmu.txt to display/msm/gmu.yaml and remove the old > > text bindings. > > > > Signed-off-by: Jordan Crouse > > --- > > > > .../devicetree/bindings/display/msm/gmu.txt | 116 ------------------- > > - > > -Required properties: > > -- compatible: "qcom,adreno-gmu-XYZ.W", "qcom,adreno-gmu" > > - for example: "qcom,adreno-gmu-630.2", "qcom,adreno-gmu" > > - Note that you need to list the less specific "qcom,adreno-gmu" > > - for generic matches and the more specific identifier to identify > > - the specific device. > > -- reg: Physical base address and length of the GMU registers. > > -- reg-names: Matching names for the register regions > > - * "gmu" > > - * "gmu_pdc" > > - * "gmu_pdc_seg" > > -- interrupts: The interrupt signals from the GMU. > > -- interrupt-names: Matching names for the interrupts > > - * "hfi" > > - * "gmu" > > -- clocks: phandles to the device clocks > > -- clock-names: Matching names for the clocks > > - * "gmu" > > - * "cxo" > > - * "axi" > > - * "mnoc" > The new binding - and arch/arm64/boot/dts/qcom/sdm845.dtsi agrees that > "mnoc" is wrong. > > > -- power-domains: should be: > > - <&clock_gpucc GPU_CX_GDSC> > > - <&clock_gpucc GPU_GX_GDSC> > > -- power-domain-names: Matching names for the power domains > > -- iommus: phandle to the adreno iommu > > -- operating-points-v2: phandle to the OPP operating points > > - > > -Optional properties: > > -- sram: phandle to the On Chip Memory (OCMEM) that's present on some Snapdragon > > - SoCs. See Documentation/devicetree/bindings/sram/qcom,ocmem.yaml. > This property is not included in the new binding. Yeah, that guy shouldn't be here. I'm not sure how it got there in the first place but I'll update the commit log. Thanks for the poke. Jordan > Everything else looked fine to me. > With sram added - or expalined in commit why it is dropped: > Acked-by: Sam Ravnborg > > Sam > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project