From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v3 1/2] spi: dt-bindings: spi-controller: Fix #address-cells for slave mode
Date: Fri, 6 Mar 2020 09:50:37 +0100 [thread overview]
Message-ID: <20200306085038.8111-2-geert+renesas@glider.be> (raw)
In-Reply-To: <20200306085038.8111-1-geert+renesas@glider.be>
Currently, the DT bindings for an SPI controller specify that
"#address-cells" must be fixed to one. However, that applies to an SPI
controller in master mode only. When running in SPI slave mode,
"#address-cells" should not be specified.
Fix this making "#address-cells" mutually-exclusive with "spi-slave".
Fixes: 0a1b929356830257 ("spi: Add YAML schemas for the generic SPI options")
Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v3:
- Make #address-cells mutually-exclusive with spi-slave,
v2:
- Use "enum: [0, 1]" instead of min/max limit,
- use "- spi-slave" instead of "[ spi-slave ]".
---
Documentation/devicetree/bindings/spi/spi-controller.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml
index 1e0ca6ccf64bbd0a..0ebaf6677ac4f68d 100644
--- a/Documentation/devicetree/bindings/spi/spi-controller.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml
@@ -52,6 +52,12 @@ properties:
description:
The SPI controller acts as a slave, instead of a master.
+oneOf:
+ - required:
+ - "#address-cells"
+ - required:
+ - spi-slave
+
patternProperties:
"^slave$":
type: object
--
2.17.1
next prev parent reply other threads:[~2020-03-06 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 8:50 [PATCH v3 0/2] spi: dt-bindings: spi-controller: Slave mode fixes Geert Uytterhoeven
2020-03-06 8:50 ` Geert Uytterhoeven [this message]
2020-03-12 19:16 ` [PATCH v3 1/2] spi: dt-bindings: spi-controller: Fix #address-cells for slave mode Rob Herring
2020-03-13 17:06 ` Applied "spi: dt-bindings: spi-controller: Fix #address-cells for slave mode" to the spi tree Mark Brown
2020-03-06 8:50 ` [PATCH v3 2/2] spi: dt-bindings: spi-controller: Fix spi-[rt]x-bus-width for slave mode Geert Uytterhoeven
2020-03-12 19:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306085038.8111-2-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).