From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 963D8C43331 for ; Fri, 27 Mar 2020 11:25:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 664382073B for ; Fri, 27 Mar 2020 11:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585308316; bh=nYLHHHRgW7KyhXgGAfcT0pygfJkAcJNPNdQChIW8IzE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Xg5x5Uuv1kdlLHQqQvV7IkKwf0rIzb0u5u6eAHflOseJX5hqijqKcI13G5Yz+GIPJ UcRuBOh7AsgFflpNwhgiHUHlv50eBtzZFKl/Qro3pj3FC/aTfRuGQx5Mn887qe4Vnu rSyHC1AgZhg9hKJpkJVs44BIW6FRPM8d+cKx11+k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727287AbgC0LZP (ORCPT ); Fri, 27 Mar 2020 07:25:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:39032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727263AbgC0LZP (ORCPT ); Fri, 27 Mar 2020 07:25:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5EDC5206F8; Fri, 27 Mar 2020 11:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585308314; bh=nYLHHHRgW7KyhXgGAfcT0pygfJkAcJNPNdQChIW8IzE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=18dP0C8Mb7gJckrnRxRLPL+nbNHpzhZUFKEJGWDnCbTz27iZ61uQ1UzoML5cqpwjZ OnMES3/9QvzfhK6otlnz7npww5X9/VLU5sDKzxloN3NhcbnzffEaCd8pBwM/aSppbp q/SogzJO2Od4oA1on+He3NN2cgG9I3jI1cN7hBEc= Date: Fri, 27 Mar 2020 12:25:11 +0100 From: Greg KH To: Kalle Valo Cc: Ajay.Kathat@microchip.com, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Venkateswara.Kaja@microchip.com, linux-wireless@vger.kernel.org, Nicolas.Ferre@microchip.com, Adham.Abozaeid@microchip.com, johannes@sipsolutions.net Subject: Re: [PATCH v6 00/17] wilc1000: move out of staging Message-ID: <20200327112511.GA1708276@kroah.com> References: <20200327063302.20511-1-ajay.kathat@microchip.com> <87ftduoxou.fsf@tynnyri.adurom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ftduoxou.fsf@tynnyri.adurom.net> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Mar 27, 2020 at 01:16:01PM +0200, Kalle Valo wrote: > writes: > > > From: Ajay Singh > > > > This patch series is to review and move wilc1000 driver out of staging. > > Most of the review comments received in [1] & [2] are addressed in the > > latest code. Please review and provide your inputs. > > > > [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/ > > [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/ > > > > Changes since v5: > > - handle DT binding review comments suggested in below link: > > * https://lore.kernel.org/driverdev-devel/20200320175920.GA31641@bogus > > - merged latest driver from staging which contains few cleanup patches > > and changes to use crc7 from existing library instead of having > > private implementation. > > This is already the third version this month, please avoid spamming the > list unnecessarily. What you can do to speed up the acceptance is to get > Reviewed-by tags from people, the more I see those the more confident I > get about the driver. I will also review this again once I find some > free time, but don't know when that will happen. > > But it would be good to document in the cover letter what commit id are > you using as the baseline. That way it's easy to review rest of the > changes Greg has applied separately and you don't need to resend the > whole driver everytime. Using the --base= flag in git format-patch is helpful in automating that :) thanks, greg k-h