From: Rob Herring <robh@kernel.org>
To: frowand.list@gmail.com
Cc: pantelis.antoniou@konsulko.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Alan Tull <atull@kernel.org>
Subject: Re: [PATCH 2/2] of: some unittest overlays not untracked
Date: Tue, 31 Mar 2020 15:58:00 -0600 [thread overview]
Message-ID: <20200331215800.GA12799@bogus> (raw)
In-Reply-To: <1585187131-21642-3-git-send-email-frowand.list@gmail.com>
On Wed, 25 Mar 2020 20:45:31 -0500, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> kernel test robot reported "WARNING: held lock freed!" triggered by
> unittest_gpio_remove(), which should not have been called because
> the related gpio overlay was not tracked. Another overlay that
> was tracked had previously used the same id as the gpio overlay
> but had not been untracked when the overlay was removed. Thus the
> clean up function of_unittest_destroy_tracked_overlays() incorrectly
> attempted to remove the reused overlay id.
>
> Patch contents:
>
> - Create tracking related helper functions
> - Change BUG() to WARN_ON() for overlay id related issues
> - Add some additional error checking for valid overlay id values
> - Add the missing overlay untrack
> - update comment on expectation that overlay ids are assigned in
> sequence
>
> Fixes: 492a22aceb75 ("of: unittest: overlay: Keep track of created overlays")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/of/unittest.c | 30 +++++++++++++++++++++++-------
> 1 file changed, 23 insertions(+), 7 deletions(-)
>
Applied, thanks.
Rob
prev parent reply other threads:[~2020-03-31 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 1:45 [PATCH 0/2] of: unittest gpio unittest error exposes tracking error frowand.list
2020-03-26 1:45 ` [PATCH 1/2] of: gpio unittest kfree() wrong object frowand.list
2020-03-26 7:51 ` Geert Uytterhoeven
2020-03-31 21:57 ` Rob Herring
2020-03-26 1:45 ` [PATCH 2/2] of: some unittest overlays not untracked frowand.list
2020-03-26 8:21 ` Geert Uytterhoeven
2020-03-26 10:20 ` Frank Rowand
2020-03-31 21:58 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331215800.GA12799@bogus \
--to=robh@kernel.org \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).