Linux-Devicetree Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM: dts: r7s9210: Remove bogus clock-names from OSTM nodes
@ 2020-04-27 19:29 Geert Uytterhoeven
  2020-04-27 19:39 ` Chris Brandt
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-04-27 19:29 UTC (permalink / raw)
  To: Magnus Damm, Chris Brandt
  Cc: linux-renesas-soc, linux-arm-kernel, devicetree, Geert Uytterhoeven

Usually it does not hurt to add "clock-names" properties, even if the
(pre-json-schema) DT bindings do not mention them.

However, the actual clock names for the OS Timer nodes are not fixed,
but contain the indices of the consumer instances.  Hence they cannot
easily be used by a driver, without scanning for all possible indices.

Remove them, as the OSTM DT bindings do not specify clock-names anyway.

Fixes: bbbcd02b82552907 ("ARM: dts: r7s9210: Initial SoC device tree")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued in renesas-fixes for v5.7, to avoid the json-schema OSTM DT
bindings conversion introducing a regression.
---
 arch/arm/boot/dts/r7s9210.dtsi | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/r7s9210.dtsi b/arch/arm/boot/dts/r7s9210.dtsi
index 72b79770e336a79e..cace4380749711d7 100644
--- a/arch/arm/boot/dts/r7s9210.dtsi
+++ b/arch/arm/boot/dts/r7s9210.dtsi
@@ -304,7 +304,6 @@
 			reg = <0xe803b000 0x30>;
 			interrupts = <GIC_SPI 56 IRQ_TYPE_EDGE_RISING>;
 			clocks = <&cpg CPG_MOD 36>;
-			clock-names = "ostm0";
 			power-domains = <&cpg>;
 			status = "disabled";
 		};
@@ -314,7 +313,6 @@
 			reg = <0xe803c000 0x30>;
 			interrupts = <GIC_SPI 57 IRQ_TYPE_EDGE_RISING>;
 			clocks = <&cpg CPG_MOD 35>;
-			clock-names = "ostm1";
 			power-domains = <&cpg>;
 			status = "disabled";
 		};
@@ -324,7 +322,6 @@
 			reg = <0xe803d000 0x30>;
 			interrupts = <GIC_SPI 58 IRQ_TYPE_EDGE_RISING>;
 			clocks = <&cpg CPG_MOD 34>;
-			clock-names = "ostm2";
 			power-domains = <&cpg>;
 			status = "disabled";
 		};
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] ARM: dts: r7s9210: Remove bogus clock-names from OSTM nodes
  2020-04-27 19:29 [PATCH] ARM: dts: r7s9210: Remove bogus clock-names from OSTM nodes Geert Uytterhoeven
@ 2020-04-27 19:39 ` Chris Brandt
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Brandt @ 2020-04-27 19:39 UTC (permalink / raw)
  To: Geert Uytterhoeven, Magnus Damm
  Cc: linux-renesas-soc, linux-arm-kernel, devicetree

Hi Geert,

On Mon, Apr 27, 2020, Geert Uytterhoeven wrote:
> However, the actual clock names for the OS Timer nodes are not fixed,
> but contain the indices of the consumer instances.  Hence they cannot
> easily be used by a driver, without scanning for all possible indices.
> 
> Remove them, as the OSTM DT bindings do not specify clock-names anyway.

> ---
> To be queued in renesas-fixes for v5.7, to avoid the json-schema OSTM DT
> bindings conversion introducing a regression.
> ---

OK. Thank you.

Chris

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27 19:29 [PATCH] ARM: dts: r7s9210: Remove bogus clock-names from OSTM nodes Geert Uytterhoeven
2020-04-27 19:39 ` Chris Brandt

Linux-Devicetree Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git
	git clone --mirror https://lore.kernel.org/linux-devicetree/1 linux-devicetree/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \
		devicetree@vger.kernel.org
	public-inbox-index linux-devicetree

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git