From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29939C433E1 for ; Fri, 29 May 2020 03:43:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE0F420C56 for ; Fri, 29 May 2020 03:43:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VZzDCliJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390116AbgE2Dnk (ORCPT ); Thu, 28 May 2020 23:43:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388880AbgE2Dni (ORCPT ); Thu, 28 May 2020 23:43:38 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF11FC08C5C6 for ; Thu, 28 May 2020 20:43:37 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id 124so692637pgi.9 for ; Thu, 28 May 2020 20:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3XR7QJKmL5fxVgpEHnbXhWBYoXXokdRRh1j2h2NbRQU=; b=VZzDCliJGfOlt4tH8T34NNHm24YmzWjQH6Vz5bL2rCq9/BiO69K98p/HefqFg4eFaD BDshO8R2j+NA4WugUeEK/EwnBbpcl8fxh01FMWj2CCx/aK6KLE9OlyknJwguWrWyyuij jp5GIr0dKrc3tp1JJzyxazBJ2XX83usJ442iL2lWZZuPAgbsidrmzTU4YR59CY+ItGev PAN7rSWOUpy2sL3siqvaqfsrUsupUZuf4kLZCPwkrlZpG1+Tm/Gyi4CW0Z8xzb1mB+ki 9ZTYCVl3CsiEAfa7Xv81ahzmdceuGnnnggCDyiJkp5kZg1uVx/b/1Ho8TYO+IyzGk2O2 rMtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3XR7QJKmL5fxVgpEHnbXhWBYoXXokdRRh1j2h2NbRQU=; b=Ju8ezpT/4DUVC5XM7A+7TbtP34sIW/zzhTjLrqI1VCSf6e4aQtMo5nEVN0fVZRxko4 GHyU5hDN0/ImZqAPrlfw09zDupT4fjJkQGqvQpwR5Y2nib6c8Lel9/1dIpriEz6KsaTC NPj+gHKKc8Cg7DpPdKpoB7WfBXz7DfungUcOWEPcPs8JZOFuBjHDUk1Ceb065TKI616p qGshFl6AtWQvZ/K6pt/IptjvSPFMk9KyY76jkdRCigknDg6nMDVp++HQlUeg7P2MxS+k 7SqBmBGYvpe3aMZ9o2RnubzzOB6I2CH5VBdh72r6gS26w18vCgIerU/sSH9cIJBURus2 F+Zw== X-Gm-Message-State: AOAM532LBMME2z2RRUS53zK+QXNwdklch9HnsQtags5fGTwoyF4LlFMf fdbQV0aC4yP/8o/Ee21UYHrPKQ== X-Google-Smtp-Source: ABdhPJwHfgoT1qJoRd8XA+Tzc9s/OsDLzwP+ALpVeOVyed8xHlA7HDd8qgf/35ZMZ5FMJUCCmtFqAw== X-Received: by 2002:a63:6605:: with SMTP id a5mr6122534pgc.50.1590723817296; Thu, 28 May 2020 20:43:37 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id b63sm5930269pfg.86.2020.05.28.20.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 20:43:36 -0700 (PDT) Date: Thu, 28 May 2020 20:42:31 -0700 From: Bjorn Andersson To: Jonathan Marek Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8150: add apps_smmu node Message-ID: <20200529034231.GB1799770@builder.lan> References: <20200524023815.21789-1-jonathan@marek.ca> <20200524023815.21789-2-jonathan@marek.ca> <20200529025246.GV279327@builder.lan> <20200529031520.GA1799770@builder.lan> <00b8f010-1ae1-45b2-8dd0-a1b582861a2e@marek.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00b8f010-1ae1-45b2-8dd0-a1b582861a2e@marek.ca> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 28 May 20:34 PDT 2020, Jonathan Marek wrote: > On 5/28/20 11:15 PM, Bjorn Andersson wrote: > > On Thu 28 May 20:02 PDT 2020, Jonathan Marek wrote: > > > > > > > > > > > On 5/28/20 10:52 PM, Bjorn Andersson wrote: > > > > On Sat 23 May 19:38 PDT 2020, Jonathan Marek wrote: > > > > > > > > > Add the apps_smmu node for sm8150. Note that adding the iommus field for > > > > > UFS is required because initializing the iommu removes the bypass mapping > > > > > that created by the bootloader. > > > > > > > > > > > > > Unrelated to the patch itself; how do you disable the splash screen on > > > > 8150? "fastboot oem select-display-panel none" doesn't seem to work for > > > > me on the MTP - and hence this would prevent my device from booting. > > > > > > > > Thanks, > > > > Bjorn > > > > > > > > > > I don't have a MTP, but on HDK855, "fastboot oem select-display-panel none" > > > combined with setting the physical switch to HDMI mode (which switches off > > > the 1440x2560 panel) gets it to not setup the display at all (just the > > > fastboot command isn't enough). > > > > > > > Okay, I don't think we have anything equivalent on the MTP, but good to > > know. > > > > > With HDK865 though that doesn't work and I have a hack to work around it > > > (writing 0 to INTF_TIMING_ENGINE_EN early on in boot will stop video mode > > > scanout and it won't crash). > > > > > > > Then we need to sort this out in the arm-smmu driver before we can > > enable the apps_smmu node on 8250. I did receive some guidance from Will > > on the subject and have started looking into this. > > > > That's annoying because a lot depends on apps_mmu. GPU is an exception with > its own MMU but pretty much everything else uses apps_smmu (does it make > sense to add USB nodes if it won't work without apps_smmu?) Is this > something that will get resolved soon? > We have a number of boards where this is becoming a critical issue, so we better find an acceptable solution to this very soon. Regards, Bjorn > FWIW, I have another sm8250 board which does not need the workaround (its > bootloader does not set up the display). AFAIK modifying the bootloader to > not set up any display is a trivial modification (assuming that's an > option). > > > Thanks, > > Bjorn > > > > > > > Signed-off-by: Jonathan Marek > > > > > --- > > > > > arch/arm64/boot/dts/qcom/sm8150.dtsi | 91 ++++++++++++++++++++++++++++ > > > > > 1 file changed, 91 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > > > > > index a36512d1f6a1..acb839427b12 100644 > > > > > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > > > > > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > > > > > @@ -442,6 +442,8 @@ ufs_mem_hc: ufshc@1d84000 { > > > > > resets = <&gcc GCC_UFS_PHY_BCR>; > > > > > reset-names = "rst"; > > > > > + iommus = <&apps_smmu 0x300 0>; > > > > > + > > > > > clock-names = > > > > > "core_clk", > > > > > "bus_aggr_clk", > > > > > @@ -706,6 +708,7 @@ usb_1_dwc3: dwc3@a600000 { > > > > > compatible = "snps,dwc3"; > > > > > reg = <0 0x0a600000 0 0xcd00>; > > > > > interrupts = ; > > > > > + iommus = <&apps_smmu 0x140 0>; > > > > > snps,dis_u2_susphy_quirk; > > > > > snps,dis_enblslpm_quirk; > > > > > phys = <&usb_1_hsphy>, <&usb_1_ssphy>; > > > > > @@ -742,6 +745,94 @@ spmi_bus: spmi@c440000 { > > > > > cell-index = <0>; > > > > > }; > > > > > + apps_smmu: iommu@15000000 { > > > > > + compatible = "qcom,sdm845-smmu-500", "arm,mmu-500"; > > > > > + reg = <0 0x15000000 0 0x100000>; > > > > > + #iommu-cells = <2>; > > > > > + #global-interrupts = <1>; > > > > > + interrupts = , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + , > > > > > + ; > > > > > + }; > > > > > + > > > > > remoteproc_adsp: remoteproc@17300000 { > > > > > compatible = "qcom,sm8150-adsp-pas"; > > > > > reg = <0x0 0x17300000 0x0 0x4040>; > > > > > -- > > > > > 2.26.1 > > > > >