From: Rob Herring <robh@kernel.org>
To: Tejas Joglekar <Tejas.Joglekar@synopsys.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
John Youn <John.Youn@synopsys.com>
Subject: Re: [PATCH v3 1/4] dt-bindings: usb: Add documentation for SG trb cache size quirk
Date: Fri, 29 May 2020 12:05:50 -0600 [thread overview]
Message-ID: <20200529180550.GA2665183@bogus> (raw)
In-Reply-To: <d91b768b3827fce611ba052aa1bcca19ac09fd75.1590415123.git.joglekar@synopsys.com>
On Wed, May 27, 2020 at 04:10:55PM +0530, Tejas Joglekar wrote:
> This commit adds the documentation for sgl-trb-cache-size-quirk, and
> snps,sgl-trb-cache-size-quirk property. These when set enables the
> quirk for XHCI driver for consolidation of sg list into a temporary
> buffer when small buffer sizes are scattered over the sg list not
> making up to MPS or total transfer size within TRB cache size with
> Synopsys xHC.
>
> Signed-off-by: Tejas Joglekar <joglekar@synopsys.com>
> ---
> Documentation/devicetree/bindings/usb/dwc3.txt | 4 ++++
> Documentation/devicetree/bindings/usb/usb-xhci.txt | 3 +++
> 2 files changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index d03edf9d3935..0fcbaa51f66e 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -102,6 +102,10 @@ Optional properties:
> this and tx-thr-num-pkt-prd to a valid, non-zero value
> 1-16 (DWC_usb31 programming guide section 1.2.3) to
> enable periodic ESS TX threshold.
> + - snps,sgl-trb-cache-size-quirk: enable sg list consolidation - host mode
> + only. Set to use SG buffers of at least MPS size
> + by consolidating smaller SG buffers list into a
> + single buffer.
>
> - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated.
> - snps,incr-burst-type-adjustment: Value for INCR burst type of GSBUSCFG0
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> index dc025f126d71..c53eb19ae67e 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -44,6 +44,9 @@ Optional properties:
> - quirk-broken-port-ped: set if the controller has broken port disable mechanism
> - imod-interval-ns: default interrupt moderation interval is 5000ns
> - phys : see usb-hcd.yaml in the current directory
> + - sgl-trb-cache-size-quirk: set if you need to consolidate sg list into a
> + temporary buffer when small SG buffer sizes does not make upto MPS
> + size or total transfer size across the TRB cache size.
Still don't understand why you have 2 properties? Is this a generic
issue for multiple XHCI controllers? If yes, you don't need the first
one. If no, then you don't need the second one.
Really, I'd prefer neither, and this should be implied by a specific
compatible string. Having a separate property doesn't work if you find
this issue later on after already adding XHCI support. IOW, don't make
users update their DT to handle a quirk.
Rob
next prev parent reply other threads:[~2020-05-29 18:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 10:40 [PATCH v3 0/4] Add logic to consolidate TRBs for Synopsys xHC Tejas Joglekar
2020-05-27 10:40 ` [PATCH v3 1/4] dt-bindings: usb: Add documentation for SG trb cache size quirk Tejas Joglekar
2020-05-29 18:05 ` Rob Herring [this message]
2020-06-08 4:32 ` [PATCH v3 0/4] Add logic to consolidate TRBs for Synopsys xHC Tejas Joglekar
2020-06-09 8:57 ` Mathias Nyman
2020-06-11 18:07 ` Tejas Joglekar
2020-06-30 6:28 ` Tejas Joglekar
[not found] ` <83eba2e9f0069f20ccc94537e3b99cbaec209441.1590415123.git.joglekar@synopsys.com>
[not found] ` <5534d9d6-5452-dade-e46e-f4b0910becdb@synopsys.com>
[not found] ` <877dvhqh2e.fsf@kernel.org>
2020-07-15 5:51 ` [PATCH v3 3/4] usb: dwc3: Add device property sgl-trb-cache-size-quirk Tejas Joglekar
2020-07-21 9:47 ` Felipe Balbi
2020-07-21 16:57 ` Tejas Joglekar
2020-07-31 10:13 ` Tejas Joglekar
2020-08-04 0:44 ` Thinh Nguyen
2020-08-04 1:59 ` Jun Li
2020-07-23 10:35 ` [PATCH v3 0/4] Add logic to consolidate TRBs for Synopsys xHC Jun Li
2020-07-24 0:15 ` Tejas Joglekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529180550.GA2665183@bogus \
--to=robh@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Tejas.Joglekar@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).