From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C0BDC433DF for ; Fri, 5 Jun 2020 10:50:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BF86207D0 for ; Fri, 5 Jun 2020 10:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591354230; bh=ZkmdIlShUAFHW0pi3QVcOWNFuQmL8jmheacHFvaENQw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GqzIHm+tvZS03OGdYWUmmj5zOZpE4+2T/eeAc/0clMZ5DZV0IjZCnsAuNeyLyQJzQ +pZhf5g+BySkRShR65OYKRtYE69TtP2QLyCY+AHTrRzBMBjyXkGERR1R5ICDmXlYu1 dt9hDx11EKxv+4CiE6qzPbueUyWq6SEfeCq8Mbnw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726830AbgFEKu3 (ORCPT ); Fri, 5 Jun 2020 06:50:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:51160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbgFEKu3 (ORCPT ); Fri, 5 Jun 2020 06:50:29 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A76F020772; Fri, 5 Jun 2020 10:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591354228; bh=ZkmdIlShUAFHW0pi3QVcOWNFuQmL8jmheacHFvaENQw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GLcE760t5aG1mrGcTjrY4oXPhQP87W9f9FHSm2jzdENswX23N78yJytXBV9GNzkbR HeuVUKObU3X3hnvgtT8mG7IFX03o5feVM1EquN4xEo/fghn9zFIRczyA+hbjD+dXba 9nY+/TtMcuy1enmXJQ+j+FTTmmFZ/Qpp2ep9hZCM= Date: Fri, 5 Jun 2020 11:50:26 +0100 From: Mark Brown To: Lee Jones Cc: Michael Walle , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Greg Kroah-Hartman , Andy Shevchenko Subject: Re: [PATCH v4 02/11] mfd: Add support for Kontron sl28cpld management controller Message-ID: <20200605105026.GC5413@sirena.org.uk> References: <20200604211039.12689-1-michael@walle.cc> <20200604211039.12689-3-michael@walle.cc> <20200605065709.GD3714@dell> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="s9fJI615cBHmzTOP" Content-Disposition: inline In-Reply-To: <20200605065709.GD3714@dell> X-Cookie: Air is water with holes in it. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --s9fJI615cBHmzTOP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 05, 2020 at 07:57:09AM +0100, Lee Jones wrote: > On Thu, 04 Jun 2020, Michael Walle wrote: > > + sl28cpld->regmap = devm_regmap_init_i2c(i2c, &sl28cpld_regmap_config); > > + if (IS_ERR(sl28cpld->regmap)) > > + return PTR_ERR(sl28cpld->regmap); > This is now a shared memory allocator and not an MFD at all. > I'm clamping down on these type of drivers! > Please find a better way to accomplish this. What is the concern with this? Looking at the patch I'm guessing the concern would be that the driver isn't instantiating any MFD children and instead requiring them to be put in the DT? > Potentially using "simple-mfd" and "simple-regmap". > The former already exists and does what you want. The latter doesn't > yet exist, but could solve your and lots of other contributor's > issues. I have no idea what you are thinking of when you say "simple-regmap" so it is difficult to comment. --s9fJI615cBHmzTOP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7aI3EACgkQJNaLcl1U h9A7hQf8CDFQ5iLpXTLY4zeynMxyWKwNzkV4jtp9HDi0METL6K488ki/EvosVeJx URGVB1pt6HfuZ+wo9eI4viS324oVbqB+OLEP2C2JT9IueDFeFAVv/ZID0FjrKlB8 3L1IaFXplUYVhcSJGxL+9p6BB2RpY2jKupLmYwudJ2RKDIT/sf011ENofTZR2i/7 mHJQsYGSN/zKTcrZm9cmx10BOmpL5aSq0hwcOM1qYqPn/tlSs09ErRh1+Tisxg+U 3ZTBCjG5cDlPj0KIBfoZkJapLQ3YklicCzY2LTKFvP1bxloxYa4iyyy0O5oHdBaK vL9TOwYXvPCnUOSIH1toNvcVphaLDg== =gwiS -----END PGP SIGNATURE----- --s9fJI615cBHmzTOP--