From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FD72C433E0 for ; Mon, 8 Jun 2020 19:15:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58A18206A4 for ; Mon, 8 Jun 2020 19:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591643752; bh=TsYdJ6dt1H/TCgkEQshMgERo+ve2nAgpCo/k1eH2u/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=erpJ2q2C2PsFb3TZ06CmMi6PMReGgQaavtDRfGfHCFVtbfPGw3+iPOZMgMBsiMneQ TRkmajSpNbmr7vc4cHimaPXeJ/IwdlkifpAoI9UwlAka7sTv92Bnud0h3WCM5YWc0A VlTtgqgfzGjs7YdDIyggMFOk59WuUAWZHvZFrSeY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726217AbgFHTPv (ORCPT ); Mon, 8 Jun 2020 15:15:51 -0400 Received: from mail-il1-f195.google.com ([209.85.166.195]:33997 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726395AbgFHTPt (ORCPT ); Mon, 8 Jun 2020 15:15:49 -0400 Received: by mail-il1-f195.google.com with SMTP id v11so17944539ilh.1; Mon, 08 Jun 2020 12:15:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bVsoFmj/HOOaF4AtOKuEbVSeUbWa/HT5CaZGq3xuk+k=; b=SidH17wIWv+MHoeSVtnM0+dASgeqKpWg4hEID5P2eVIn3Ij97EFlCt1zNauiGPGGUz 8RHdhY44VkOUvedpqROmJXTh5KWOdc1zeXV5igI6nYvUkAO6gZAJDohFNEzZ4g5uTGJA RzF9jKK+4tzl3QtbwVuik4jaRFY9aHY9fiuFxBReXb38rumM1qrVVWOibTdNh9+iSJMe G43Vo/DMG44+g76nLnp/xS3rJ0sF5yWQvToXBHB3mLBzXGpHTgPmrp26SUCD/EXPj7g8 qO8XnvVJwnfBERFOV0fNX4/zyyl18boiU0LuI91I5M+jLcFbOgYO+TrPMn/KKkSwyl4b QVnA== X-Gm-Message-State: AOAM533y+11UkW0CHNZXNcGi4ElTjVYitg0UgU+bo1KfXrkmWNruYzGQ ozsxeBDTamXHK+qpLYtJpw== X-Google-Smtp-Source: ABdhPJyyki13Kmz3IcORTgD+J9l61fT82bMJryDN6e0+3h6Bw9W1SsjOXqx6qWzG/BBB8aIs7YDvng== X-Received: by 2002:a92:d905:: with SMTP id s5mr23653121iln.268.1591643747050; Mon, 08 Jun 2020 12:15:47 -0700 (PDT) Received: from xps15 ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id y12sm8016889ili.83.2020.06.08.12.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 12:15:46 -0700 (PDT) Received: (nullmailer pid 3350297 invoked by uid 1000); Mon, 08 Jun 2020 19:15:45 -0000 Date: Mon, 8 Jun 2020 13:15:45 -0600 From: Rob Herring To: Masahiro Yamada Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Rowand Subject: Re: [PATCH] scripts/dtc: use pkg-config to include in non-standard path Message-ID: <20200608191545.GA3346390@bogus> References: <20200505100319.741454-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200505100319.741454-1-masahiroy@kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, May 05, 2020 at 07:03:19PM +0900, Masahiro Yamada wrote: > Commit 067c650c456e ("dtc: Use pkg-config to locate libyaml") added > 'pkg-config --libs' to link libyaml installed in a non-standard > location. > > yamltree.c includes , but that commit did not add the search > path for . If /usr/include/yaml.h does not exist, it fails to > build. A user can explicitly pass HOSTCFLAGS to work around it, but > the policy is not consistent. > > There are two ways to deal with libraries in a non-default location. > > [1] Use HOSTCFLAGS and HOSTLDFLAGS for additional search paths for > headers and libraries. > They are documented in Documentation/kbuild/kbuild.rst > > $ make HOSTCFLAGS='-I /include' HOSTLDFLAGS='-L /lib' > > [2] Use pkg-config > > 'pkg-config --cflags' for querying the header search path > 'pkg-config --libs' for querying the lib and its path > > If we go with pkg-config, use [2] consistently. Do not mix up > [1] and [2]. > > Signed-off-by: Masahiro Yamada > --- > > scripts/dtc/Makefile | 3 +++ > 1 file changed, 3 insertions(+) Sorry, missed this one. Now applied for 5.8. Rob