From: Mark Brown <broonie@kernel.org>
To: Pantelis Antoniou <pantelis.antoniou@linaro.org>
Cc: Stephan Gerhold <stephan@gerhold.net>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Matthew Porter <mporter@konsulko.com>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH 1/2] dt-bindings: sound: Device tree bindings for the apq8039 sound complex
Date: Mon, 22 Jun 2020 13:04:09 +0100 [thread overview]
Message-ID: <20200622120409.GD4560@sirena.org.uk> (raw)
In-Reply-To: <2070B433-83E0-4ACE-A470-36401934FC5A@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On Mon, Jun 22, 2020 at 02:34:23PM +0300, Pantelis Antoniou wrote:
> > This looks much like a replacement for ALSA UCM and userspace audio jack
> > detection coded into the device tree.
> I wouldn’t call it a replacement exactly. It’s merely a way to bundle all
> of this information about codec glue in the kernel (where it should belong IMO).
No, you're encoding use case decisions into the DT here - for example
your example will break use cases like ring tones and shutter sounds
which should play through both speaker and headphones. It's also
setting volumes which may be inappropriate or may be not and interferes
with userspace using those same physical volume controls.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-22 12:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 19:38 [PATCH 0/2] ASoC: qcom: add apq8039 sound card and bindings Pantelis Antoniou
2020-06-19 19:38 ` [PATCH 1/2] dt-bindings: sound: Device tree bindings for the apq8039 sound complex Pantelis Antoniou
2020-06-19 21:41 ` Stephan Gerhold
2020-06-22 11:34 ` Pantelis Antoniou
2020-06-22 12:04 ` Mark Brown [this message]
2020-06-22 13:32 ` Pantelis Antoniou
2020-06-22 13:41 ` Mark Brown
2020-06-22 14:04 ` Pantelis Antoniou
2020-06-22 16:43 ` Mark Brown
2020-06-22 11:51 ` Mark Brown
2020-06-19 19:38 ` [PATCH 2/2] ASoC: qcom: add apq8039 sound card support Pantelis Antoniou
2020-06-19 21:58 ` kernel test robot
2020-06-20 6:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622120409.GD4560@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mporter@konsulko.com \
--cc=pantelis.antoniou@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).