Linux-Devicetree Archive on lore.kernel.org
 help / color / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: Tomasz Figa <tfiga@chromium.org>,
	linus.walleij@linaro.org, bgolaszewski@baylibre.com,
	mchehab@kernel.org, andriy.shevchenko@linux.intel.com,
	robh+dt@kernel.org, mark.rutland@arm.com, drinkcat@chromium.org,
	matthias.bgg@gmail.com, bingbu.cao@intel.com,
	srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, sj.huang@mediatek.com,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	louis.kuo@mediatek.com, shengnan.wang@mediatek.com
Subject: Re: [PATCH V11 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver
Date: Wed, 1 Jul 2020 12:00:39 +0300
Message-ID: <20200701090039.GM16711@paasikivi.fi.intel.com> (raw)
In-Reply-To: <1593593242.17166.48.camel@mhfsdcap03>

On Wed, Jul 01, 2020 at 04:47:22PM +0800, Dongchun Zhu wrote:
> Hi Tomasz, Sakari,
> 
> Thanks for the review.
> 
> On Tue, 2020-06-30 at 21:47 +0300, Sakari Ailus wrote:
> > On Tue, Jun 30, 2020 at 05:07:46PM +0000, Tomasz Figa wrote:
> > > Hi Dongchun,
> > > 
> > > On Tue, Jun 30, 2020 at 10:49:42AM +0800, Dongchun Zhu wrote:
> > > > Add a V4L2 sub-device driver for OV02A10 image sensor.
> > > > 
> > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> > > > ---
> > > >  MAINTAINERS                 |    1 +
> > > >  drivers/media/i2c/Kconfig   |   13 +
> > > >  drivers/media/i2c/Makefile  |    1 +
> > > >  drivers/media/i2c/ov02a10.c | 1052 +++++++++++++++++++++++++++++++++++++++++++
> > > >  4 files changed, 1067 insertions(+)
> > > >  create mode 100644 drivers/media/i2c/ov02a10.c
> > > 
> > > Thank you for the patch. Please see my comments inline.
> > > 
> > > [snip]
> > > > +static int ov02a10_entity_init_cfg(struct v4l2_subdev *sd,
> > > > +				   struct v4l2_subdev_pad_config *cfg)
> > > > +{
> > > > +	struct v4l2_subdev_format fmt = {
> > > > +		.which = cfg ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE,
> > > 
> > > As we discussed before, this function is never called with cfg == NULL.
> > > Perhaps what we need here is to call ov02a10_set_fmt() twice, once for
> > > V4L2_SUBDEV_FORMAT_ACTIVE and then for V4L2_SUBDEV_FORMAT_TRY?
> > > 
> > > Sakari, would that be a proper implementation of this function?
> > 
> > It's fine to test fmt, but it should be only done if the driver calls the
> > function with ACTIVE format. I.e. it can be removed here, and always use
> > TRY.
> > 
> 
> Sorry for my late coming.
> The implementation of this function should be common(similar to
> OV2680/OV5645).
> If it needs to update to be more proper or clear, as user always sets
> format.which to ACTIVE when calling set_fmt, we could only reserve the
> TRY format in init_cfg like this:
> struct v4l2_subdev_format fmt = {
> 	which = V4L2_SUBDEV_FORMAT_TRY,

Yes, please.

-- 
Sakari Ailus

      reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30  2:49 [PATCH V11 0/2] media: i2c: Add support for 0V02A10 sensor Dongchun Zhu
2020-06-30  2:49 ` [PATCH V11 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Dongchun Zhu
2020-06-30 16:59   ` Tomasz Figa
2020-06-30  2:49 ` [PATCH V11 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver Dongchun Zhu
2020-06-30  9:54   ` Sakari Ailus
2020-06-30 14:19     ` Tomasz Figa
2020-06-30 14:21       ` Tomasz Figa
2020-06-30 14:37         ` Andy Shevchenko
2020-06-30 14:40           ` Tomasz Figa
2020-07-01  7:58             ` Dongchun Zhu
2020-06-30 17:07   ` Tomasz Figa
2020-06-30 18:47     ` Sakari Ailus
2020-07-01  8:47       ` Dongchun Zhu
2020-07-01  9:00         ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701090039.GM16711@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=bingbu.cao@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dongchun.zhu@mediatek.com \
    --cc=drinkcat@chromium.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=louis.kuo@mediatek.com \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=shengnan.wang@mediatek.com \
    --cc=sj.huang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Devicetree Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \
		devicetree@vger.kernel.org
	public-inbox-index linux-devicetree

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git