From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Suman Anna <s-anna@ti.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Lokesh Vutla <lokeshvutla@ti.com>,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] remoteproc: k3-r5: Initialize TCM memories for ECC
Date: Thu, 9 Jul 2020 13:29:23 -0600 [thread overview]
Message-ID: <20200709192923.GB948668@xps15> (raw)
In-Reply-To: <20200630024922.32491-4-s-anna@ti.com>
On Mon, Jun 29, 2020 at 09:49:21PM -0500, Suman Anna wrote:
> The R5F processors on K3 SoCs all have two TCMs (ATCM and BTCM) that
> support 32-bit ECC. The TCMs are typically loaded with some boot-up
> code to initialize the R5 MPUs to further execute code out of DDR.
> The ECC for the TCMs is enabled by default on K3 SoCs due to internal
> default tie-off values, but the TCM memories are not initialized on
> device power up. Any read access without the corresponding TCM memory
> location initialized will generate an ECC error, and any such access
> from a A72 or A53 core will trigger a SError.
>
> So, zero initialize both the TCM memories before loading any firmware
> onto a R5F in remoteproc mode. Any R5F booted from U-Boot/SPL would
> require a similar initialization in the bootloader. Note that both
> the TCMs are initialized unconditionally as the TCM enable config bits
> only manage the access and visibility from R5.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> v2:
> - Fixed the logic of initializing TCMs even when the resets deassertion
> failed
> - Dropped the confusing last sentence from the 2nd paragraph of the
> patch description
> - Revised the patch title to move away from remoteproc/k3-r5
> - Dropped Mathieu's Acked-by because of the changes
> v1: https://patchwork.kernel.org/patch/11456371/
>
> drivers/remoteproc/ti_k3_r5_remoteproc.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> index c4f99e59dc2f..aca0eaf42a38 100644
> --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> @@ -363,11 +363,24 @@ static int k3_r5_rproc_prepare(struct rproc *rproc)
>
> ret = (cluster->mode == CLUSTER_MODE_LOCKSTEP) ?
> k3_r5_lockstep_release(cluster) : k3_r5_split_release(core);
> - if (ret)
> + if (ret) {
> dev_err(dev, "unable to enable cores for TCM loading, ret = %d\n",
> ret);
> + return ret;
> + }
>
> - return ret;
> + /*
> + * Zero out both TCMs unconditionally (access from v8 Arm core is not
> + * affected by ATCM & BTCM enable configuration values) so that ECC
> + * can be effective on all TCM addresses.
> + */
> + dev_dbg(dev, "zeroing out ATCM memory\n");
> + memset(core->mem[0].cpu_addr, 0x00, core->mem[0].size);
> +
> + dev_dbg(dev, "zeroing out BTCM memory\n");
> + memset(core->mem[1].cpu_addr, 0x00, core->mem[1].size);
> +
> + return 0;
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> }
>
> /*
> --
> 2.26.0
>
next prev parent reply other threads:[~2020-07-09 19:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 2:49 [PATCH v2 0/4] TI K3 R5F remoteproc support Suman Anna
2020-06-30 2:49 ` [PATCH v2 1/4] dt-bindings: remoteproc: Add bindings for R5F subsystem on TI K3 SoCs Suman Anna
2020-07-14 17:15 ` Rob Herring
2020-07-16 17:19 ` Mathieu Poirier
2020-07-16 19:43 ` Stefano Stabellini
2020-07-27 22:39 ` Suman Anna
2020-08-10 16:52 ` Suman Anna
2020-08-20 21:53 ` Suman Anna
2020-08-24 20:42 ` Ben Levinsky
2020-06-30 2:49 ` [PATCH v2 2/4] remoteproc: k3-r5: Add a remoteproc driver for R5F subsystem Suman Anna
2020-07-09 18:10 ` Mathieu Poirier
2020-07-09 22:02 ` Suman Anna
2020-06-30 2:49 ` [PATCH v2 3/4] remoteproc: k3-r5: Initialize TCM memories for ECC Suman Anna
2020-07-09 19:29 ` Mathieu Poirier [this message]
2020-06-30 2:49 ` [PATCH v2 4/4] remoteproc: k3-r5: Add loading support for on-chip SRAM regions Suman Anna
2020-07-09 19:51 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709192923.GB948668@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).