From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC70C433E1 for ; Thu, 16 Jul 2020 17:53:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F7AC2070E for ; Thu, 16 Jul 2020 17:53:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728402AbgGPRxF (ORCPT ); Thu, 16 Jul 2020 13:53:05 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:43870 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727844AbgGPRxF (ORCPT ); Thu, 16 Jul 2020 13:53:05 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 3003E20024; Thu, 16 Jul 2020 19:53:00 +0200 (CEST) Date: Thu, 16 Jul 2020 19:52:58 +0200 From: Sam Ravnborg To: Sebastian Reichel Cc: Sebastian Reichel , Tomi Valkeinen , Tony Lindgren , Pavel Machek , Merlijn Wajer , Laurent Pinchart , "H. Nikolaus Schaller" , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, kernel@collabora.com, Rob Herring Subject: Re: [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML Message-ID: <20200716175258.GE2235355@ravnborg.org> References: <20200716125733.83654-1-sebastian.reichel@collabora.com> <20200716125733.83654-2-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200716125733.83654-2-sebastian.reichel@collabora.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=P1BnusSwAAAA:8 a=VwQbUJbxAAAA:8 a=QX4gbG5DAAAA:8 a=gEfo2CItAAAA:8 a=sozttTNsAAAA:8 a=1kXr7ksa4B9EUv6ROdEA:9 a=XEMmv6vUd5EzQcYg:21 a=2If40AUfOTYjr9Pu:21 a=CjuIK1q_8ugA:10 a=D0XLA9XvdZm18NrgonBM:22 a=AjGcO6oz07-iQ99wixmX:22 a=AbAUZ8qAyYyZVLSsDulk:22 a=sptkURWiP4Gy88Gu7hUp:22 a=aeg5Gbbo78KNqacMgKqU:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 16, 2020 at 02:57:30PM +0200, Sebastian Reichel wrote: > Convert panel-dsi-cm bindings to YAML and add > missing properties while at it. > > Reviewed-by: Laurent Pinchart > Reviewed-by: Rob Herring > Signed-off-by: Sebastian Reichel Hi Sebastian. Look good now. Applied this patch to drm-misc-next. $ ls Documentation/devicetree/bindings/display/panel/*.txt Documentation/devicetree/bindings/display/panel/display-timing.txt Nice :-) The DTS file changes needs to go in via another route. Sam > --- > .../bindings/display/panel/panel-dsi-cm.txt | 29 ------- > .../bindings/display/panel/panel-dsi-cm.yaml | 86 +++++++++++++++++++ > 2 files changed, 86 insertions(+), 29 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt > create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt > deleted file mode 100644 > index dce48eb9db57..000000000000 > --- a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt > +++ /dev/null > @@ -1,29 +0,0 @@ > -Generic MIPI DSI Command Mode Panel > -=================================== > - > -Required properties: > -- compatible: "panel-dsi-cm" > - > -Optional properties: > -- label: a symbolic name for the panel > -- reset-gpios: panel reset gpio > -- te-gpios: panel TE gpio > - > -Required nodes: > -- Video port for DSI input > - > -Example > -------- > - > -lcd0: display { > - compatible = "tpo,taal", "panel-dsi-cm"; > - label = "lcd0"; > - > - reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>; > - > - port { > - lcd0_in: endpoint { > - remote-endpoint = <&dsi1_out_ep>; > - }; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml > new file mode 100644 > index 000000000000..d766c949c622 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml > @@ -0,0 +1,86 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/panel-dsi-cm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: DSI command mode panels > + > +maintainers: > + - Tomi Valkeinen > + - Sebastian Reichel > + > +description: | > + This binding file is a collection of the DSI panels that > + are usually driven in command mode. If no backlight is > + referenced via the optional backlight property, the DSI > + panel is assumed to have native backlight support. > + The panel may use an OF graph binding for the association > + to the display, or it may be a direct child node of the > + display. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + > + compatible: > + items: > + - enum: > + - motorola,droid4-panel # Panel from Motorola Droid4 phone > + - nokia,himalaya # Panel from Nokia N950 phone > + - tpo,taal # Panel from OMAP4 SDP board > + - const: panel-dsi-cm # Generic DSI command mode panel compatible fallback > + > + reg: > + maxItems: 1 > + description: DSI virtual channel > + > + vddi-supply: > + description: > + Display panels require power to be supplied. While several panels need > + more than one power supply with panel-specific constraints governing the > + order and timings of the power supplies, in many cases a single power > + supply is sufficient, either because the panel has a single power rail, or > + because all its power rails can be driven by the same supply. In that case > + the vddi-supply property specifies the supply powering the panel as a > + phandle to a regulator. > + > + vpnl-supply: > + description: > + When the display panel needs a second power supply, this property can be > + used in addition to vddi-supply. Both supplies will be enabled at the > + same time before the panel is being accessed. > + > + width-mm: true > + height-mm: true > + label: true > + rotation: true > + panel-timing: true > + port: true > + reset-gpios: true > + te-gpios: true > + backlight: true > + > +additionalProperties: false > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + #include > + > + dsi-controller { > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "tpo,taal", "panel-dsi-cm"; > + reg = <0>; > + reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>; > + }; > + }; > + > +... > -- > 2.27.0