From: Sebastian Reichel <sre@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Tony Lindgren <tony@atomide.com>, Pavel Machek <pavel@ucw.cz>,
Merlijn Wajer <merlijn@wizzup.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, kernel@collabora.com,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML
Date: Thu, 16 Jul 2020 20:07:10 +0200 [thread overview]
Message-ID: <20200716180710.u6pqe6fvn4usuidf@earth.universe> (raw)
In-Reply-To: <20200716175258.GE2235355@ravnborg.org>
[-- Attachment #1: Type: text/plain, Size: 5571 bytes --]
Hi,
On Thu, Jul 16, 2020 at 07:52:58PM +0200, Sam Ravnborg wrote:
> On Thu, Jul 16, 2020 at 02:57:30PM +0200, Sebastian Reichel wrote:
> > Convert panel-dsi-cm bindings to YAML and add
> > missing properties while at it.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Hi Sebastian.
>
> Look good now. Applied this patch to drm-misc-next.
Thanks!
> $ ls Documentation/devicetree/bindings/display/panel/*.txt
> Documentation/devicetree/bindings/display/panel/display-timing.txt
>
> Nice :-)
Indeed.
> The DTS file changes needs to go in via another route.
No worries. I guess Tony will queue them up when he finds some time.
-- Sebastian
>
> Sam
>
> > ---
> > .../bindings/display/panel/panel-dsi-cm.txt | 29 -------
> > .../bindings/display/panel/panel-dsi-cm.yaml | 86 +++++++++++++++++++
> > 2 files changed, 86 insertions(+), 29 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
> > create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
> > deleted file mode 100644
> > index dce48eb9db57..000000000000
> > --- a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
> > +++ /dev/null
> > @@ -1,29 +0,0 @@
> > -Generic MIPI DSI Command Mode Panel
> > -===================================
> > -
> > -Required properties:
> > -- compatible: "panel-dsi-cm"
> > -
> > -Optional properties:
> > -- label: a symbolic name for the panel
> > -- reset-gpios: panel reset gpio
> > -- te-gpios: panel TE gpio
> > -
> > -Required nodes:
> > -- Video port for DSI input
> > -
> > -Example
> > --------
> > -
> > -lcd0: display {
> > - compatible = "tpo,taal", "panel-dsi-cm";
> > - label = "lcd0";
> > -
> > - reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
> > -
> > - port {
> > - lcd0_in: endpoint {
> > - remote-endpoint = <&dsi1_out_ep>;
> > - };
> > - };
> > -};
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml
> > new file mode 100644
> > index 000000000000..d766c949c622
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml
> > @@ -0,0 +1,86 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/panel-dsi-cm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: DSI command mode panels
> > +
> > +maintainers:
> > + - Tomi Valkeinen <tomi.valkeinen@ti.com>
> > + - Sebastian Reichel <sre@kernel.org>
> > +
> > +description: |
> > + This binding file is a collection of the DSI panels that
> > + are usually driven in command mode. If no backlight is
> > + referenced via the optional backlight property, the DSI
> > + panel is assumed to have native backlight support.
> > + The panel may use an OF graph binding for the association
> > + to the display, or it may be a direct child node of the
> > + display.
> > +
> > +allOf:
> > + - $ref: panel-common.yaml#
> > +
> > +properties:
> > +
> > + compatible:
> > + items:
> > + - enum:
> > + - motorola,droid4-panel # Panel from Motorola Droid4 phone
> > + - nokia,himalaya # Panel from Nokia N950 phone
> > + - tpo,taal # Panel from OMAP4 SDP board
> > + - const: panel-dsi-cm # Generic DSI command mode panel compatible fallback
> > +
> > + reg:
> > + maxItems: 1
> > + description: DSI virtual channel
> > +
> > + vddi-supply:
> > + description:
> > + Display panels require power to be supplied. While several panels need
> > + more than one power supply with panel-specific constraints governing the
> > + order and timings of the power supplies, in many cases a single power
> > + supply is sufficient, either because the panel has a single power rail, or
> > + because all its power rails can be driven by the same supply. In that case
> > + the vddi-supply property specifies the supply powering the panel as a
> > + phandle to a regulator.
> > +
> > + vpnl-supply:
> > + description:
> > + When the display panel needs a second power supply, this property can be
> > + used in addition to vddi-supply. Both supplies will be enabled at the
> > + same time before the panel is being accessed.
> > +
> > + width-mm: true
> > + height-mm: true
> > + label: true
> > + rotation: true
> > + panel-timing: true
> > + port: true
> > + reset-gpios: true
> > + te-gpios: true
> > + backlight: true
> > +
> > +additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + dsi-controller {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + panel@0 {
> > + compatible = "tpo,taal", "panel-dsi-cm";
> > + reg = <0>;
> > + reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
> > + };
> > + };
> > +
> > +...
> > --
> > 2.27.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-16 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 12:57 [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings Sebastian Reichel
2020-07-16 12:57 ` [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML Sebastian Reichel
2020-07-16 17:52 ` Sam Ravnborg
2020-07-16 18:07 ` Sebastian Reichel [this message]
2020-08-19 6:46 ` Tony Lindgren
2020-07-16 12:57 ` [PATCHv2 2/4] ARM: dts: omap: add channel to DSI panels Sebastian Reichel
2020-07-16 12:57 ` [PATCHv2 3/4] ARM: dts: omap4-droid4: add panel compatible Sebastian Reichel
2020-07-16 12:57 ` [PATCHv2 4/4] ARM: dts: omap4-droid4: add panel orientation Sebastian Reichel
2020-08-04 10:52 ` [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716180710.u6pqe6fvn4usuidf@earth.universe \
--to=sre@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).