From: Jacopo Mondi <jacopo+renesas@jmondi.org> To: robh+dt@kernel.org, devicetree@vger.kernel.org Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>, slongerbeam@gmail.com, linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com, linux-renesas-soc@vger.kernel.org Subject: [PATCH 06/13] dt-bindings: media: ov5640: Require ep properties Date: Fri, 17 Jul 2020 15:28:52 +0200 Message-ID: <20200717132859.237120-7-jacopo+renesas@jmondi.org> (raw) In-Reply-To: <20200717132859.237120-1-jacopo+renesas@jmondi.org> Now that the bus-type property has been made mandatory for the ov5640 bindings, use the property value to mark endpoint properties as required depending on the data interface in use. Mark as 'required' all the properties that were defined as required in the original bindings in textual form. Adjust the example to comply with validation requirement but do not update the existing users as most of the required properties will be demoted in the next patches. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- .../devicetree/bindings/media/i2c/ov5640.yaml | 41 +++++++++++++++++-- 1 file changed, 38 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml index 16e6c2dc629a..8fd54575a1db 100644 --- a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml @@ -110,9 +110,40 @@ properties: pclk-sample: enum: [0, 1] - required: - - remote-endpoint - - bus-type + allOf: + - if: + properties: + bus-type: + const: 4 + then: + properties: + bus-width: false + data-shift: false + hsync-active: false + vsync-active: false + pclk-sample: false + required: + - remote-endpoint + - bus-type + - clock-lanes + - data-lanes + + - if: + properties: + bus-type: + const: 5 + then: + properties: + clock-lanes: false + data-lanes: false + required: + - remote-endpoint + - bus-type + - bus-width + - data-shift + - hsync-active + - vsync-active + - pclk-sample additionalProperties: false @@ -179,6 +210,10 @@ examples: remote-endpoint = <¶llel_from_ov5640>; bus-type = <5>; bus-width = <10>; + data-shift = <0>; + hsync-active = <1>; + vsync-active = <1>; + pclk-sample = <1>; }; }; }; -- 2.27.0
next prev parent reply index Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-17 13:28 [PATCH 00/13] dt-bindings: media: ov5640: Convert to json-schema Jacopo Mondi 2020-07-17 13:28 ` [PATCH 01/13] " Jacopo Mondi 2020-07-17 19:28 ` Laurent Pinchart 2020-07-20 16:32 ` Rob Herring 2020-07-17 13:28 ` [PATCH 02/13] arm64: dts: qcom: apq8016-sbc: Fix CSI-2 lanes routing Jacopo Mondi 2020-07-17 19:35 ` Laurent Pinchart 2020-07-22 8:14 ` Loic Poulain 2020-07-22 8:34 ` Jacopo Mondi 2020-07-17 13:28 ` [PATCH 03/13] dt-bindings: media: ov5640: Do not limit rotation Jacopo Mondi 2020-07-17 19:38 ` Laurent Pinchart 2020-07-20 19:36 ` Rob Herring 2020-07-17 13:28 ` [PATCH 04/13] dt-bindings: media: ti,cal: Remove sensor from example Jacopo Mondi 2020-07-17 19:39 ` Laurent Pinchart 2020-07-23 20:57 ` Rob Herring 2020-07-17 13:28 ` [PATCH 05/13] dt-bindings: media: ov5640: Make bus-type mandatory Jacopo Mondi 2020-07-17 15:48 ` Fabio Estevam 2020-07-17 19:48 ` Laurent Pinchart 2020-07-20 19:45 ` Rob Herring 2020-07-17 13:28 ` Jacopo Mondi [this message] 2020-07-17 19:50 ` [PATCH 06/13] dt-bindings: media: ov5640: Require ep properties Laurent Pinchart 2020-07-17 13:28 ` [PATCH 07/13] dt-bindings: media: ov5640: Remove clock-lanes Jacopo Mondi 2020-07-17 20:48 ` Laurent Pinchart 2020-07-20 19:47 ` Rob Herring 2020-07-17 13:28 ` [PATCH 08/13] dt-bindings: media: ov5640: Remove data-shift Jacopo Mondi 2020-07-17 20:57 ` Laurent Pinchart 2020-07-23 22:22 ` Sakari Ailus 2020-07-23 23:15 ` Laurent Pinchart 2020-07-25 21:18 ` Sakari Ailus 2020-07-25 21:31 ` Laurent Pinchart 2020-07-29 14:29 ` Sakari Ailus 2020-07-29 14:46 ` Laurent Pinchart 2020-07-30 16:22 ` Sakari Ailus 2020-07-30 16:32 ` Laurent Pinchart 2020-07-30 16:43 ` Sakari Ailus 2020-07-17 13:28 ` [PATCH 09/13] dt-bindings: media: ov5640: Add default for synch signals Jacopo Mondi 2020-07-17 20:59 ` Laurent Pinchart 2020-07-20 19:50 ` Rob Herring 2020-07-17 13:28 ` [PATCH 10/13] dt-bindings: media: ov5640: Demote DVP required properties Jacopo Mondi 2020-07-17 21:00 ` Laurent Pinchart 2020-07-17 13:28 ` [PATCH 11/13] media: i2c: ov5640: Initialize DVP polarities as default Jacopo Mondi 2020-07-17 21:02 ` Laurent Pinchart 2020-07-17 13:28 ` [PATCH 12/13] MAINTAINERS: ov5640: Add bindings file Jacopo Mondi 2020-07-17 21:03 ` Laurent Pinchart 2020-07-17 13:28 ` [PATCH 13/13] dt-bindings: media: ov5640: Add myself as co-maintainer Jacopo Mondi 2020-07-17 21:03 ` Laurent Pinchart 2020-07-17 19:31 ` [PATCH 00/13] dt-bindings: media: ov5640: Convert to json-schema Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200717132859.237120-7-jacopo+renesas@jmondi.org \ --to=jacopo+renesas@jmondi.org \ --cc=devicetree@vger.kernel.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=slongerbeam@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Devicetree Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git git clone --mirror https://lore.kernel.org/linux-devicetree/1 linux-devicetree/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \ devicetree@vger.kernel.org public-inbox-index linux-devicetree Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree AGPL code for this site: git clone https://public-inbox.org/public-inbox.git