From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, slongerbeam@gmail.com, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, bparrot@ti.com Subject: Re: [PATCH 04/13] dt-bindings: media: ti,cal: Remove sensor from example Date: Fri, 17 Jul 2020 22:39:50 +0300 Message-ID: <20200717193950.GF5961@pendragon.ideasonboard.com> (raw) In-Reply-To: <20200717132859.237120-5-jacopo+renesas@jmondi.org> Hi Jacopo, Thank you for the patch. On Fri, Jul 17, 2020 at 03:28:50PM +0200, Jacopo Mondi wrote: > The newly introduced dt-schema bindings for the ov5640 image > sensor triggered a warning in the ti,cal.yaml bindings file, which > has a camera sensor node marked compatible with the sensor. > > As in the example is enough to report a node for the device that > the bindings is about, and maintaining the sensor node up-to-date > is a non-necessary burden, remove the image sensor node from the > ti,cal bindings file. The sensor node in the example gives a bit more clarity, but it's also not super important. I'll let Tomi decide if he wants to keep it (and thus get it fixed), or if he's fine dropping it. Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > .../devicetree/bindings/media/ti,cal.yaml | 22 ------------------- > 1 file changed, 22 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/ti,cal.yaml b/Documentation/devicetree/bindings/media/ti,cal.yaml > index 5e066629287d..fe5c74dd246e 100644 > --- a/Documentation/devicetree/bindings/media/ti,cal.yaml > +++ b/Documentation/devicetree/bindings/media/ti,cal.yaml > @@ -177,26 +177,4 @@ examples: > }; > }; > > - i2c { > - clock-frequency = <400000>; > - #address-cells = <1>; > - #size-cells = <0>; > - > - camera-sensor@3c { > - compatible = "ovti,ov5640"; > - reg = <0x3c>; > - > - clocks = <&clk_ov5640_fixed>; > - clock-names = "xclk"; > - > - port { > - csi2_cam0: endpoint { > - remote-endpoint = <&csi2_phy0>; > - clock-lanes = <0>; > - data-lanes = <1 2>; > - }; > - }; > - }; > - }; > - > ... -- Regards, Laurent Pinchart
next prev parent reply index Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-17 13:28 [PATCH 00/13] dt-bindings: media: ov5640: Convert to json-schema Jacopo Mondi 2020-07-17 13:28 ` [PATCH 01/13] " Jacopo Mondi 2020-07-17 19:28 ` Laurent Pinchart 2020-07-20 16:32 ` Rob Herring 2020-07-17 13:28 ` [PATCH 02/13] arm64: dts: qcom: apq8016-sbc: Fix CSI-2 lanes routing Jacopo Mondi 2020-07-17 19:35 ` Laurent Pinchart 2020-07-22 8:14 ` Loic Poulain 2020-07-22 8:34 ` Jacopo Mondi 2020-07-17 13:28 ` [PATCH 03/13] dt-bindings: media: ov5640: Do not limit rotation Jacopo Mondi 2020-07-17 19:38 ` Laurent Pinchart 2020-07-20 19:36 ` Rob Herring 2020-07-17 13:28 ` [PATCH 04/13] dt-bindings: media: ti,cal: Remove sensor from example Jacopo Mondi 2020-07-17 19:39 ` Laurent Pinchart [this message] 2020-07-23 20:57 ` Rob Herring 2020-07-17 13:28 ` [PATCH 05/13] dt-bindings: media: ov5640: Make bus-type mandatory Jacopo Mondi 2020-07-17 15:48 ` Fabio Estevam 2020-07-17 19:48 ` Laurent Pinchart 2020-07-20 19:45 ` Rob Herring 2020-07-17 13:28 ` [PATCH 06/13] dt-bindings: media: ov5640: Require ep properties Jacopo Mondi 2020-07-17 19:50 ` Laurent Pinchart 2020-07-17 13:28 ` [PATCH 07/13] dt-bindings: media: ov5640: Remove clock-lanes Jacopo Mondi 2020-07-17 20:48 ` Laurent Pinchart 2020-07-20 19:47 ` Rob Herring 2020-07-17 13:28 ` [PATCH 08/13] dt-bindings: media: ov5640: Remove data-shift Jacopo Mondi 2020-07-17 20:57 ` Laurent Pinchart 2020-07-23 22:22 ` Sakari Ailus 2020-07-23 23:15 ` Laurent Pinchart 2020-07-25 21:18 ` Sakari Ailus 2020-07-25 21:31 ` Laurent Pinchart 2020-07-29 14:29 ` Sakari Ailus 2020-07-29 14:46 ` Laurent Pinchart 2020-07-30 16:22 ` Sakari Ailus 2020-07-30 16:32 ` Laurent Pinchart 2020-07-30 16:43 ` Sakari Ailus 2020-07-17 13:28 ` [PATCH 09/13] dt-bindings: media: ov5640: Add default for synch signals Jacopo Mondi 2020-07-17 20:59 ` Laurent Pinchart 2020-07-20 19:50 ` Rob Herring 2020-07-17 13:28 ` [PATCH 10/13] dt-bindings: media: ov5640: Demote DVP required properties Jacopo Mondi 2020-07-17 21:00 ` Laurent Pinchart 2020-07-17 13:28 ` [PATCH 11/13] media: i2c: ov5640: Initialize DVP polarities as default Jacopo Mondi 2020-07-17 21:02 ` Laurent Pinchart 2020-07-17 13:28 ` [PATCH 12/13] MAINTAINERS: ov5640: Add bindings file Jacopo Mondi 2020-07-17 21:03 ` Laurent Pinchart 2020-07-17 13:28 ` [PATCH 13/13] dt-bindings: media: ov5640: Add myself as co-maintainer Jacopo Mondi 2020-07-17 21:03 ` Laurent Pinchart 2020-07-17 19:31 ` [PATCH 00/13] dt-bindings: media: ov5640: Convert to json-schema Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200717193950.GF5961@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=bparrot@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=jacopo+renesas@jmondi.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=slongerbeam@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Devicetree Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git git clone --mirror https://lore.kernel.org/linux-devicetree/1 linux-devicetree/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \ devicetree@vger.kernel.org public-inbox-index linux-devicetree Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree AGPL code for this site: git clone https://public-inbox.org/public-inbox.git