Re: [PATCH 02/13] arm64: dts: qcom: apq8016-sbc: Fix CSI-2 lanes routing

[Jacopo Mondi <jacopo@jmondi.org>]

Hi Loic,

On Wed, Jul 22, 2020 at 10:14:52AM +0200, Loic Poulain wrote:
> On Fri, 17 Jul 2020 at 21:35, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> >
> > Hi Jacopo,
> >
> > On Fri, Jul 17, 2020 at 03:28:48PM +0200, Jacopo Mondi wrote:
> > > The ov5640 sensor does not support lanes reconfiguration according
> > > to version of the datasheet I have (version 2.03) and the driver
> > > does not parse the properties to try to reconfigure them.
> > >
> > > Fix the properties values in the camera and cci node.
> > >
> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > > ---
> > > Loic, I see you added the camera nodes in
> > > 39e0ce6cd1bf ("arm64: dts: qcom: apq8016-sbc: Add CCI/Sensor nodes")
> > >
> > > Do you have any idea how lanes could be swapped if, from my understanding,
> > > nor the sensor nor the driver supports that ?
> >
> > It's not supported on the OV5640 side, so I think the second hunk of
> > this patch is correct, but I believe that the CAMSS supports lane
> > reordering, so the first hunk is likely incorrect and should be dropped.
>
> Indeed, camss supports lane configuration (cf camss_of_parse_endpoint_node).
> The sensor doesn't, so that can be removed on its side.

I removed both as I assumed otherwise lanes assignement doesn't match,
unless there's some lanes re-routing happening in between the two.

I'll drop the property from ov5640 node only.

Thanks
  j

>
> Regards,
> Loic
>
> >
> > > ---
> > >  arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > > index 8a4b790aa7ff..fe6613676e45 100644
> > > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > > @@ -591,8 +591,8 @@ ports {
> > >               port@0 {
> > >                       reg = <0>;
> > >                       csiphy0_ep: endpoint {
> > > -                             clock-lanes = <1>;
> > > -                             data-lanes = <0 2>;
> > > +                             clock-lanes = <0>;
> > > +                             data-lanes = <1 2>;
> > >                               remote-endpoint = <&ov5640_ep>;
> > >                               status = "okay";
> > >                       };
> > > @@ -627,8 +627,8 @@ camera_rear@3b {
> > >
> > >               port {
> > >                       ov5640_ep: endpoint {
> > > -                             clock-lanes = <1>;
> > > -                             data-lanes = <0 2>;
> > > +                             clock-lanes = <0>;
> > > +                             data-lanes = <1 2>;
> > >                               remote-endpoint = <&csiphy0_ep>;
> > >                       };
> > >               };
> >
> > --
> > Regards,
> >
> > Laurent Pinchart