devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Marek Vasut <marex@denx.de>
Cc: dri-devel@lists.freedesktop.org, Eric Anholt <eric@anholt.net>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH V2 2/2] drm/bridge: tc358762: Add basic driver for Toshiba TC358762 DSI-to-DPI bridge
Date: Wed, 29 Jul 2020 19:09:07 +0200	[thread overview]
Message-ID: <20200729170907.GA1375231@ravnborg.org> (raw)
In-Reply-To: <3f9702f1-062e-a43c-3297-eb5baacaa81c@denx.de>

Hi Marek.

On Wed, Jul 29, 2020 at 07:02:51PM +0200, Marek Vasut wrote:
> On 7/29/20 6:56 PM, Sam Ravnborg wrote:
> [...]
> >> +static int tc358762_probe(struct mipi_dsi_device *dsi)
> >> +{
> >> +	struct device *dev = &dsi->dev;
> >> +	struct tc358762 *ctx;
> >> +	int ret;
> >> +
> >> +	ctx = devm_kzalloc(dev, sizeof(struct tc358762), GFP_KERNEL);
> >> +	if (!ctx)
> >> +		return -ENOMEM;
> >> +
> >> +	mipi_dsi_set_drvdata(dsi, ctx);
> > I cannot see why this is needed. If not used then delete it.
> > With the above addressed:
> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> > 
> > Let me know if I shall apply - but we have to wait until binding is
> > reviewed. And preferably one extra set of eyes on this driver.
> 
> [...]
> 
> >> +static int tc358762_remove(struct mipi_dsi_device *dsi)
> >> +{
> >> +	struct tc358762 *ctx = mipi_dsi_get_drvdata(dsi);
> >> +
> >> +	mipi_dsi_detach(dsi);
> >> +	drm_bridge_remove(&ctx->bridge);
> 
> Because it's used here in the remove callback.

Thanks - missed that.
So consider the point addressed by enlightning me.

	Sam

  reply	other threads:[~2020-07-29 17:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 16:45 [PATCH V2 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge Marek Vasut
2020-07-29 16:45 ` [PATCH V2 2/2] drm/bridge: tc358762: Add basic driver " Marek Vasut
2020-07-29 16:56   ` Sam Ravnborg
2020-07-29 17:02     ` Marek Vasut
2020-07-29 17:09       ` Sam Ravnborg [this message]
2020-07-29 16:59 ` [PATCH V2 1/2] dt-bindings: Add DT bindings " Sam Ravnborg
2020-07-29 21:36   ` Marek Vasut
2020-07-30  6:33     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729170907.GA1375231@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=marex@denx.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).