From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rob Herring" <robh+dt@kernel.org>,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Noralf Trønnes" <noralf@tronnes.org>,
devicetree@vger.kernel.org, od@zcrc.me,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/6] dt-bindings: display: Document NewVision NV3052C DT node
Date: Wed, 29 Jul 2020 20:10:47 +0300 [thread overview]
Message-ID: <20200729171047.GA18755@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200727164613.19744-2-paul@crapouillou.net>
Hi Paul,
Thank you for the patch.
On Mon, Jul 27, 2020 at 06:46:08PM +0200, Paul Cercueil wrote:
> Add documentation for the Device Tree node for LCD panels based on the
> NewVision NV3052C controller.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> .../display/panel/newvision,nv3052c.yaml | 69 +++++++++++++++++++
> 1 file changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3052c.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3052c.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3052c.yaml
> new file mode 100644
> index 000000000000..751a28800fc2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3052c.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/newvision,nv3052c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NewVision NV3052C TFT LCD panel driver with SPI control bus
s/driver/driver IC/ (or driver chip, or controller, or any other similar
term) to avoid confusion with device drivers.
Do I understand that the NV3052C also supports control through DSI ?
Shouldn't this appear in the DT bindings ? Do I assume correctly that
the panel will be controlled either through SPI or through DSI, but not
through both ?
> +
> +maintainers:
> + - Paul Cercueil <paul@crapouillou.net>
> +
> +description: |
> + This is a driver for 320x240 TFT panels, accepting a variety of input
> + streams that get adapted and scaled to the panel. The panel output has
> + 960 TFT source driver pins and 240 TFT gate driver pins, VCOM, VCOML and
> + VCOMH outputs.
> +
> + The panel must obey the rules for a SPI slave device as specified in
> + spi/spi-controller.yaml
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - leadtek,ltk035c5444t-spi
According to its datasheet, that panel is 640x480 :-)
I think you need a bit of documentation to explain that two compatible
strings are needed, one matching the panel type, and a second one
matching the chip.
> +
> + - const: newvision,nv3052c
> +
> + reg:
> + maxItems: 1
> +
> + reset-gpios: true
> + port: true
The NV3052C requires multiple power supplies, I think this needs to be
taken into account here.
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + display@0 {
> + compatible = "leadtek,ltk035c5444t-spi", "newvision,nv3052c";
> + reg = <0>;
> +
> + spi-max-frequency = <15000000>;
> + spi-3wire;
> + reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
> + backlight = <&backlight>;
> + power-supply = <&vcc>;
> +
> + port {
> + panel_input: endpoint {
> + remote-endpoint = <&panel_output>;
> + };
> + };
> + };
> + };
> +
> +...
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-07-29 17:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 16:46 [PATCH 0/6] DBI/DSI, panel drivers, and tinyDRM compat Paul Cercueil
2020-07-27 16:46 ` [PATCH 1/6] dt-bindings: display: Document NewVision NV3052C DT node Paul Cercueil
2020-07-27 19:10 ` Sam Ravnborg
2020-07-27 19:24 ` Maarten ter Huurne
2020-07-29 17:10 ` Laurent Pinchart [this message]
2020-07-27 16:46 ` [PATCH 2/6] drm: dsi: Let host and device specify supported bus Paul Cercueil
2020-07-27 17:02 ` Laurent Pinchart
2020-07-27 17:59 ` Paul Cercueil
2020-07-27 20:03 ` Sam Ravnborg
2020-07-27 16:46 ` [PATCH 3/6] drm/bridge: Add SPI DBI host driver Paul Cercueil
2020-07-27 17:06 ` Laurent Pinchart
2020-07-27 17:54 ` Paul Cercueil
2020-07-27 20:31 ` Sam Ravnborg
2020-07-27 21:10 ` Paul Cercueil
2020-07-27 16:46 ` [PATCH 4/6] drm/panel: Add panel driver for NewVision NV3052C based LCDs Paul Cercueil
2020-07-30 19:50 ` Sam Ravnborg
2020-07-27 16:46 ` [PATCH 5/6] drm/tiny: Add TinyDRM for DSI/DBI panels Paul Cercueil
2020-07-27 16:46 ` [PATCH 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729171047.GA18755@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=noralf@tronnes.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).