[PATCH v1 0/3] Add missing ethernet reset ID for Amlogic SoC

[PATCH v1 0/3] Add missing ethernet reset ID for Amlogic SoC

[Anand Moon]

These patch fix the Ethernet issue on Odroid C2 & Odroid N2 
Some time Ethernet interface come up but no DHCP request
is forwaded to the Router, this happens quite offern on
my side. Adding Reset controller to ethernet node FIx the
inilization issue.

-Anand

Anand Moon (3):
  arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
  arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
  arm64: dts: amlogic: meson-g12: add missing ethernet reset ID

 arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 2 ++
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi         | 3 +++
 3 files changed, 7 insertions(+)

-- 
2.28.0

[PATCH v1 1/3] arm64: dts: amlogic: meson-gx: add missing ethernet reset ID

[Anand Moon]

Add missing etherent reset ID for reset controller to reset
ethernet mac controller.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index ba63c36b22e0..8720c83990ce 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
@@ -12,6 +12,7 @@
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/reset/amlogic,meson-gxbb-reset.h>
 #include <dt-bindings/thermal/thermal.h>
 
 / {
@@ -574,6 +575,8 @@ ethmac: ethernet@c9410000 {
 			interrupt-names = "macirq";
 			rx-fifo-depth = <4096>;
 			tx-fifo-depth = <2048>;
+			resets = <&reset RESET_ETHERNET>;
+			reset-names = "stmmaceth";
 			status = "disabled";
 		};
 
-- 
2.28.0

[PATCH v1 2/3] arm64: dts: amlogic: meson-axg: add missing ethernet reset ID

[Anand Moon]

Add missing etherent reset ID for reset controller to reset
ethernet mac controller.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 8e6281c685fa..61adc5592211 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -185,6 +185,8 @@ ethmac: ethernet@ff3f0000 {
 			clock-names = "stmmaceth", "clkin0", "clkin1";
 			rx-fifo-depth = <4096>;
 			tx-fifo-depth = <2048>;
+			resets = <&reset RESET_ETHERNET>;
+			reset-names = "stmmaceth";
 			status = "disabled";
 		};
 
-- 
2.28.0

[PATCH v1 3/3] arm64: dts: amlogic: meson-g12: add missing ethernet reset ID

[Anand Moon]

Add missing etherent reset ID for reset controller to reset
ethernet mac controller.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index 593a006f4b7b..7f291e6e9847 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -189,6 +189,8 @@ ethmac: ethernet@ff3f0000 {
 			clock-names = "stmmaceth", "clkin0", "clkin1";
 			rx-fifo-depth = <4096>;
 			tx-fifo-depth = <2048>;
+			resets = <&reset RESET_ETHERNET>;
+			reset-names = "stmmaceth";
 			status = "disabled";
 
 			mdio0: mdio {
-- 
2.28.0

Re: [PATCH v1 0/3] Add missing ethernet reset ID for Amlogic SoC

[Jerome Brunet]

On Thu 30 Jul 2020 at 12:02, Anand Moon <linux.amoon@gmail.com> wrote:

> These patch fix the Ethernet issue on Odroid C2 & Odroid N2 
> Some time Ethernet interface come up but no DHCP request
> is forwaded to the Router, this happens quite offern on
> my side. Adding Reset controller to ethernet node FIx the
> inilization issue.
>

I'm seeing this on other device as well. Strange that it pops up only
now. Change tested on S905x, seems to help.

> -Anand
>
> Anand Moon (3):
>   arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
>   arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
>   arm64: dts: amlogic: meson-g12: add missing ethernet reset ID

None of the patches apply, please rebase on kevin's dt64 branch.

With that, you can add

Tested-by: Jerome Brunet <jbrunet@baylibre.com>

>
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 2 ++
>  arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++
>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi         | 3 +++
>  3 files changed, 7 insertions(+)

Re: [PATCH v1 0/3] Add missing ethernet reset ID for Amlogic SoC

[Jerome Brunet]

On Thu 30 Jul 2020 at 13:57, Jerome Brunet <jbrunet@baylibre.com> wrote:

> On Thu 30 Jul 2020 at 12:02, Anand Moon <linux.amoon@gmail.com> wrote:
>
>> These patch fix the Ethernet issue on Odroid C2 & Odroid N2 
>> Some time Ethernet interface come up but no DHCP request
>> is forwaded to the Router, this happens quite offern on
>> my side. Adding Reset controller to ethernet node FIx the
>> inilization issue.
>>
>
> I'm seeing this on other device as well. Strange that it pops up only
> now. Change tested on S905x, seems to help.

Strike that one - still seeing random DHCP issue on boot with this
applied

>
>> -Anand
>>
>> Anand Moon (3):
>>   arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
>>   arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
>>   arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
>
> None of the patches apply, please rebase on kevin's dt64 branch.
>
> With that, you can add
>
> Tested-by: Jerome Brunet <jbrunet@baylibre.com>

So still worth rebasing and applying on I suppose but I don't think it
solves the problem as described in this cover letter.

>
>>
>>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 2 ++
>>  arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 ++
>>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi         | 3 +++
>>  3 files changed, 7 insertions(+)

Re: [PATCH v1 0/3] Add missing ethernet reset ID for Amlogic SoC

[Anand Moon]

Hi Jerome

On Thu, 30 Jul 2020 at 17:44, Jerome Brunet <jbrunet@baylibre.com> wrote:
>
>
> On Thu 30 Jul 2020 at 13:57, Jerome Brunet <jbrunet@baylibre.com> wrote:
>
> > On Thu 30 Jul 2020 at 12:02, Anand Moon <linux.amoon@gmail.com> wrote:
> >
> >> These patch fix the Ethernet issue on Odroid C2 & Odroid N2
> >> Some time Ethernet interface come up but no DHCP request
> >> is forwaded to the Router, this happens quite offern on
> >> my side. Adding Reset controller to ethernet node FIx the
> >> inilization issue.
> >>
> >
> > I'm seeing this on other device as well. Strange that it pops up only
> > now. Change tested on S905x, seems to help.
>
> Strike that one - still seeing random DHCP issue on boot with this
> applied
>
> >
> >> -Anand
> >>
> >> Anand Moon (3):
> >>   arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
> >>   arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
> >>   arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
> >
> > None of the patches apply, please rebase on kevin's dt64 branch.
> >
> > With that, you can add
> >
> > Tested-by: Jerome Brunet <jbrunet@baylibre.com>
>
So I have to drop the Tested-by  ?

> So still worth rebasing and applying on I suppose but I don't think it
> solves the problem as described in this cover letter.
>

I have a mac address mapped to the ip address on my router,
So I am just testing with the latest u-boot-2000.07 on my boards.
Usually the ethernet comes up with no packet getting forwarded,
Even ping to the device is not working, which is what I observed at
my end many times.

I will try to rebase on top of Kevin's v5.9/dt64 if needed.
Please let me know.

-Anand

Re: [PATCH v1 0/3] Add missing ethernet reset ID for Amlogic SoC

[Jerome Brunet]

On Thu 30 Jul 2020 at 15:46, Anand Moon <linux.amoon@gmail.com> wrote:

> Hi Jerome
>
> On Thu, 30 Jul 2020 at 17:44, Jerome Brunet <jbrunet@baylibre.com> wrote:
>>
>>
>> On Thu 30 Jul 2020 at 13:57, Jerome Brunet <jbrunet@baylibre.com> wrote:
>>
>> > On Thu 30 Jul 2020 at 12:02, Anand Moon <linux.amoon@gmail.com> wrote:
>> >
>> >> These patch fix the Ethernet issue on Odroid C2 & Odroid N2
>> >> Some time Ethernet interface come up but no DHCP request
>> >> is forwaded to the Router, this happens quite offern on
>> >> my side. Adding Reset controller to ethernet node FIx the
>> >> inilization issue.
>> >>
>> >
>> > I'm seeing this on other device as well. Strange that it pops up only
>> > now. Change tested on S905x, seems to help.
>>
>> Strike that one - still seeing random DHCP issue on boot with this
>> applied
>>
>> >
>> >> -Anand
>> >>
>> >> Anand Moon (3):
>> >>   arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
>> >>   arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
>> >>   arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
>> >
>> > None of the patches apply, please rebase on kevin's dt64 branch.
>> >
>> > With that, you can add
>> >
>> > Tested-by: Jerome Brunet <jbrunet@baylibre.com>
>>
> So I have to drop the Tested-by  ?

Yes

>
>> So still worth rebasing and applying on I suppose but I don't think it
>> solves the problem as described in this cover letter.
>>
>
> I have a mac address mapped to the ip address on my router,
> So I am just testing with the latest u-boot-2000.07 on my boards.
> Usually the ethernet comes up with no packet getting forwarded,
> Even ping to the device is not working, which is what I observed at
> my end many times.

This is not the use case descibed in the cover letter. Please clarify if
you resubmit.

>
> I will try to rebase on top of Kevin's v5.9/dt64 if needed.

If you intend on submitting the series again, rebasing is necessary.

> Please let me know.
>
> -Anand

Re: [PATCH v1 0/3] Add missing ethernet reset ID for Amlogic SoC

[Anand Moon]

Hi Jerome,

On Thu, 30 Jul 2020 at 19:25, Jerome Brunet <jbrunet@baylibre.com> wrote:
>
>
> On Thu 30 Jul 2020 at 15:46, Anand Moon <linux.amoon@gmail.com> wrote:
>
> > Hi Jerome
> >
> > On Thu, 30 Jul 2020 at 17:44, Jerome Brunet <jbrunet@baylibre.com> wrote:
> >>
> >>
> >> On Thu 30 Jul 2020 at 13:57, Jerome Brunet <jbrunet@baylibre.com> wrote:
> >>
> >> > On Thu 30 Jul 2020 at 12:02, Anand Moon <linux.amoon@gmail.com> wrote:
> >> >
> >> >> These patch fix the Ethernet issue on Odroid C2 & Odroid N2
> >> >> Some time Ethernet interface come up but no DHCP request
> >> >> is forwaded to the Router, this happens quite offern on
> >> >> my side. Adding Reset controller to ethernet node FIx the
> >> >> inilization issue.
> >> >>
> >> >
> >> > I'm seeing this on other device as well. Strange that it pops up only
> >> > now. Change tested on S905x, seems to help.
> >>
> >> Strike that one - still seeing random DHCP issue on boot with this
> >> applied
> >>
> >> >
> >> >> -Anand
> >> >>
> >> >> Anand Moon (3):
> >> >>   arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
> >> >>   arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
> >> >>   arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
> >> >
> >> > None of the patches apply, please rebase on kevin's dt64 branch.
> >> >
> >> > With that, you can add
> >> >
> >> > Tested-by: Jerome Brunet <jbrunet@baylibre.com>
> >>
> > So I have to drop the Tested-by  ?
>
> Yes
>
> >
> >> So still worth rebasing and applying on I suppose but I don't think it
> >> solves the problem as described in this cover letter.
> >>
> >
> > I have a mac address mapped to the ip address on my router,
> > So I am just testing with the latest u-boot-2000.07 on my boards.
> > Usually the ethernet comes up with no packet getting forwarded,
> > Even ping to the device is not working, which is what I observed at
> > my end many times.
>
> This is not the use case descibed in the cover letter. Please clarify if
> you resubmit.
>

This was some observation at my end. If these changes don't fix the issue.
I will drop my observation and just send the missing reset controller
for ethernet

-Anand