* [PATCH V2] dt-bindings: iio: adc: maxim,max1118 yaml conversion
@ 2020-08-01 17:58 Jonathan Cameron
2020-08-03 21:58 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2020-08-01 17:58 UTC (permalink / raw)
To: linux-iio; +Cc: Rob Herring, devicetree, Jonathan Cameron, Akinobu Mita
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Simple device with a simple conversion. Special handling needed
for the max1118 which is the only supported part that has an external
reference voltage.
Cc: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
v2:
* Added additionalProperties: false. Other changes are to make this work.
* Move the vref-supply definition up
* Add an else clause
.../devicetree/bindings/iio/adc/max1118.txt | 21 -------
.../bindings/iio/adc/maxim,max1118.yaml | 62 +++++++++++++++++++
2 files changed, 62 insertions(+), 21 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/max1118.txt b/Documentation/devicetree/bindings/iio/adc/max1118.txt
deleted file mode 100644
index cf33d0b15a6d..000000000000
--- a/Documentation/devicetree/bindings/iio/adc/max1118.txt
+++ /dev/null
@@ -1,21 +0,0 @@
-* MAX1117/MAX1118/MAX1119 8-bit, dual-channel ADCs
-
-Required properties:
- - compatible: Should be one of
- * "maxim,max1117"
- * "maxim,max1118"
- * "maxim,max1119"
- - reg: spi chip select number for the device
- - (max1118 only) vref-supply: The regulator supply for ADC reference voltage
-
-Recommended properties:
- - spi-max-frequency: Definition as per
- Documentation/devicetree/bindings/spi/spi-bus.txt
-
-Example:
-adc@0 {
- compatible = "maxim,max1118";
- reg = <0>;
- vref-supply = <&vdd_supply>;
- spi-max-frequency = <1000000>;
-};
diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1118.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1118.yaml
new file mode 100644
index 000000000000..e948b3e37b0c
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1118.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/maxim,max1118.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX1118 and similar ADCs
+
+maintainers:
+ - Akinobu Mita <akinobu.mita@gmail.com>
+
+description: |
+ Dual channel 8bit ADCs.
+
+properties:
+ compatible:
+ enum:
+ - maxim,max1117
+ - maxim,max1118
+ - maxim,max1119
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency:
+ maximum: 5000000
+
+ vref-supply:
+ description: External reference, needed to establish input scaling
+
+if:
+ properties:
+ compatible:
+ contains:
+ const: maxim,max1118
+then:
+ required:
+ - vref-supply
+else:
+ properties:
+ vref-supply: false
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ adc@0 {
+ compatible = "maxim,max1118";
+ reg = <0>;
+ vref-supply = <&adc_vref>;
+ spi-max-frequency = <1000000>;
+ };
+ };
+...
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] dt-bindings: iio: adc: maxim,max1118 yaml conversion
2020-08-01 17:58 [PATCH V2] dt-bindings: iio: adc: maxim,max1118 yaml conversion Jonathan Cameron
@ 2020-08-03 21:58 ` Rob Herring
2020-08-06 18:05 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2020-08-03 21:58 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jonathan Cameron, Akinobu Mita, devicetree, Rob Herring, linux-iio
On Sat, 01 Aug 2020 18:58:50 +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Simple device with a simple conversion. Special handling needed
> for the max1118 which is the only supported part that has an external
> reference voltage.
>
> Cc: Akinobu Mita <akinobu.mita@gmail.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> v2:
> * Added additionalProperties: false. Other changes are to make this work.
> * Move the vref-supply definition up
> * Add an else clause
>
> .../devicetree/bindings/iio/adc/max1118.txt | 21 -------
> .../bindings/iio/adc/maxim,max1118.yaml | 62 +++++++++++++++++++
> 2 files changed, 62 insertions(+), 21 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] dt-bindings: iio: adc: maxim,max1118 yaml conversion
2020-08-03 21:58 ` Rob Herring
@ 2020-08-06 18:05 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2020-08-06 18:05 UTC (permalink / raw)
To: Rob Herring
Cc: Jonathan Cameron, Akinobu Mita, devicetree, Rob Herring, linux-iio
On Mon, 3 Aug 2020 15:58:26 -0600
Rob Herring <robh@kernel.org> wrote:
> On Sat, 01 Aug 2020 18:58:50 +0100, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Simple device with a simple conversion. Special handling needed
> > for the max1118 which is the only supported part that has an external
> > reference voltage.
> >
> > Cc: Akinobu Mita <akinobu.mita@gmail.com>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> > v2:
> > * Added additionalProperties: false. Other changes are to make this work.
> > * Move the vref-supply definition up
> > * Add an else clause
> >
> > .../devicetree/bindings/iio/adc/max1118.txt | 21 -------
> > .../bindings/iio/adc/maxim,max1118.yaml | 62 +++++++++++++++++++
> > 2 files changed, 62 insertions(+), 21 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Thanks,
Applied to the togreg branch off iio.git and pushed out as testing for autobuilders
etc.
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-06 18:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-01 17:58 [PATCH V2] dt-bindings: iio: adc: maxim,max1118 yaml conversion Jonathan Cameron
2020-08-03 21:58 ` Rob Herring
2020-08-06 18:05 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).