devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xia Jiang <xia.jiang@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rick Chang <rick.chang@mediatek.com>
Cc: <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Tomasz Figa <tfiga@chromium.org>, <srv_heupstream@mediatek.com>,
	<senozhatsky@chromium.org>, <mojahsu@chromium.org>,
	<drinkcat@chromium.org>, <maoguang.meng@mediatek.com>,
	Xia Jiang <xia.jiang@mediatek.com>
Subject: [PATCH v11 22/28] media: platform: Change the call functions of getting/enable/disable the jpeg's clock
Date: Tue, 4 Aug 2020 11:40:56 +0800	[thread overview]
Message-ID: <20200804034102.22983-23-xia.jiang@mediatek.com> (raw)
In-Reply-To: <20200804034102.22983-1-xia.jiang@mediatek.com>

Use the generic clk_bulk_* helpers to enable and disable clocks.

Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
---
v11: specify the names of the clocks in the driver
---
 .../media/platform/mtk-jpeg/mtk_jpeg_core.c   | 28 +++++++++++++------
 .../media/platform/mtk-jpeg/mtk_jpeg_core.h   |  8 +++---
 2 files changed, 23 insertions(+), 13 deletions(-)

diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index 7881e9c93df7..47d570f32e3f 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -783,14 +783,15 @@ static void mtk_jpeg_clk_on(struct mtk_jpeg_dev *jpeg)
 	ret = mtk_smi_larb_get(jpeg->larb);
 	if (ret)
 		dev_err(jpeg->dev, "mtk_smi_larb_get larbvdec fail %d\n", ret);
-	clk_prepare_enable(jpeg->clk_jdec_smi);
-	clk_prepare_enable(jpeg->clk_jdec);
+
+	ret = clk_bulk_prepare_enable(jpeg->num_clks, jpeg->clks);
+	if (ret)
+		dev_err(jpeg->dev, "Failed to open jpeg clk: %d\n", ret);
 }
 
 static void mtk_jpeg_clk_off(struct mtk_jpeg_dev *jpeg)
 {
-	clk_disable_unprepare(jpeg->clk_jdec);
-	clk_disable_unprepare(jpeg->clk_jdec_smi);
+	clk_bulk_disable_unprepare(jpeg->num_clks, jpeg->clks);
 	mtk_smi_larb_put(jpeg->larb);
 }
 
@@ -935,10 +936,16 @@ static const struct v4l2_file_operations mtk_jpeg_fops = {
 	.mmap           = v4l2_m2m_fop_mmap,
 };
 
+static struct clk_bulk_data mt8173_jpeg_dec_clocks[] = {
+	{ .id = "jpgdec-smi" },
+	{ .id = "jpgdec" },
+};
+
 static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg)
 {
 	struct device_node *node;
 	struct platform_device *pdev;
+	int ret;
 
 	node = of_parse_phandle(jpeg->dev->of_node, "mediatek,larb", 0);
 	if (!node)
@@ -952,12 +959,15 @@ static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg)
 
 	jpeg->larb = &pdev->dev;
 
-	jpeg->clk_jdec = devm_clk_get(jpeg->dev, "jpgdec");
-	if (IS_ERR(jpeg->clk_jdec))
-		return PTR_ERR(jpeg->clk_jdec);
+	jpeg->clks = mt8173_jpeg_dec_clocks;
+	jpeg->num_clks = ARRAY_SIZE(mt8173_jpeg_dec_clocks);
+	ret = devm_clk_bulk_get(jpeg->dev, jpeg->num_clks, jpeg->clks);
+	if (ret) {
+		dev_err(&pdev->dev, "failed to get jpeg clock:%d\n", ret);
+		return ret;
+	}
 
-	jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi");
-	return PTR_ERR_OR_ZERO(jpeg->clk_jdec_smi);
+	return 0;
 }
 
 static void mtk_jpeg_job_timeout_work(struct work_struct *work)
diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h
index 4c76a9dcc4b7..a54e1e82e655 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h
@@ -52,8 +52,8 @@ enum mtk_jpeg_ctx_state {
  * @alloc_ctx:		videobuf2 memory allocator's context
  * @dec_vdev:		video device node for decoder mem2mem mode
  * @dec_reg_base:	JPEG registers mapping
- * @clk_jdec:		JPEG hw working clock
- * @clk_jdec_smi:	JPEG SMI bus clock
+ * @clks:		clock names
+ * @num_clks:		numbers of clock
  * @larb:		SMI device
  * @job_timeout_work:	IRQ timeout structure
  */
@@ -67,8 +67,8 @@ struct mtk_jpeg_dev {
 	void			*alloc_ctx;
 	struct video_device	*dec_vdev;
 	void __iomem		*dec_reg_base;
-	struct clk		*clk_jdec;
-	struct clk		*clk_jdec_smi;
+	struct clk_bulk_data *clks;
+	int num_clks;
 	struct device		*larb;
 	struct delayed_work job_timeout_work;
 };
-- 
2.18.0

  parent reply	other threads:[~2020-08-04  3:42 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04  3:40 [PATCH v11 00/28] Add support for mt2701 JPEG ENC support Xia Jiang
2020-08-04  3:40 ` [PATCH v11 01/28] media: platform: Improve subscribe event flow for bug fixing Xia Jiang
2020-08-04  3:40 ` [PATCH v11 02/28] media: platform: Improve queue set up " Xia Jiang
2020-08-04  3:40 ` [PATCH v11 03/28] media: platform: Improve getting and requesting irq " Xia Jiang
2020-08-04  3:40 ` [PATCH v11 04/28] media: platform: Change the fixed device node number to unfixed value Xia Jiang
2020-08-04  3:40 ` [PATCH v11 05/28] media: platform: Improve power on and power off flow Xia Jiang
2020-08-04  3:40 ` [PATCH v11 06/28] media: platform: Delete the resetting hardware flow in the system PM ops Xia Jiang
2020-08-04  3:40 ` [PATCH v11 07/28] media: platform: Improve the implementation of " Xia Jiang
2020-08-04  3:40 ` [PATCH v11 08/28] media: platform: Add mechanism to handle jpeg hardware's locking up Xia Jiang
2020-08-04  3:40 ` [PATCH v11 09/28] media: platform: Cancel the last frame handling flow Xia Jiang
2020-08-04  3:40 ` [PATCH v11 10/28] media: platform: Delete zeroing the reserved fields Xia Jiang
2020-08-04  3:40 ` [PATCH v11 11/28] media: platform: Stylistic changes for improving code quality Xia Jiang
2020-08-04  3:40 ` [PATCH v11 12/28] media: platform: Use generic rounding helpers Xia Jiang
2020-08-04  3:40 ` [PATCH v11 13/28] media: platform: Change MTK_JPEG_COMP_MAX macro definition location Xia Jiang
2020-08-04  3:40 ` [PATCH v11 14/28] media: platform: Delete redundant code and add annotation for an enum Xia Jiang
2020-08-04  3:40 ` [PATCH v11 15/28] media: platform: Delete vidioc_s_selection ioctl of jpeg dec Xia Jiang
2020-08-04  3:40 ` [PATCH v11 16/28] media: platform: Change the maximum width and height supported by JPEG dec Xia Jiang
2020-08-04  3:40 ` [PATCH v11 17/28] media: platform: Refactor mtk_jpeg_try_fmt_mplane() Xia Jiang
2020-08-04  3:40 ` [PATCH v11 18/28] media: platform: Refactor mtk_jpeg_find_format() Xia Jiang
2020-08-04  3:40 ` [PATCH v11 19/28] media: platform: Redefinition of mtk_jpeg_q_data structure Xia Jiang
2020-08-04  3:40 ` [PATCH v11 20/28] media: platform: Change the colorspace of jpeg to the fixed value Xia Jiang
2020-08-04  3:40 ` [PATCH v11 21/28] media: platform: Refactor mtk_jpeg_set_default_params() Xia Jiang
2020-08-04  3:40 ` Xia Jiang [this message]
2020-08-05 13:55   ` [PATCH v11 22/28] media: platform: Change the call functions of getting/enable/disable the jpeg's clock Tomasz Figa
2020-08-04  3:40 ` [PATCH v11 23/28] media: dt-bindings: Add jpeg enc device tree node document Xia Jiang
2020-08-04  3:40 ` [PATCH v11 24/28] arm: dts: mt2701: Add jpeg enc device tree node Xia Jiang
2020-08-04  3:40 ` [PATCH v11 25/28] media: platform: Rename jpeg dec file name Xia Jiang
2020-08-04  3:41 ` [PATCH v11 26/28] media: platform: Rename existing functions/defines/variables Xia Jiang
2020-08-04  3:41 ` [PATCH v11 27/28] media: platform: Using the variant structure to contain the varability between dec and enc Xia Jiang
2020-08-04  3:41 ` [PATCH v11 28/28] media: platform: Add jpeg enc feature Xia Jiang
2020-08-05  8:45 ` [PATCH v11 00/28] Add support for mt2701 JPEG ENC support Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804034102.22983-23-xia.jiang@mediatek.com \
    --to=xia.jiang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=maoguang.meng@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=mojahsu@chromium.org \
    --cc=rick.chang@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).