From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH] ARM: dts: iwg20d-q7-common: Fix touch controller probe failure
Date: Sun, 9 Aug 2020 00:28:58 +0300 [thread overview]
Message-ID: <20200808212858.GV6186@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200807152039.10961-1-biju.das.jz@bp.renesas.com>
Hi Biju,
Thank you for the patch.
On Fri, Aug 07, 2020 at 04:20:38PM +0100, Biju Das wrote:
> Remove powerdown-gpios property from lvds-receiver node as it results in
> touch controller driver probe failure.
> As per the iWave RZ/G1M schematic, the signal LVDS_PPEN controls supply
> voltage for touch panel, LVDS receiver and RGB LCD panel.
If it controls the supply voltage, shouldn't it be modelled as a
regulator ? Dropping it completely would rely on the boot loader
powering the display on and keeping it powered, which isn't very nice.
> Fixes: 6f89dd9e9325 ("ARM: dts: iwg20d-q7-common: Add LCD support")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> arch/arm/boot/dts/iwg20d-q7-common.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> index ebbe1518ef8a..4c8b9a6b0125 100644
> --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> @@ -57,7 +57,6 @@
>
> lvds-receiver {
> compatible = "ti,ds90cf384a", "lvds-decoder";
> - powerdown-gpios = <&gpio7 25 GPIO_ACTIVE_LOW>;
>
> ports {
> #address-cells = <1>;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-08-08 21:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 15:20 [PATCH] ARM: dts: iwg20d-q7-common: Fix touch controller probe failure Biju Das
2020-08-08 21:28 ` Laurent Pinchart [this message]
2020-08-09 9:17 ` Biju Das
2020-08-09 10:54 ` Laurent Pinchart
2020-09-24 8:05 Biju Das
2020-09-24 8:52 ` Geert Uytterhoeven
2020-09-24 9:40 ` Biju Das
2020-09-24 10:24 ` Geert Uytterhoeven
2020-09-24 13:31 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808212858.GV6186@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).