devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Leitner <richard.leitner@skidata.com>
To: Robin Gong <yibin.gong@nxp.com>
Cc: <mark.rutland@arm.com>, <broonie@kernel.org>,
	<robh+dt@kernel.org>, <catalin.marinas@arm.com>,
	<vkoul@kernel.org>, <will.deacon@arm.com>, <shawnguo@kernel.org>,
	<festevam@gmail.com>, <s.hauer@pengutronix.de>,
	<martin.fuzzey@flowbird.group>, <u.kleine-koenig@pengutronix.de>,
	<dan.j.williams@intel.com>, <matthias.schiffer@ew.tq-group.com>,
	<frieder.schrempf@kontron.de>, <r.schwebel@pengutronix.de>,
	<linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <kernel@pengutronix.de>,
	<dmaengine@vger.kernel.org>, <linux-imx@nxp.com>
Subject: Re: [PATCH v12 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context
Date: Mon, 17 Aug 2020 07:38:20 +0200	[thread overview]
Message-ID: <20200817053820.GB551027@pcleri> (raw)
In-Reply-To: <1597161231-32303-5-git-send-email-yibin.gong@nxp.com>

On Tue, Aug 11, 2020 at 11:53:43PM +0800, Robin Gong wrote:
> Since sdma_transfer_init() will do sdma_load_context before any
> sdma transfer, no need once more in sdma_config_channel().
> 
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> Acked-by: Vinod Koul <vkoul@kernel.org>

Hi Robin,
thanks for the pointer to this patch.

As you suggested I've tested the two patches on my custom i.MX6DL
board. Therefore please feel free to add:

Tested-by: Richard Leitner <richard.leitner@skidata.com>

regards;rl

> ---
>  drivers/dma/imx-sdma.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index d305b80..5411e01e 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1137,7 +1137,6 @@ static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac)
>  static int sdma_config_channel(struct dma_chan *chan)
>  {
>  	struct sdma_channel *sdmac = to_sdma_chan(chan);
> -	int ret;
>  
>  	sdma_disable_channel(chan);
>  
> @@ -1177,9 +1176,7 @@ static int sdma_config_channel(struct dma_chan *chan)
>  		sdmac->watermark_level = 0; /* FIXME: M3_BASE_ADDRESS */
>  	}
>  
> -	ret = sdma_load_context(sdmac);
> -
> -	return ret;
> +	return 0;
>  }
>  
>  static int sdma_set_channel_priority(struct sdma_channel *sdmac,
> -- 
> 2.7.4
> 
> 

-- 
Richard Leitner
Hardware R&D / Senior Embedded Linux Engineer

SKIDATA | Driving Your Digital Future

SKIDATA GmbH
Untersbergstraße 40 | 5083 Grödig/Salzburg | Austria
[t] +43-6246-888-4245 | [m] +43-664-88616370
[w] www.skidata.com

  reply	other threads:[~2020-08-17  5:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 15:53 [PATCH v12 00/12] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong
2020-08-11 15:53 ` [PATCH v12 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong
2020-08-11 15:53 ` [PATCH v12 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong
2020-08-11 15:53 ` [PATCH v12 03/12] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong
2020-08-17  5:38   ` Richard Leitner
2020-08-11 15:53 ` [PATCH v12 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context Robin Gong
2020-08-17  5:38   ` Richard Leitner [this message]
2020-08-11 15:53 ` [PATCH v12 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script Robin Gong
2020-08-11 15:53 ` [PATCH v12 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong
2020-08-11 15:53 ` [PATCH v12 07/12] spi: imx: fix ERR009165 Robin Gong
2020-08-11 15:53 ` [PATCH v12 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong
2020-08-11 15:53 ` [PATCH v12 09/12] spi: imx: add new i.mx6ul compatible name in binding doc Robin Gong
2020-08-11 15:53 ` [PATCH v12 10/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Robin Gong
2020-08-11 15:53 ` [PATCH v12 11/12] dma: imx-sdma: add i.mx6ul compatible name Robin Gong
2020-08-11 15:53 ` [PATCH v12 12/12] dmaengine: imx-sdma: add uart rom script Robin Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200817053820.GB551027@pcleri \
    --to=richard.leitner@skidata.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.fuzzey@flowbird.group \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=r.schwebel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vkoul@kernel.org \
    --cc=will.deacon@arm.com \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).