Linux-Devicetree Archive on lore.kernel.org
 help / color / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>
Subject: [PATCH 08/13] ARM: dts: exynos: Add max77686 clocks for S3C RTC in SMDK5250
Date: Tue,  1 Sep 2020 09:54:12 +0200
Message-ID: <20200901075417.22481-9-krzk@kernel.org> (raw)
In-Reply-To: <20200901075417.22481-1-krzk@kernel.org>

Add clock-cells to max77686 PMIC node so its 32 kHz clocks could be used
later in the S3C RTC node. Except making the S3C RTC working, this also
fixes dtbs_check warnings:

  arch/arm/boot/dts/exynos5250-smdk5250.dt.yaml: rtc@101e0000: clocks: [[2, 337]] is too short
  arch/arm/boot/dts/exynos5250-smdk5250.dt.yaml: rtc@101e0000: clock-names: ['rtc'] is too short

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/boot/dts/exynos5250-smdk5250.dts | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index 5c42df024adf..00af7fb65080 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -7,6 +7,7 @@
  */
 
 /dts-v1/;
+#include <dt-bindings/clock/maxim,max77686.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include "exynos5250.dtsi"
@@ -129,13 +130,14 @@
 		reg = <0x50>;
 	};
 
-	max77686@9 {
+	max77686: pmic@9 {
 		compatible = "maxim,max77686";
 		reg = <0x09>;
 		interrupt-parent = <&gpx3>;
 		interrupts = <2 IRQ_TYPE_NONE>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&max77686_irq>;
+		#clock-cells = <1>;
 		wakeup-source;
 
 		voltage-regulators {
@@ -368,6 +370,8 @@
 
 &rtc {
 	status = "okay";
+	clocks = <&clock CLK_RTC>, <&max77686 MAX77686_CLK_AP>;
+	clock-names = "rtc", "rtc_src";
 };
 
 &sata {
-- 
2.17.1


  parent reply index

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01  7:54 [PATCH 00/13] ARM: dts: exynos: dtschema cleanups for Exynos5 Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 01/13] ARM: dts: exynos: Correct compatible for Exynos5 GIC Krzysztof Kozlowski
2020-09-03 20:48   ` Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 02/13] ARM: dts: exynos: Correct compatible for Exynos5260 GIC Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 03/13] ARM: dts: exynos: Remove unneeded address/size cells in " Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 04/13] ARM: dts: exynos: Correct S3C RTC bindings in SMDK5410 Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 05/13] ARM: dts: exynos: Silence i2c-gpio dtschema warning in Exynos5250 Arndale Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 06/13] ARM: dts: exynos: Correct whitespace and indentation issues in Exynos5 Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 07/13] ARM: dts: exynos: Override thermal by label in Exynos5250 Krzysztof Kozlowski
2020-09-01  7:54 ` Krzysztof Kozlowski [this message]
2020-09-01  7:54 ` [PATCH 09/13] ARM: dts: exynos: Use S5M8767 clock in S3C RTC in Exynos5250 Spring Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 10/13] ARM: dts: exynos: Silence DP HPD pinctrl dtschema warning " Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 11/13] ARM: dts: exynos: Silence SATA PHY warning in Exynos5250 Arndale Krzysztof Kozlowski
2020-09-01  8:13   ` Marek Szyprowski
2020-09-01  8:17     ` Krzysztof Kozlowski
2020-09-01  8:19       ` Krzysztof Kozlowski
2020-09-01  8:36         ` Marek Szyprowski
2020-09-01  8:42           ` Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 12/13] ARM: dts: exynos: Silence SATA PHY warning in SMDK5250 Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 13/13] ARM: dts: exynos: Use S2MPS11 clock in S3C RTC in SMDK5420 Krzysztof Kozlowski
2020-09-04  8:59   ` Krzysztof Kozlowski
2020-09-01  8:02 ` [PATCH 00/13] ARM: dts: exynos: dtschema cleanups for Exynos5 Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200901075417.22481-9-krzk@kernel.org \
    --to=krzk@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=snawrocki@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Devicetree Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git
	git clone --mirror https://lore.kernel.org/linux-devicetree/1 linux-devicetree/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \
		devicetree@vger.kernel.org
	public-inbox-index linux-devicetree

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git