Re: [PATCH v14 2/2] media: i2c: Add OV02A10 image sensor driver

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Andy,

On Fri, Sep 04, 2020 at 04:55:56PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 4, 2020 at 4:38 PM Dongchun Zhu <dongchun.zhu@mediatek.com> wrote:
> > On Wed, 2020-09-02 at 16:51 +0300, Andy Shevchenko wrote:
> > > On Wed, Sep 02, 2020 at 04:44:21PM +0300, Andy Shevchenko wrote:
> > > > On Wed, Sep 02, 2020 at 08:01:22PM +0800, Dongchun Zhu wrote:
> > >
> > > > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "rotation", &rotation);
> > >
> > > > > + ret = fwnode_property_read_u32_array(dev_fwnode(dev),
> > >
> > > > > +         fwnode_property_read_u32_array(dev_fwnode(dev),
> > >
> > > > > + ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency",
> > >
> > >
> > > Btw, can somebody explain, why it's fwnode API and not direct use of device property API?
> > >
> > > In all above cases I see no reason why not to use device property API directly.
> > >
> >
> > From the fwnode API's usage:
> > @fwnode: Firmware node to get the property of.
> >
> > It seems dev_fwnode(dev) could return dev->of_node->fwnode if CONFIG_OF
> > is enabled, or return dev->fwnode if not.
> 
> So?..
> 
> Shouldn't be the above an equivalent to device_property_*(dev, ...)?

Yes.

V4L2 does not have a dummy implementation for almost no V4L2 driver has no
use without V4L2.

-- 
Regards,

Sakari Ailus