From: Rob Herring <robh@kernel.org>
To: Wesley Cheng <wcheng@codeaurora.org>
Cc: sboyd@kernel.org, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, agross@kernel.org,
bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, jackp@codeaurora.org,
sergei.shtylyov@gmail.com
Subject: Re: [PATCH v9 2/4] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding
Date: Mon, 14 Sep 2020 15:57:28 -0600 [thread overview]
Message-ID: <20200914215728.GA258460@bogus> (raw)
In-Reply-To: <0101017458361303-16620b87-c433-4c00-a061-b1e688363539-000000@us-west-2.amazonses.com>
On Fri, Sep 04, 2020 at 08:22:53AM +0000, Wesley Cheng wrote:
> Introduce the dt-binding for enabling USB type C orientation and role
> detection using the PM8150B. The driver will be responsible for receiving
> the interrupt at a state change on the CC lines, reading the
> orientation/role, and communicating this information to the remote
> clients, which can include a role switch node and a type C switch.
>
> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> ---
> .../bindings/usb/qcom,pmic-typec.yaml | 108 ++++++++++++++++++
> 1 file changed, 108 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
Please see this thread[1]. Looks like similar functions and hence the
bindings should be similar. There's a lot of USB Type C binding changes
in flight. I'm just going to reject them all if folks that know the
h/w and USB Type C better than me can't work together.
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> new file mode 100644
> index 000000000000..8582ab6a3cc4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> @@ -0,0 +1,108 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/usb/qcom,pmic-typec.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Qualcomm PMIC based USB type C Detection Driver
> +
> +maintainers:
> + - Wesley Cheng <wcheng@codeaurora.org>
> +
> +description: |
> + Qualcomm PMIC Type C Detect
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,pm8150b-usb-typec
> +
> + reg:
> + maxItems: 1
> + description: Type C base address
> +
> + interrupts:
> + maxItems: 1
> + description: CC change interrupt from PMIC
> +
> + connector:
> + $ref: /connector/usb-connector.yaml#
> + description: Connector type for remote endpoints
> + type: object
> +
> + properties:
> + compatible:
> + enum:
> + - usb-c-connector
> +
> + power-role: true
> + data-role: true
> +
> + ports:
> + description: Remote endpoint connections
> + type: object
> +
> + properties:
> + port@1:
> + description: Remote endpoints for the Super Speed path
> + type: object
> +
> + properties:
> + endpoint@0:
> + description: Connection to USB type C mux node
> + type: object
> +
> + endpoint@1:
> + description: Connection to role switch node
> + type: object
Not sure about this. The connector SS signals are routed to a mux and
the above are the 2 choices?
Rob
[1] https://lore.kernel.org/linux-usb/TYBPR01MB53096D5A92B7AA149E5803D786260@TYBPR01MB5309.jpnprd01.prod.outlook.com/
next prev parent reply other threads:[~2020-09-14 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200904082223.25563-1-wcheng@codeaurora.org>
2020-09-04 8:22 ` [PATCH v9 1/4] usb: typec: Add QCOM PMIC typec detection driver Wesley Cheng
2020-09-04 8:22 ` [PATCH v9 2/4] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding Wesley Cheng
2020-09-04 8:33 ` Sergei Shtylyov
2020-09-14 21:57 ` Rob Herring [this message]
2020-09-04 8:23 ` [PATCH v9 3/4] arm64: boot: dts: qcom: pm8150b: Add node for USB type C block Wesley Cheng
2020-09-04 8:23 ` [PATCH v9 4/4] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914215728.GA258460@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).