From: Peter Hilber <peter.hilber@opensynergy.com>
To: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
<sudeep.holla@arm.com>, <souvik.chakravarty@arm.com>,
<alex.bennee@linaro.org>, <jean-philippe@linaro.org>,
<igor.skalkin@opensynergy.com>, <mikhail.golubev@opensynergy.com>,
<anton.yakovlev@opensynergy.com>,
Peter Hilber <peter.hilber@opensynergy.com>
Subject: [RFC PATCH 4/7] firmware: arm_scmi: Add per message transport data
Date: Fri, 18 Sep 2020 18:54:41 +0200 [thread overview]
Message-ID: <20200918165441.256940-1-peter.hilber@opensynergy.com> (raw)
In-Reply-To: <20200918162311.254564-1-peter.hilber@opensynergy.com>
From: Igor Skalkin <igor.skalkin@opensynergy.com>
The virtio transport in this patch series can be simplified by using the
scmi_xfer tx/rx buffers for data exchange with the virtio device, and
for saving the message state. But the virtio transport requires
prepending a transport-specific header. Also, for data exchange using
virtqueues, the tx and rx buffers should not overlap.
The first step to solve the aforementioned issues is to add a
transport-specific data pointer to scmi_xfer.
Co-developed-by: Peter Hilber <peter.hilber@opensynergy.com>
Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com>
Signed-off-by: Igor Skalkin <igor.skalkin@opensynergy.com>
---
drivers/firmware/arm_scmi/common.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h
index 0f1540cb2d84..e3ccec954e93 100644
--- a/drivers/firmware/arm_scmi/common.h
+++ b/drivers/firmware/arm_scmi/common.h
@@ -131,6 +131,7 @@ struct scmi_msg {
* buffer for the rx path as we use for the tx path.
* @done: command message transmit completion event
* @async_done: pointer to delayed response message received event completion
+ * @extra_data: Transport-specific private data pointer
*/
struct scmi_xfer {
int transfer_id;
@@ -139,6 +140,7 @@ struct scmi_xfer {
struct scmi_msg rx;
struct completion done;
struct completion *async_done;
+ void *extra_data;
};
void scmi_xfer_put(const struct scmi_handle *h, struct scmi_xfer *xfer);
--
2.25.1
next prev parent reply other threads:[~2020-09-18 16:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 16:23 [RFC PATCH 0/7] firmware: arm_scmi: Add virtio transport Peter Hilber
2020-09-18 16:46 ` [RFC PATCH 1/7] firmware: arm_scmi, smccc, mailbox: Make shmem based transports optional Peter Hilber
2020-09-18 16:52 ` [RFC PATCH 2/7] firmware: arm_scmi: Document that max_msg is a per channel type limit Peter Hilber
2020-09-18 16:53 ` [RFC PATCH 3/7] firmware: arm_scmi: Add op to override max message # Peter Hilber
2020-09-18 16:54 ` Peter Hilber [this message]
2020-09-18 16:55 ` [RFC PATCH 5/7] firmware: arm_scmi: Add xfer_init_buffers transport op Peter Hilber
2020-09-18 16:55 ` [RFC PATCH 6/7] dt-bindings: arm: Add virtio transport for SCMI Peter Hilber
2020-09-23 20:54 ` Rob Herring
2020-10-02 8:18 ` Peter Hilber
2020-09-18 16:56 ` [RFC PATCH 7/7] firmware: arm_scmi: Add virtio transport Peter Hilber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918165441.256940-1-peter.hilber@opensynergy.com \
--to=peter.hilber@opensynergy.com \
--cc=alex.bennee@linaro.org \
--cc=anton.yakovlev@opensynergy.com \
--cc=devicetree@vger.kernel.org \
--cc=igor.skalkin@opensynergy.com \
--cc=jean-philippe@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikhail.golubev@opensynergy.com \
--cc=robh+dt@kernel.org \
--cc=souvik.chakravarty@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).