From: Mark Brown <broonie@kernel.org>
To: cy_huang <u0084500@gmail.com>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, cy_huang@richtek.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20
Date: Thu, 24 Sep 2020 17:23:32 +0100 [thread overview]
Message-ID: <20200924162332.GH4754@sirena.org.uk> (raw)
In-Reply-To: <1600959891-16606-2-git-send-email-u0084500@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
On Thu, Sep 24, 2020 at 11:04:51PM +0800, cy_huang wrote:
> + enable-gpio:
> + description: A connection of the 'enable' gpio line.
> + maxItems: 1
-gpios. GPIO properties should always be plural even if there's only
one GPIO.
> + ld_pulse_delay:
Properties should use - not _ and for all the properties specifying
things like times you should have units so...
> + description: |
> + load current pulse delay in microsecond after strobe pin pulse high.
> + $ref: "/schemas/types.yaml#/definitions/uint32"
...add -us here.
> + fsin_enable:
> + description: Fsin function enable control.
> + $ref: "/schemas/types.yaml#/definitions/uint32"
> + minimum: 0
> + maximum: 1
> + default: 0
This looks like it should be a boolean property not a number. The same
is true for most if not all of the other properties with min/max of 0/1.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-24 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 15:04 [PATCH v1 1/2] regulator: rtmv20: Adds support for Richtek RTMV20 load switch regulator cy_huang
2020-09-24 15:04 ` [PATCH v1 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20 cy_huang
2020-09-24 16:23 ` Mark Brown [this message]
[not found] ` <CADiBU39ShyHNT=NiWz2Y81+wLMJjDqD6aZ0mgzVSxp_rzLZSFQ@mail.gmail.com>
2020-09-25 14:06 ` ChiYuan Huang
2020-09-24 16:11 ` [PATCH v1 1/2] regulator: rtmv20: Adds support for Richtek RTMV20 load switch regulator Mark Brown
[not found] ` <CADiBU3_b69g9vZf-J8p2_m5xDjn24XaUHn88foBsQ4MpBN829g@mail.gmail.com>
[not found] ` <20200925113224.GB4841@sirena.org.uk>
2020-09-25 14:05 ` ChiYuan Huang
2020-09-25 6:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924162332.GH4754@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).