From: Jonathan Cameron <jic23@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Daniel Campello <campello@chromium.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Evan Green <evgreen@chromium.org>
Subject: Re: [PATCH] dt-bindings: iio: sx9310: Add various settings as DT properties
Date: Fri, 25 Sep 2020 13:47:29 +0100 [thread overview]
Message-ID: <20200925134729.4fbfcb4a@archlinux> (raw)
In-Reply-To: <160093423392.310579.10143738916599003618@swboyd.mtv.corp.google.com>
On Thu, 24 Sep 2020 00:57:13 -0700
Stephen Boyd <swboyd@chromium.org> wrote:
> Quoting Stephen Boyd (2020-09-23 16:25:43)
> > > > > > +
> > > > > > + semtech,close-debounce-samples:
> > > > > > + allOf:
> > > > > > + - $ref: /schemas/types.yaml#definitions/uint32
> > > > > > + - enum: [0, 2, 4, 8]
> > > > > > + default: 0
> > > > > > + description:
> > > > > > + The number of close samples debounced for proximity/body thresholds.
> > > > >
> > > > > This feels like something that has more to do with the object motion than
> > > > > the sensor setup, so perhaps should be controlled from userspace?
> > > >
> > > > Sure. Is there an IIO sample property? Or I should make a custom
> > > > knob for this?
> > >
> > > It's kind of close to in_proximity0_thresh_period and that may be how they
> > > have implemented it.
> > >
> > > That control specifies a number of samples for which a condition should be true
> > > before it is reported.
> >
> > Sounds good. I can do that. It looks like the driver reports close/far
> > via an event and these debounce values are the same for me so I can
> > write both fields (close and far) with the same thresh_period value from
> > userspace. If they need to be different between the two then this can be
> > reevaluated?
> >
>
> Or I can assign thresh_period to falling and rising corresponding to
> close/far debounce. Seems that the direction is the same, but that can
> be split apart and each direction gets a different sysfs file?
Ah I should have read on. Yes,
thresh_falling_period and thresh_rising_period is fine.
Jonathan
next prev parent reply other threads:[~2020-09-25 12:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 22:18 [PATCH] dt-bindings: iio: sx9310: Add various settings as DT properties Stephen Boyd
2020-09-06 14:02 ` Jonathan Cameron
2020-09-09 6:18 ` Stephen Boyd
2020-09-09 11:15 ` Jonathan Cameron
2020-09-23 23:25 ` Stephen Boyd
2020-09-24 7:57 ` Stephen Boyd
2020-09-25 12:47 ` Jonathan Cameron [this message]
2020-09-25 12:46 ` Jonathan Cameron
2020-09-26 1:17 ` Stephen Boyd
2020-09-26 15:50 ` Jonathan Cameron
2020-09-14 21:00 ` Rob Herring
2020-09-22 21:43 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925134729.4fbfcb4a@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=campello@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gwendal@chromium.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).