From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B24C4363D for ; Fri, 25 Sep 2020 16:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39D7D22B2D for ; Fri, 25 Sep 2020 16:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601052145; bh=c2rgj1TrFsx3rd7S+ls7DxSAVWsEziKWugveJnbh7kQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mNN3mMHkAWSCLIL4X7xj5aUCnooDz5a1bZ5AM4FZ1udrn8egjvJKFxQ3VdY4mt3hQ LpJ8T+yUFiRFpcC60TCcPw3nVKTPzG60DdSu+JeSmr3xXdna9yB+/cwHbywRgxsMMk DrXEtOvO2Z4mx5nqP/cOy78yGyAGWf82TYTiGhqU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728733AbgIYQmY (ORCPT ); Fri, 25 Sep 2020 12:42:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:38754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727402AbgIYQmY (ORCPT ); Fri, 25 Sep 2020 12:42:24 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB53A2075F; Fri, 25 Sep 2020 16:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601052144; bh=c2rgj1TrFsx3rd7S+ls7DxSAVWsEziKWugveJnbh7kQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nefj7iINudouOnBVczHq0yRaRFAX3LLVlPa9t1Dh3TEwpgDSCalLiOGeQADo7qjQL HZNAxK6TRR8mZtf4CaynVgxNpRebRR0dMp7FLvAKRYzgQuFC+EBjCPqvWIJII3T0SV 8p9EtjNCfIHQ9iGeluJREcYmSk89R0R8yE0I7Vl4= Date: Fri, 25 Sep 2020 17:41:29 +0100 From: Mark Brown To: Richard Fitzgerald Cc: robh+dt@kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lucas Tanure , Charles Keepax Subject: Re: [PATCH 2/3] ASoC: cs4234: Add support for Cirrus Logic CS4234 codec Message-ID: <20200925164129.GG4841@sirena.org.uk> References: <20200925105908.20640-1-rf@opensource.cirrus.com> <20200925105908.20640-2-rf@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LiQwW4YX+w4axhAx" Content-Disposition: inline In-Reply-To: <20200925105908.20640-2-rf@opensource.cirrus.com> X-Cookie: Onward through the fog. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --LiQwW4YX+w4axhAx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 25, 2020 at 11:59:07AM +0100, Richard Fitzgerald wrote: This looks very good, a couple of small nits below which should be easy to address: > @@ -282,7 +283,6 @@ config SND_SOC_ALL_CODECS > uses them is also built since they are only usable with a machine > driver. Selecting this option will allow these drivers to be built > without an explicit machine driver for test and development purposes. > - > Support for the bus types used to access the codecs to be built must > be selected separately. > =20 Unrelated whitespace change. > +static int cs4234_i2c_remove(struct i2c_client *i2c_client) > +{ > + struct cs4234 *cs4234 =3D i2c_get_clientdata(i2c_client); > + > + pm_runtime_disable(&i2c_client->dev); > + cs4234_shutdown(cs4234); You used devm_snd_soc_register_component() which means that you won't unregister utill after this force powered down the device which isn't great - you should use snd_soc_register_component() and manually unregister here before force powering the device down. --LiQwW4YX+w4axhAx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9uHbgACgkQJNaLcl1U h9BwAgf/cvrCRNPtVmQZoCMjhnRTU3sG6jDhpuGmfUrnOdGyu8jSiZLkPqX/tWRI BXpR19icljIVCFyLzA/Y1W77ry9U8oGrywn6hVNLxp6cYntlPzTNiY+ZXHhZTv2i SNYxq6g1Bx3CRIg42QPO79PRQ6rxZgiuuXPieN1+m4mfdCTDdgYt9hhhMyYLpkDu 9oAXiUlcvyWmVyPmlwq3MebWms77Mo7/9qH6TruQXZDXGAnAH7UcMdxrejFF481i 6Cv9Ym39lubA20QU0w/AALqPvIxHyvme2ERSxXWBpTnYkotdC5X3dd2K1ewKwQ/+ H8J6WqhPI3hSArB0Xr7yTMtdqpRYvA== =j4b0 -----END PGP SIGNATURE----- --LiQwW4YX+w4axhAx--