From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD465C4741F for ; Sat, 26 Sep 2020 13:47:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC58C21527 for ; Sat, 26 Sep 2020 13:47:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726956AbgIZNrL (ORCPT ); Sat, 26 Sep 2020 09:47:11 -0400 Received: from vm1.sequanux.org ([188.165.36.56]:50676 "EHLO vm1.sequanux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726305AbgIZNrL (ORCPT ); Sat, 26 Sep 2020 09:47:11 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by vm1.sequanux.org (Postfix) with ESMTP id C736910862C; Sat, 26 Sep 2020 15:47:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at vm1.sequanux.org Received: from vm1.sequanux.org ([127.0.0.1]) by localhost (vm1.sequanux.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C4uqvyU9MTxg; Sat, 26 Sep 2020 15:47:07 +0200 (CEST) Received: from localhost (softwrestling.org [188.165.144.248]) by vm1.sequanux.org (Postfix) with ESMTPSA id EB80410812B; Sat, 26 Sep 2020 15:47:06 +0200 (CEST) Date: Sat, 26 Sep 2020 15:47:06 +0200 From: Simon Guinot To: Marek =?utf-8?B?QmVow7pu?= Cc: linux-leds@vger.kernel.org, Pavel Machek , Dan Murphy , =?utf-8?Q?Ond=C5=99ej?= Jirman , linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, =?utf-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas , Andrew Lunn , Andrey Utkin , Baolin Wang , Baolin Wang , Bartosz Golaszewski , Benjamin Herrenschmidt , Bjorn Andersson , Christian Mauderer , Chunyan Zhang , Daniel Mack , David Rivshin , Grant Feng , Haojian Zhuang , "H . Nikolaus Schaller" , Jaedon Shin , John Crispin , Kevin Cernekee , Lee Jones , Liam Girdwood , Linus Walleij , Mark Brown , Matthias Brugger , Michael Ellerman , Milo Kim , NeilBrown , Nikita Travkin , Orson Zhai , Paul Mackerras , Philippe Retornaz , Riku Voipio , Rod Whitby , Ryder Lee , Sakari Ailus , Sean Wang , Sebastian Reichel , Simon Guinot , Simon Shields , Thierry Reding , Thomas Bogendoerfer , Thomas Petazzoni , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Vasant Hegde , Vincent Donnefort , Xiaotong Lu Subject: Re: [PATCH leds v2 00/50] Start moving parsing of `linux,default-trigger` to LED core (a cleanup of LED drivers) Message-ID: <20200926134706.GJ4828@kw.sim.vm.gnt> References: <20200917223338.14164-1-marek.behun@nic.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WR+jf/RUebEcofwt" Content-Disposition: inline In-Reply-To: <20200917223338.14164-1-marek.behun@nic.cz> User-Agent: Mutt/1.6.0 (2016-04-01) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --WR+jf/RUebEcofwt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 18, 2020 at 12:32:48AM +0200, Marek Beh=C3=BAn wrote: > Hi, >=20 > this series is also available at [1]. >=20 > This is v2, you can read cover letter of v1 at [2] (togehter with > explanation of why I did this). >=20 > Changes since v1: > - split big changes into several patches of little changes > - added many cosmetic fixes (helper variables, reversal christmas tree > variables declaration, ...) > - fixed some bugs in various drivers (memory leaks, iteration over > unavailable OF nodes) > - made some drivers compilable when COMPILE_TEST=3Dy (since allyesconfig > did not compile them). Not all though, some still don't compile with > allyesconfig > - the commit that moves parsing of `linux,default-trigger` property from > drivers to LED core is now last in the series, instead of first >=20 > Marek >=20 > [1] https://git.kernel.org/pub/scm/linux/kernel/git/kabel/linux.git/log/?= h=3Dleds-cleanup-for-pavel > [2] https://lore.kernel.org/linux-leds/20200916231650.11484-1-marek.behun= @nic.cz/T/#m826493318174b0f38a3d4ba107092b5420ce440c =2E.. > leds: ns2: use devres LED registering function > leds: ns2: alloc simple array instead of struct ns2_led_priv > leds: ns2: support OF probing only, forget platdata > leds: ns2: move parsing of one LED into separate function > leds: ns2: use devres API for getting GPIO descriptors > leds: ns2: cosmetic structure rename > leds: ns2: cosmetic variable rename > leds: ns2: cosmetic change > leds: ns2: cosmetic change: use helper variable > leds: ns2: register LED immediately after parsing DT properties > leds: ns2: remove unneeded variable > leds: ns2: cosmetic: use reverse christmas tree > leds: ns2: reorder headers alphabetically > leds: ns2: use struct led_init_data when registering > leds: parse linux,default-trigger DT property in LED core Hi Marek, For all the patches applying to the leds-ns2 driver: Reviewed-by: Simon Guinot Tested-by: Simon Guinot Thanks for it. The driver is looking way better. Simon --WR+jf/RUebEcofwt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEXW8DgovlR3VS5hA0zyg/RDPmszoFAl9vRloACgkQzyg/RDPm szpYlxAA2tv+ztwuTqGVHf0MAJV7dd+lrcA7E7bj++L3tVr20iUB44pmcvgX0qqr y4UJWuBP9RDoPc3DmVhKljALA+EbzX0QSHT5LXayTmdykZaLEF5zCl9Ki79/+vvv kVwZFU5n/RNaig98ZqbjsyMtjYsaIgC1ImOveMoUU4hUgxJMJX6h31yQPB3hxid5 edYEUNIOpIN1n74N9NKikBBhxPIiGfA9Q4XoQ0w2LNjIHXyrjdtk+tV1ymAb0/Uw WSpMGnmNdgzwy48iYlBZndP771XhYvFl3mZv+FcKsS1qs21jLFQUdk6ZsRd6aEVT JyXxUOizOIJRw4KGVHIILbfkIwct9Is5H+9bhlK5HzvgkhqBGAa50cvgDIQrndI2 a7rJAwd0KfxcxfvfHw4iJMRDdQ/QXIRVyKE3m5/hTdwq4p6a91tTAemtgODHQGlN S6NF8GyHK2yWCkv6N2zx/tmZkcJOyAvD6rMNtBZdQCfyvv5Qx83T7UckYHzZEeo1 oHRrHs4quQ6KNQHYv9y8Y6W6SN2tkfZTNzBv0YxF6Jl/q0hYrLw6D8VAhRsErHQy 1OVrZQoxXUL4X5etjRJoXJdp2Guzrh2iIUJtlRlHeS4Vc2brMc1s1Xym0SN4XIgR /67wH+ybeKolA5cpHas++693+x7J8dp8S2rvXvY6SuyOYyMcLBY= =MzSs -----END PGP SIGNATURE----- --WR+jf/RUebEcofwt--