From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3A0AC2D0A8 for ; Mon, 28 Sep 2020 08:03:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51C4A2311C for ; Mon, 28 Sep 2020 08:03:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fU0HlbH+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbgI1IDo (ORCPT ); Mon, 28 Sep 2020 04:03:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726732AbgI1IDl (ORCPT ); Mon, 28 Sep 2020 04:03:41 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A418DC0613CE for ; Mon, 28 Sep 2020 01:03:40 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id k15so105664wrn.10 for ; Mon, 28 Sep 2020 01:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=5c8rGgT34CWyrrefDHjKaJQ7725a47R5T6yl0/KLFHg=; b=fU0HlbH+nbIGIOjrcnRQVUlq9lbF4G31CCW0J9WPKlPTQg0NhBfiHMqx4TkhPksRcA LTE6UAFUxEG1dKIVrpBWsNpNq4bX1QoihUFRvwRRM/d308rZG5GGaztuRKwR8K2UXSvL ORGURPz8UXzksxYLSY3ed5c6U+lvCLJ46h5IqnHkZGD6Rj6IQQznXe3CPaaAeBk+D0Ld YAvH267wpjAwZQP9WaEJnMCV3P1ccVxv0lPLEIT1InJi9zWUAjKiGgH1SIAQ4spBsy80 nuZYehv89mt7o+ZSAaEdtwIsrAsEWs+pwfnW51OZGyRrSljdDkwzrqVAcH7R2yhLirA2 6iRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=5c8rGgT34CWyrrefDHjKaJQ7725a47R5T6yl0/KLFHg=; b=UZSx9HfULJVYocGvGrS4GEyl91ddilxfmU6iqMkhGymORydNsL4RDLORVXTAt3Bj0p ir9u+MASMRzXcl7vIUpcIS9aV+gMV0RxrkOfrJRqSVbyaSv4+f0K+vigv7z7lPDJ0b+A On2405ceVZ4b6/rLodU1zXQ6Iz/6soRLXz06HQKUWJSF84/JjtxfAphpYNz4yzs4Q6Uu cC74PkQxUdY9HOuxkRUPF0umjjKcwSJsCIww5Efj2/UyEfVB59kFGXMLj5FVIiWAhNOB xCcuNYoT2e3EtERlf3lSl+essKWBV6m9Pwf9xJbGGtr2reOKvfzloSaok3LeaCSE3/+3 vg3w== X-Gm-Message-State: AOAM532frlWWOJoAS/rOeN0wwjJMa8qtVYuiRnxbjLlqU3RIFSBEkEBi FFJL0bEPoED6826pIcvfah6s4w== X-Google-Smtp-Source: ABdhPJzsjgZytiFI1ScdwSKUycH1MXJBoSICwLH5dRRY6GyOMI2AG7qvjd8CxzvjehVNec6TMp7Gbw== X-Received: by 2002:adf:a418:: with SMTP id d24mr279994wra.80.1601280219307; Mon, 28 Sep 2020 01:03:39 -0700 (PDT) Received: from dell ([91.110.221.154]) by smtp.gmail.com with ESMTPSA id 11sm189813wmi.14.2020.09.28.01.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2020 01:03:38 -0700 (PDT) Date: Mon, 28 Sep 2020 09:03:36 +0100 From: Lee Jones To: Sakari Ailus Cc: Marek Behun , linux-leds@vger.kernel.org, Pavel Machek , Dan Murphy , =?utf-8?Q?Ond=C5=99ej?= Jirman , linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Bartosz Golaszewski , Sean Wang , Matthias Brugger , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Orson Zhai , Baolin Wang , Chunyan Zhang , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Liam Girdwood , Mark Brown Subject: Re: [PATCH leds v2 05/50] leds: various: guard of_match_table member value with of_match_ptr Message-ID: <20200928080336.GA4637@dell> References: <20200917223338.14164-1-marek.behun@nic.cz> <20200917223338.14164-6-marek.behun@nic.cz> <20200918061500.GD26842@paasikivi.fi.intel.com> <20200918112058.6d3b0d5d@nic.cz> <20200918095759.GG26842@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200918095759.GG26842@paasikivi.fi.intel.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 18 Sep 2020, Sakari Ailus wrote: > On Fri, Sep 18, 2020 at 11:20:58AM +0200, Marek Behun wrote: > > On Fri, 18 Sep 2020 09:15:00 +0300 > > Sakari Ailus wrote: > > > > > Hi Marek, > > > > > > On Fri, Sep 18, 2020 at 12:32:53AM +0200, Marek Behún wrote: > > > > Change > > > > .of_match_table = xxx, > > > > to > > > > .of_match_table = of_match_ptr(xxx), > > > > in various drivers. > > > > > > > > This should be standard even for drivers that depend on OF. > > > > > > After this patch, none of these drivers will work on ACPI systems anymore. > > ^ > > If CONFIG_OF is disabled, that is. What? of_match_ptr() is designed to change depending on OF or !OF. Are you confusing this with acpi_match_table()? > > Hi Sakari, > > > > I don't understand. Why not? Does ACPI subsystem parse of_match_table > > as well? > > It does. The compatible string is used the same way as in DT for matching > devices with "PRP0001" _HID or _CID. > > Please read Documentation/firmware-guide/acpi/enumeration.rst . Could you allude to the specific line you are referencing please? > IOW, you can safely do the above only for drivers that depend on OF in > Kconfig. Otherwise you'll probably break something. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog