From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30D4FC2D0A8 for ; Mon, 28 Sep 2020 14:30:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD7C92075A for ; Mon, 28 Sep 2020 14:30:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726534AbgI1OaI convert rfc822-to-8bit (ORCPT ); Mon, 28 Sep 2020 10:30:08 -0400 Received: from mslow2.mail.gandi.net ([217.70.178.242]:40014 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbgI1OaI (ORCPT ); Mon, 28 Sep 2020 10:30:08 -0400 Received: from relay11.mail.gandi.net (unknown [217.70.178.231]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 486223B1F6E for ; Mon, 28 Sep 2020 14:26:21 +0000 (UTC) Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id B25BF100005; Mon, 28 Sep 2020 14:25:51 +0000 (UTC) Date: Mon, 28 Sep 2020 16:25:50 +0200 From: Miquel Raynal To: "Ramuthevar,Vadivel MuruganX" Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, richard@nod.at, vigneshr@ti.com, boris.brezillon@collabora.com, christophe.kerello@st.com, piotrs@cadence.com, robert.jarzmik@free.fr, brendanhiggins@google.com, devicetree@vger.kernel.org, tglx@linutronix.de, hauke.mehrtens@intel.com, robh+dt@kernel.org, linux-mips@vger.kernel.org, arnd@arndb.de, andriy.shevchenko@intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com Subject: Re: [PATCH v14 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Message-ID: <20200928162550.30bbce71@xps13> In-Reply-To: <20200924084842.41741-1-vadivel.muruganx.ramuthevar@linux.intel.com> References: <20200924084842.41741-1-vadivel.muruganx.ramuthevar@linux.intel.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello, "Ramuthevar,Vadivel MuruganX" wrote on Thu, 24 Sep 2020 16:48:40 +0800: > This patch adds the new IP of Nand Flash Controller(NFC) support > on Intel's Lightning Mountain(LGM) SoC. > > DMA is used for burst data transfer operation, also DMA HW supports > aligned 32bit memory address and aligned data access by default. > DMA burst of 8 supported. Data register used to support the read/write > operation from/to device. > > NAND controller also supports in-built HW ECC engine. > > NAND controller driver implements ->exec_op() to replace legacy hooks, > these specific call-back method to execute NAND operations. > > Thanks Miquel, Boris, Andy, Arnd and Rob for the review comments and suggestions. > --- > v14: > - Address Andy's review comments > - align the headers and revome Duplicates > - replcace numerical const values by HZ_PER_MHZ and USEC_PER_SEC > defined macros > - add dev_err_probe() api instead of legacy err check > - add get_unaligned_le32() api instead of manual endiness > - remove redudent check > - split the lines logically in between and add require spaces > v13: > - Address Miquel Raynal review comments > - update the return type with variable 'ret' > - handle err check statement properly > - change the naming convention aligned with recently changed the naming > around the data interface > data structure and function names > - replace by div 8 instead of <<4 in ecc calculation better code readability > - handle check_only properly like existing drivers I am sorry but there are two to three comments which you did not address or addressed partially while not so impacting on the logic, can you please review and address them all? (please note that I checked the patch adding the driver before telling you that). Thanks, Miquèl