From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Artur Rojek <contact@artur-rojek.eu>
Cc: Rob Herring <robh+dt@kernel.org>,
Paul Cercueil <paul@crapouillou.net>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: power: Convert ingenic,battery.txt to YAML
Date: Wed, 30 Sep 2020 01:18:10 +0200 [thread overview]
Message-ID: <20200929231810.45xelfcbmpiki43m@earth.universe> (raw)
In-Reply-To: <20200926173529.25238-1-contact@artur-rojek.eu>
[-- Attachment #1: Type: text/plain, Size: 4359 bytes --]
Hi,
On Sat, Sep 26, 2020 at 07:35:28PM +0200, Artur Rojek wrote:
> Convert the textual documentation of Device Tree bindings for the
> Ingenic JZ47xx SoCs battery to YAML.
>
> Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
> ---
Thanks, queued (both patches).
-- Sebastian
>
> Changes:
> v2: move introduction of new compatibles into a separate patch
>
> v3: - drop description of `io-channels` property and set its maxItems,
> - remove redundant quotes in `io-channel-names` property,
> - drop `items` for `monitored-battery` property
>
> .../bindings/power/supply/ingenic,battery.txt | 31 -----------
> .../power/supply/ingenic,battery.yaml | 55 +++++++++++++++++++
> 2 files changed, 55 insertions(+), 31 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/power/supply/ingenic,battery.txt
> create mode 100644 Documentation/devicetree/bindings/power/supply/ingenic,battery.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/ingenic,battery.txt b/Documentation/devicetree/bindings/power/supply/ingenic,battery.txt
> deleted file mode 100644
> index 66430bf73815..000000000000
> --- a/Documentation/devicetree/bindings/power/supply/ingenic,battery.txt
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -* Ingenic JZ47xx battery bindings
> -
> -Required properties:
> -
> -- compatible: Must be "ingenic,jz4740-battery".
> -- io-channels: phandle and IIO specifier pair to the IIO device.
> - Format described in iio-bindings.txt.
> -- monitored-battery: phandle to a "simple-battery" compatible node.
> -
> -The "monitored-battery" property must be a phandle to a node using the format
> -described in battery.txt, with the following properties being required:
> -
> -- voltage-min-design-microvolt: Drained battery voltage.
> -- voltage-max-design-microvolt: Fully charged battery voltage.
> -
> -Example:
> -
> -#include <dt-bindings/iio/adc/ingenic,adc.h>
> -
> -simple_battery: battery {
> - compatible = "simple-battery";
> - voltage-min-design-microvolt = <3600000>;
> - voltage-max-design-microvolt = <4200000>;
> -};
> -
> -ingenic_battery {
> - compatible = "ingenic,jz4740-battery";
> - io-channels = <&adc INGENIC_ADC_BATTERY>;
> - io-channel-names = "battery";
> - monitored-battery = <&simple_battery>;
> -};
> diff --git a/Documentation/devicetree/bindings/power/supply/ingenic,battery.yaml b/Documentation/devicetree/bindings/power/supply/ingenic,battery.yaml
> new file mode 100644
> index 000000000000..658ef92a5b82
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/ingenic,battery.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2019-2020 Artur Rojek
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/supply/ingenic,battery.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Ingenic JZ47xx battery bindings
> +
> +maintainers:
> + - Artur Rojek <contact@artur-rojek.eu>
> +
> +properties:
> + compatible:
> + const: ingenic,jz4740-battery
> +
> + io-channels:
> + maxItems: 1
> +
> + io-channel-names:
> + const: battery
> +
> + monitored-battery:
> + description: >
> + phandle to a "simple-battery" compatible node.
> +
> + This property must be a phandle to a node using the format described
> + in battery.txt, with the following properties being required:
> + - voltage-min-design-microvolt: drained battery voltage,
> + - voltage-max-design-microvolt: fully charged battery voltage.
> +
> +required:
> + - compatible
> + - io-channels
> + - io-channel-names
> + - monitored-battery
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/iio/adc/ingenic,adc.h>
> +
> + simple_battery: battery {
> + compatible = "simple-battery";
> + voltage-min-design-microvolt = <3600000>;
> + voltage-max-design-microvolt = <4200000>;
> + };
> +
> + ingenic-battery {
> + compatible = "ingenic,jz4740-battery";
> + io-channels = <&adc INGENIC_ADC_BATTERY>;
> + io-channel-names = "battery";
> + monitored-battery = <&simple_battery>;
> + };
> --
> 2.28.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-09-29 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 17:35 [PATCH v3 1/2] dt-bindings: power: Convert ingenic,battery.txt to YAML Artur Rojek
2020-09-26 17:35 ` [PATCH v3 2/2] dt-bindings: power: ingenic,battery: add new compatibles Artur Rojek
2020-09-29 19:21 ` [PATCH v3 1/2] dt-bindings: power: Convert ingenic,battery.txt to YAML Rob Herring
2020-09-29 23:18 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929231810.45xelfcbmpiki43m@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=contact@artur-rojek.eu \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).