From: Maxime Ripard <maxime@cerno.tech>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Frank Rowand <frowand.list@gmail.com>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Eric Anholt <eric@anholt.net>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rpi-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH 1/2] drm/vc4: hdmi: Disable Wifi Frequencies
Date: Wed, 30 Sep 2020 15:04:59 +0200 [thread overview]
Message-ID: <20200930130459.kfurbu34lc7jeuok@gilmour.lan> (raw)
In-Reply-To: <20200929190055.GA962101@bogus>
[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]
Hi Rob,
On Tue, Sep 29, 2020 at 02:00:55PM -0500, Rob Herring wrote:
> On Fri, Sep 25, 2020 at 03:07:43PM +0200, Maxime Ripard wrote:
> > There's cross-talk on the RPi4 between the 2.4GHz channels used by the WiFi
> > chip and some resolutions, most notably 1440p at 60Hz.
> >
> > In such a case, we can either reject entirely the mode, or lower slightly
> > the pixel frequency to remove the overlap. Let's go for the latter.
> >
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> > .../bindings/display/brcm,bcm2711-hdmi.yaml | 6 ++++++
> > drivers/gpu/drm/vc4/vc4_hdmi.c | 14 +++++++++++++-
> > drivers/gpu/drm/vc4/vc4_hdmi.h | 8 ++++++++
> > 3 files changed, 27 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> > index 03a76729d26c..63e7fe999c0a 100644
> > --- a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> > @@ -76,6 +76,12 @@ properties:
> > resets:
> > maxItems: 1
> >
> > + raspberrypi,disable-wifi-frequencies:
> > + type: boolean
> > + description: >
> > + Should the pixel frequencies in the WiFi frequencies range be
> > + avoided?
>
> Based on googling the issue, perhaps should be a common property?
This is a fairly generic issue indeed, but went for the most
non-intrusive way. Do you have a better idea of a generic name, or do
you just want me to drop the vendor prefix?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2020-10-05 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 13:07 [PATCH 1/2] drm/vc4: hdmi: Disable Wifi Frequencies Maxime Ripard
2020-09-25 13:07 ` [PATCH 2/2] ARM: dts: rpi-4: disable wifi frequencies Maxime Ripard
2020-09-28 9:02 ` [PATCH 1/2] drm/vc4: hdmi: Disable Wifi Frequencies Daniel Vetter
2020-09-30 13:03 ` Maxime Ripard
2020-09-29 19:00 ` Rob Herring
2020-09-30 13:04 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930130459.kfurbu34lc7jeuok@gilmour.lan \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=phil@raspberrypi.com \
--cc=robh@kernel.org \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).