Re: [PATCH v6 3/3] iio: adc: mt6360: Add ADC driver for MT6360

From: kernel test robot <lkp@intel.com>
To: Gene Chen <gene.chen.richtek@gmail.com>,
	jic23@kernel.org, robh+dt@kernel.org, matthias.bgg@gmail.com
Cc: kbuild-all@lists.01.org, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, devicetree@vger.kernel.org,
	linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v6 3/3] iio: adc: mt6360: Add ADC driver for MT6360
Date: Wed, 30 Sep 2020 19:12:13 +0800	[thread overview]
Message-ID: <202009301905.ns1B9LpF-lkp@intel.com> (raw)
In-Reply-To: <1601542448-7433-4-git-send-email-gene.chen.richtek@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2517 bytes --]

Hi Gene,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on iio/togreg]
[also build test ERROR on robh/for-next soc/for-next v5.9-rc7 next-20200929]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Gene-Chen/iio-adc-mt6360-Add-ADC-driver-for-MT6360/20200930-165619
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c5eda86258a6e9fc21bae8a1e0cb3bc9f54ca87e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Gene-Chen/iio-adc-mt6360-Add-ADC-driver-for-MT6360/20200930-165619
        git checkout c5eda86258a6e9fc21bae8a1e0cb3bc9f54ca87e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/iio/adc/mt6360-adc.c:212:3: error: 'const struct iio_info' has no member named 'read_label'; did you mean 'read_raw'?
     212 |  .read_label = mt6360_adc_read_label,
         |   ^~~~~~~~~~
         |   read_raw
>> drivers/iio/adc/mt6360-adc.c:212:16: error: initialization of 'int (*)(struct iio_dev *, const struct iio_chan_spec *, int,  int *, int *, long int)' from incompatible pointer type 'int (*)(struct iio_dev *, const struct iio_chan_spec *, char *)' [-Werror=incompatible-pointer-types]
     212 |  .read_label = mt6360_adc_read_label,
         |                ^~~~~~~~~~~~~~~~~~~~~
   drivers/iio/adc/mt6360-adc.c:212:16: note: (near initialization for 'mt6360_adc_iio_info.read_raw_multi')
   cc1: some warnings being treated as errors

vim +212 drivers/iio/adc/mt6360-adc.c

   209	
   210	static const struct iio_info mt6360_adc_iio_info = {
   211		.read_raw = mt6360_adc_read_raw,
 > 212		.read_label = mt6360_adc_read_label,
   213	};
   214	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52783 bytes --]