From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17BFBC41604 for ; Sat, 3 Oct 2020 16:47:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC72D2074B for ; Sat, 3 Oct 2020 16:47:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725811AbgJCQrn (ORCPT ); Sat, 3 Oct 2020 12:47:43 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:55998 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725807AbgJCQrm (ORCPT ); Sat, 3 Oct 2020 12:47:42 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id EE66DFB03; Sat, 3 Oct 2020 18:47:38 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O1SgnQLk12Z5; Sat, 3 Oct 2020 18:47:37 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 7489845D0C; Sat, 3 Oct 2020 18:47:36 +0200 (CEST) Date: Sat, 3 Oct 2020 18:47:36 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Rob Herring Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Eric Anholt , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Maxime Coquelin , Alexandre Torgue , Robert Chiras , Philippe Cornu , Yannick Fertre Subject: Re: [PATCH] dt-bindings: display: Add dsi-controller.yaml in DSI controller schemas Message-ID: <20201003164736.GA2773@bogon.m.sigxcpu.org> References: <20201002225924.3513700-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201002225924.3513700-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Fri, Oct 02, 2020 at 05:59:24PM -0500, Rob Herring wrote: > Some DSI controllers are missing a reference to the recently added > dsi-controller.yaml schema. Add it and we can drop the duplicate > parts. For the NWL part: Reviewed-by: Guido Günther > > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Eric Anholt > Cc: Nicolas Saenz Julienne > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: "Guido Gúnther" > Cc: Robert Chiras > Cc: Philippe Cornu > Cc: Yannick Fertre > Signed-off-by: Rob Herring > --- > .../display/allwinner,sun6i-a31-mipi-dsi.yaml | 11 ++------- > .../bindings/display/brcm,bcm2835-dsi0.yaml | 3 +++ > .../bindings/display/bridge/nwl-dsi.yaml | 11 ++++----- > .../bindings/display/st,stm32-dsi.yaml | 23 ++++--------------- > 4 files changed, 14 insertions(+), 34 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > index 63f948175239..7aa330dabc44 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > @@ -11,9 +11,6 @@ maintainers: > - Maxime Ripard > > properties: > - "#address-cells": true > - "#size-cells": true > - > compatible: > enum: > - allwinner,sun6i-a31-mipi-dsi > @@ -57,12 +54,7 @@ properties: > port should be the input endpoint, usually coming from the > associated TCON. > > -patternProperties: > - "^panel@[0-9]+$": true > - > required: > - - "#address-cells" > - - "#size-cells" > - compatible > - reg > - interrupts > @@ -74,6 +66,7 @@ required: > - port > > allOf: > + - $ref: dsi-controller.yaml# > - if: > properties: > compatible: > @@ -99,7 +92,7 @@ allOf: > clocks: > minItems: 1 > > -additionalProperties: false > +unevaluatedProperties: false > > examples: > - | > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > index 3c643b227a70..eb44e072b6e5 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > @@ -9,6 +9,9 @@ title: Broadcom VC4 (VideoCore4) DSI Controller > maintainers: > - Eric Anholt > > +allOf: > + - $ref: dsi-controller.yaml# > + > properties: > "#clock-cells": > const: 1 > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index b8ba6eb482a1..a125b2dd3a2f 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -14,6 +14,9 @@ description: | > NWL MIPI-DSI host controller found on i.MX8 platforms. This is a dsi bridge for > the SOCs NWL MIPI-DSI host controller. > > +allOf: > + - $ref: ../dsi-controller.yaml# > + > properties: > compatible: > const: fsl,imx8mq-nwl-dsi > @@ -144,10 +147,6 @@ properties: > > additionalProperties: false > > -patternProperties: > - "^panel@[0-9]+$": > - type: object > - > required: > - '#address-cells' > - '#size-cells' > @@ -163,7 +162,7 @@ required: > - reset-names > - resets > > -additionalProperties: false > +unevaluatedProperties: false > > examples: > - | > @@ -172,7 +171,7 @@ examples: > #include > #include > > - mipi_dsi: mipi_dsi@30a00000 { > + dsi@30a00000 { > #address-cells = <1>; > #size-cells = <0>; > compatible = "fsl,imx8mq-nwl-dsi"; > diff --git a/Documentation/devicetree/bindings/display/st,stm32-dsi.yaml b/Documentation/devicetree/bindings/display/st,stm32-dsi.yaml > index 69cc7e8bf15a..327a14d85df8 100644 > --- a/Documentation/devicetree/bindings/display/st,stm32-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/st,stm32-dsi.yaml > @@ -13,6 +13,9 @@ maintainers: > description: > The STMicroelectronics STM32 DSI controller uses the Synopsys DesignWare MIPI-DSI host controller. > > +allOf: > + - $ref: dsi-controller.yaml# > + > properties: > compatible: > const: st,stm32-dsi > @@ -65,24 +68,6 @@ properties: > description: > DSI output port node, connected to a panel or a bridge input port" > > -patternProperties: > - "^(panel|panel-dsi)@[0-9]$": > - type: object > - description: > - A node containing the panel or bridge description as documented in > - Documentation/devicetree/bindings/display/mipi-dsi-bus.txt > - properties: > - port: > - type: object > - description: > - Panel or bridge port node, connected to the DSI output port (port@1) > - > - "#address-cells": > - const: 1 > - > - "#size-cells": > - const: 0 > - > required: > - "#address-cells" > - "#size-cells" > @@ -92,7 +77,7 @@ required: > - clock-names > - ports > > -additionalProperties: false > +unevaluatedProperties: false > > examples: > - | > -- > 2.25.1 >