From: Nishanth Menon <nm@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: <t-kristo@ti.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <robh+dt@kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-j7200-main: Add McASP nodes
Date: Mon, 5 Oct 2020 06:58:05 -0500 [thread overview]
Message-ID: <20201005115805.d6yhykn7oc6x2tbu@charm> (raw)
In-Reply-To: <20201005074850.11247-1-peter.ujfalusi@ti.com>
On 10:48-20201005, Peter Ujfalusi wrote:
> Add the nodes for McASP 0-2 and keep them disabled because several
> required properties are not present as they are board specific.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 57 +++++++++++++++++++++++
> 1 file changed, 57 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> index 72d6496e88dd..cc6c2a81887a 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> @@ -446,4 +446,61 @@ usb0: usb@6000000 {
> dr_mode = "otg";
> };
> };
> +
> + mcasp0: mcasp@02b00000 {
> + compatible = "ti,am33xx-mcasp-audio";
> + reg = <0x0 0x02b00000 0x0 0x2000>,
> + <0x0 0x02b08000 0x0 0x1000>;
> + reg-names = "mpu","dat";
> + interrupts = <GIC_SPI 544 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 545 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tx", "rx";
> +
> + dmas = <&main_udmap 0xc400>, <&main_udmap 0x4400>;
> + dma-names = "tx", "rx";
> +
> + clocks = <&k3_clks 174 40>;
> + clock-names = "fck";
> + power-domains = <&k3_pds 174 TI_SCI_PD_EXCLUSIVE>;
> +
> + status = "disabled";
I see that there is inconsistent usage of "disabled" in our SoC.dts
Our generic rule has been set them to disabled in board.dtsi
McASP and DSS for existing SoC dts do not follow this.. which is a tad
confusing.. (considering that not even all uarts come out on every board
and every uart needs pinmux to function..)
Tero: Thoughts?
[...]
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2020-10-05 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 7:48 [PATCH] arm64: dts: ti: k3-j7200-main: Add McASP nodes Peter Ujfalusi
2020-10-05 11:58 ` Nishanth Menon [this message]
2020-10-05 12:02 ` Peter Ujfalusi
2020-10-05 12:08 ` Nishanth Menon
2020-10-07 10:38 ` Peter Ujfalusi
2020-10-26 14:50 ` Nishanth Menon
2020-10-27 13:07 ` Tony Lindgren
2020-10-27 13:19 ` Nishanth Menon
2020-10-27 13:26 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005115805.d6yhykn7oc6x2tbu@charm \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).