From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC1BC41604 for ; Tue, 6 Oct 2020 06:13:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 250BB20797 for ; Tue, 6 Oct 2020 06:13:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbgJFGN1 (ORCPT ); Tue, 6 Oct 2020 02:13:27 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:58250 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726022AbgJFGN1 (ORCPT ); Tue, 6 Oct 2020 02:13:27 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: rcn) with ESMTPSA id CF44F2962AB Date: Tue, 6 Oct 2020 08:13:17 +0200 From: Ricardo =?utf-8?Q?Ca=C3=B1uelo?= To: Rob Herring Cc: Collabora Kernel ML , Enric Balletbo i Serra , Benson Leung , Guenter Roeck , Simon Glass , Doug Anderson , devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] dt-bindings: mfd: google,cros-ec: add missing properties Message-ID: <20201006061317.rs63e3dh4grxij2v@rcn-XPS-13-9360> References: <20201005071403.17450-1-ricardo.canuelo@collabora.com> <20201005071403.17450-4-ricardo.canuelo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, thanks for reviewing the patch. Find my comments below: On lun 05-10-2020 10:37:09, Rob Herring wrote: > > + '#address-cells': > > + enum: [1, 2] > > + > > + '#size-cells': > > + enum: [0, 1] > > This doesn't really make sense. Either there's a size or there isn't. > > [...] > > > + "^regulator@[a-f0-9]+$": > > + "^ec-codec@[a-f0-9]+$": > > What does the number space represent and is it the same for each of > these? If not, then this is kind of broken. There's only 1 number > space at a given level. I see what you mean. In the regulator, the unit-address means the identifier for the voltage regulator and I guess it could also be defined as simply "^regulator@[0-9]+$". In the codec, though, it's a physical base address. The reg property in these has a different format, that's why I defined #address-cells and #size-cells above to have a range of values instead of fixed values. >From your experience, what's the best course of action here? I can't find a driver managing google,cros-ec-codec yet, although the binding was submitted in January. Thanks, Ricardo