From: Rob Herring <robh@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, shawnguo@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v2 01/10] dt-bindings: net: add the dpaa2-mac DTS definition
Date: Tue, 6 Oct 2020 15:56:35 -0500 [thread overview]
Message-ID: <20201006205635.GA2810492@bogus> (raw)
In-Reply-To: <20201002210737.27645-2-ioana.ciornei@nxp.com>
On Sat, Oct 03, 2020 at 12:07:28AM +0300, Ioana Ciornei wrote:
> Add a documentation entry for the DTS bindings needed and supported by
> the dpaa2-mac driver.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> Changes in v2:
> - new patch
>
> .../devicetree/bindings/net/dpaa2-mac.yaml | 55 +++++++++++++++++++
Use the compatible string for the filename.
> 1 file changed, 55 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/dpaa2-mac.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/dpaa2-mac.yaml b/Documentation/devicetree/bindings/net/dpaa2-mac.yaml
> new file mode 100644
> index 000000000000..744b0590278d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dpaa2-mac.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/dpaa2-mac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: DPAA2 MAC bindings
> +
> +maintainers:
> + - Ioana Ciornei <ioana.ciornei@nxp.com>
> +
> +description:
> + This binding represents the DPAA2 MAC objects found on the fsl-mc bus and
> + located under the 'dpmacs' node for the fsl-mc bus DTS node.
Need $ref to ethernet-controller.yaml
> +
> +properties:
> + compatible:
> + const: "fsl,qoriq-mc-dpmac"
Don't need quotes.
> +
> + reg:
> + maxItems: 1
> + description: The DPMAC number
> +
> + phy-handle: true
> +
> + phy-connection-type: true
> +
> + phy-mode: true
> +
> + pcs-handle:
> + $ref: /schemas/types.yaml#definitions/phandle
> + description:
> + A reference to a node representing a PCS PHY device found on
> + the internal MDIO bus.
Perhaps use the 'phys' binding? (Too many PHYs with ethernet...)
This would be the on-chip XAUI/SerDes phy? That's typically 'phys' where
as 'phy-handle' is ethernet PHY.
> +
> + managed: true
> +
> +required:
> + - reg
addtionalProperties: false
> +
> +examples:
> + - |
> + dpmacs {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dpmac@4 {
ethernet@4
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <0x4>;
> + phy-handle = <&mdio1_phy6>;
> + phy-connection-type = "qsgmii";
> + managed = "in-band-status";
> + pcs-handle = <&pcs3_1>;
> + };
> + };
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-10-06 20:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 21:07 [PATCH net-next v2 00/10] arm64: dts: layerscape: update MAC nodes with PHY information Ioana Ciornei
2020-10-02 21:07 ` [PATCH net-next v2 01/10] dt-bindings: net: add the dpaa2-mac DTS definition Ioana Ciornei
2020-10-06 20:56 ` Rob Herring [this message]
2020-10-07 10:51 ` Ioana Ciornei
2020-10-02 21:07 ` [PATCH net-next v2 02/10] arm64: dts: ls1088a: add external MDIO device nodes Ioana Ciornei
2020-10-02 21:07 ` [PATCH net-next v2 03/10] arm64: dts: ls1088ardb: add QSGMII PHY nodes Ioana Ciornei
2020-10-02 21:07 ` [PATCH net-next v2 04/10] arm64: dts: ls1088ardb: add necessary DTS nodes for DPMAC2 Ioana Ciornei
2020-10-02 21:07 ` [PATCH net-next v2 05/10] arm64: dts: ls208xa: add the external MDIO nodes Ioana Ciornei
2020-10-02 21:07 ` [PATCH net-next v2 06/10] arm64: dts: ls2088ardb: add PHY nodes for the CS4340 PHYs Ioana Ciornei
2020-10-02 21:07 ` [PATCH net-next v2 07/10] arm64: dts: ls2088ardb: add PHY nodes for the AQR405 PHYs Ioana Ciornei
2020-10-02 21:07 ` [PATCH net-next v2 08/10] arm64: dts: ls208xa: add PCS MDIO and PCS PHY nodes Ioana Ciornei
2020-10-02 21:07 ` [PATCH net-next v2 09/10] arm64: dts: lx2160a: " Ioana Ciornei
2020-10-02 21:07 ` [PATCH net-next v2 10/10] arm64: dts: lx2160ardb: add nodes for the AQR107 PHYs Ioana Ciornei
2020-10-02 23:13 ` [PATCH net-next v2 00/10] arm64: dts: layerscape: update MAC nodes with PHY information David Miller
2020-10-03 4:35 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006205635.GA2810492@bogus \
--to=robh@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).