devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladirmir Lisak <junak.pub@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: qcom: add msm8953 pinctrl bindings
Date: Wed, 7 Oct 2020 15:08:15 +0300	[thread overview]
Message-ID: <20201007120815.GA882584@trashcan> (raw)
In-Reply-To: <20201006212234.GA2858909@bogus>

Hi! Thank you for your reply! 

On Tue, Oct 06, 2020 at 04:22:34PM -0500, Rob Herring wrote:
> 
> For new bindings, please define a node name pattern you can match on 
> and avoid this if/then. '-pins$' is my preference.
> 

Ok, i will change it.

> > +              #interrupt-cells = <2>;
> > +              gpio-controller;
> > +              #gpio-cells = <2>;
> > +              gpio-ranges = <&tlmm 0 0 142>;
> 
> Please show at least 1 child node.
> 

I will add it in next version.

      reply	other threads:[~2020-10-07 12:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-04  8:16 [PATCH 1/2] pinctrl: qcom: add pinctrl driver for msm8953 Vladimir Lypak
2020-10-04  8:16 ` [PATCH 2/2] dt-bindings: pinctrl: qcom: add msm8953 pinctrl bindings Vladimir Lypak
2020-10-06 21:22   ` Rob Herring
2020-10-07 12:08     ` Vladirmir Lisak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201007120815.GA882584@trashcan \
    --to=junak.pub@gmail.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --subject='Re: [PATCH 2/2] dt-bindings: pinctrl: qcom: add msm8953 pinctrl bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).