From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77879C4363D for ; Wed, 7 Oct 2020 13:34:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B44921531 for ; Wed, 7 Oct 2020 13:34:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fjQ6DIn+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728467AbgJGNel (ORCPT ); Wed, 7 Oct 2020 09:34:41 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:54926 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728177AbgJGNel (ORCPT ); Wed, 7 Oct 2020 09:34:41 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 099089DA; Wed, 7 Oct 2020 15:34:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1602077679; bh=hZlEqx/vaXfkYUgExhxZr4ZIbI7/aIOnYhDz3m9bACI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fjQ6DIn+iG7bu1d5d60fVSmz/gJc+afU4oAlbJ92KpS6xhp2XaDMsix7kG/u/h8PZ MaJqsr2r9SmtKo88dKksdl7UP4bjoaCrFVDv3k8+FDr4m7SZu2VAVR/TgY2EDxvBcc f4qELifpIIlJCRXNLJz0SzUnhQMG9XHj1mJFFSnY= Date: Wed, 7 Oct 2020 16:33:57 +0300 From: Laurent Pinchart To: Marek Vasut Cc: Lucas Stach , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Guido =?utf-8?Q?G=C3=BCnther?= , Stefan Agner , Rob Herring , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML Message-ID: <20201007133357.GJ3937@pendragon.ideasonboard.com> References: <20201007012438.27970-1-laurent.pinchart@ideasonboard.com> <20201007012438.27970-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marek, On Wed, Oct 07, 2020 at 10:55:24AM +0200, Marek Vasut wrote: > On 10/7/20 10:43 AM, Lucas Stach wrote: > > On Mi, 2020-10-07 at 10:32 +0200, Marek Vasut wrote: > >> On 10/7/20 3:24 AM, Laurent Pinchart wrote: > >> [...] > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - fsl,imx23-lcdif > >>> + - fsl,imx28-lcdif > >>> + - fsl,imx6sx-lcdif > >>> + - fsl,imx8mq-lcdif > >> > >> There is no fsl,imx8mq-lcdif in drivers/gpu/drm/mxsfb/mxsfb_drv.c, > >> so the DT must specify compatible = "fsl,imx8mq-lcdif", > >> "fsl,imx28-lcdif" (since imx28 is the oldest SoC with LCDIF V4). > >> > >> Should the compatible be added to drivers/gpu/drm/mxsfb/mxsfb_drv.c or > >> dropped from the YAML file or neither ? > > > > Neither. As far as we know the block is compatible, so the DT should > > claim that it's compatible to "fsl,imx28-lcdif". However we don't know > > if there are any surprises, so we add the SoC specific compatible to be > > able to change the driver matching later without changing the DT if the > > need arises. For the DT validation to pass the SoC specific compatible > > needs to be documented, even if it currently unused by the driver. > > What in that binding says you should specify compatible = > "fsl,imx8mq-lcdif", "fsl,imx28-lcdif"; and not e.g. "fsl,imx8mq-lcdif", > "fsl,imx23-lcdif" or simply "fsl,imx8mq-lcdif" ? Nothing, until the next patch :-) This patch only handles the YAML conversion but doesn't fix issues. -- Regards, Laurent Pinchart