From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7103EC47095 for ; Wed, 7 Oct 2020 16:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02D6F20789 for ; Wed, 7 Oct 2020 16:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602086431; bh=mwCI5nHWg8GH+vUQV2iy3Dsvg3I5+GOPe3OfenQJHBQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rynJzwvk3/P+fqTI38tEMe5MSVvZVSV6vuKlD7dOqxDYXVt61kEDIz03K9KvSbCjw BrJLjbHWTRDIKATf5paxJk1lQUgsU1Xonl8vkPhTLtcCmx7UZChT7EvnI7nMaN+Ku3 t3x48MdZsSR85AxtOir5FyBt205ml+7URf4mpNlk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728931AbgJGQAa (ORCPT ); Wed, 7 Oct 2020 12:00:30 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:35295 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728289AbgJGQA3 (ORCPT ); Wed, 7 Oct 2020 12:00:29 -0400 Received: by mail-oi1-f194.google.com with SMTP id w141so2992516oia.2 for ; Wed, 07 Oct 2020 09:00:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IoTreMiNsZ2eue3Ucbk5mYQylUzIjBHL7Ou4EOgnm0s=; b=YmqdNJPLWfSwVHoSoniTSW3BgNkvdybR2LIEZZ3Ff3JANMvAxnW/9boZLZvXqBOUpw na5xz9tPMEN+vCywSgl/2Z6weldilVgnJRhKrbI1UNurOrKfIUailt+o6MoUcMLwj2o1 AIMPStlJUEFhQQyB1lu1ayO4VQUjzJA72s4lRHhcpKyUqwam/1bPKAMhWYq68wwm9qut 9ao3urmc5zK6msYQN/f5tIfQU43zJ4w9GRwXRQFqL7n8ety6Ib9+OWx5xXP5cshbQ3g7 8oxnYPll5u0AyTorzNvUwRZIl7PtXTvQ02FkvMBaYTp+S4MllgrB1Pkx3AmO3R5x4ae9 M0Uw== X-Gm-Message-State: AOAM531Ke4ROLNMBQOMli/jBMSpJxSeYBQRNyuwgubIf/lhQah2o+2DQ gHVrtTsyzVyElesjrQwE0wO2i7ptLA== X-Google-Smtp-Source: ABdhPJw9dHhrhLEySWMXxn1AfkdAVZJOXzdoQafdBtu1d1TRHOXWjzW0BD4MMhJEcOMY15u7TMEflw== X-Received: by 2002:aca:5945:: with SMTP id n66mr2434234oib.11.1602086422033; Wed, 07 Oct 2020 09:00:22 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id v18sm2464092oof.41.2020.10.07.09.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 09:00:21 -0700 (PDT) Received: (nullmailer pid 297508 invoked by uid 1000); Wed, 07 Oct 2020 16:00:20 -0000 Date: Wed, 7 Oct 2020 11:00:20 -0500 From: Rob Herring To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Stefan Agner , Marek Vasut , devicetree@vger.kernel.org, Guido =?iso-8859-1?Q?G=FCnther?= , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML Message-ID: <20201007160020.GA292355@bogus> References: <20201007012438.27970-1-laurent.pinchart@ideasonboard.com> <20201007012438.27970-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201007012438.27970-2-laurent.pinchart@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Oct 07, 2020 at 04:24:32AM +0300, Laurent Pinchart wrote: > Convert the mxsfb binding to YAML. The deprecated binding is dropped, as > neither the DT sources nor the driver support it anymore. The converted > binding is named fsl,lcdif.yaml to match the usual bindings naming > scheme. > > The compatible strings are messy, and DT sources use different kinds of > combination of documented and undocumented values. Keep it simple for > now, and update the example to make it valid. Aligning the binding with > the existing DT sources will be performed separately. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sam Ravnborg > -- > Changes since v1: > > - Drop unneeded quotes in string > - Replace minItems with maxItems in conditional check > - Add blank line before ... > - Squash the rename in this commit > --- > .../bindings/display/fsl,lcdif.yaml | 116 ++++++++++++++++++ > .../devicetree/bindings/display/mxsfb.txt | 87 ------------- > MAINTAINERS | 2 +- > 3 files changed, 117 insertions(+), 88 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/fsl,lcdif.yaml > delete mode 100644 Documentation/devicetree/bindings/display/mxsfb.txt > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > new file mode 100644 > index 000000000000..063bb8c58114 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -0,0 +1,116 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/fsl,lcdif.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale/NXP i.MX LCD Interface (LCDIF) > + > +maintainers: > + - Marek Vasut > + - Stefan Agner > + > +description: | > + (e)LCDIF display controller found in the Freescale/NXP i.MX SoCs. > + > +properties: > + compatible: > + enum: > + - fsl,imx23-lcdif > + - fsl,imx28-lcdif > + - fsl,imx6sx-lcdif > + - fsl,imx8mq-lcdif > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Pixel clock > + - description: Bus clock > + - description: Display AXI clock > + minItems: 1 > + > + clock-names: > + items: > + - const: pix > + - const: axi > + - const: disp_axi > + minItems: 1 > + > + interrupts: > + maxItems: 1 > + > + port: > + description: The LCDIF output port > + type: object > + > + properties: > + endpoint: What happened on the graph binding schema work? I started a meta-schema for it BTW. You can drop all the endpoint parts. With that, Reviewed-by: Rob Herring > + type: object > + > + properties: > + remote-endpoint: > + $ref: /schemas/types.yaml#/definitions/phandle > + > + required: > + - remote-endpoint > + > + additionalProperties: false > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + - port > + > +additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx6sx-lcdif > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 3 > + clock-names: > + minItems: 2 > + maxItems: 3 > + required: > + - clock-names > + else: > + properties: > + clocks: > + maxItems: 1 > + clock-names: > + maxItems: 1 > + > +examples: > + - | > + #include > + #include > + > + display-controller@2220000 { > + compatible = "fsl,imx6sx-lcdif"; > + reg = <0x02220000 0x4000>; > + interrupts = ; > + clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>, > + <&clks IMX6SX_CLK_LCDIF_APB>, > + <&clks IMX6SX_CLK_DISPLAY_AXI>; > + clock-names = "pix", "axi", "disp_axi"; > + > + port { > + endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt > deleted file mode 100644 > index c985871c46b3..000000000000 > --- a/Documentation/devicetree/bindings/display/mxsfb.txt > +++ /dev/null > @@ -1,87 +0,0 @@ > -* Freescale MXS LCD Interface (LCDIF) > - > -New bindings: > -============= > -Required properties: > -- compatible: Should be "fsl,imx23-lcdif" for i.MX23. > - Should be "fsl,imx28-lcdif" for i.MX28. > - Should be "fsl,imx6sx-lcdif" for i.MX6SX. > - Should be "fsl,imx8mq-lcdif" for i.MX8MQ. > -- reg: Address and length of the register set for LCDIF > -- interrupts: Should contain LCDIF interrupt > -- clocks: A list of phandle + clock-specifier pairs, one for each > - entry in 'clock-names'. > -- clock-names: A list of clock names. For MXSFB it should contain: > - - "pix" for the LCDIF block clock > - - (MX6SX-only) "axi", "disp_axi" for the bus interface clock > - > -Required sub-nodes: > - - port: The connection to an encoder chip. > - > -Example: > - > - lcdif1: display-controller@2220000 { > - compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > - reg = <0x02220000 0x4000>; > - interrupts = ; > - clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>, > - <&clks IMX6SX_CLK_LCDIF_APB>, > - <&clks IMX6SX_CLK_DISPLAY_AXI>; > - clock-names = "pix", "axi", "disp_axi"; > - > - port { > - parallel_out: endpoint { > - remote-endpoint = <&panel_in_parallel>; > - }; > - }; > - }; > - > -Deprecated bindings: > -==================== > -Required properties: > -- compatible: Should be "fsl,imx23-lcdif" for i.MX23. > - Should be "fsl,imx28-lcdif" for i.MX28. > -- reg: Address and length of the register set for LCDIF > -- interrupts: Should contain LCDIF interrupts > -- display: phandle to display node (see below for details) > - > -* display node > - > -Required properties: > -- bits-per-pixel: <16> for RGB565, <32> for RGB888/666. > -- bus-width: number of data lines. Could be <8>, <16>, <18> or <24>. > - > -Required sub-node: > -- display-timings: Refer to binding doc display-timing.txt for details. > - > -Examples: > - > -lcdif@80030000 { > - compatible = "fsl,imx28-lcdif"; > - reg = <0x80030000 2000>; > - interrupts = <38 86>; > - > - display: display { > - bits-per-pixel = <32>; > - bus-width = <24>; > - > - display-timings { > - native-mode = <&timing0>; > - timing0: timing0 { > - clock-frequency = <33500000>; > - hactive = <800>; > - vactive = <480>; > - hfront-porch = <164>; > - hback-porch = <89>; > - hsync-len = <10>; > - vback-porch = <23>; > - vfront-porch = <10>; > - vsync-len = <10>; > - hsync-active = <0>; > - vsync-active = <0>; > - de-active = <1>; > - pixelclk-active = <0>; > - }; > - }; > - }; > -}; > diff --git a/MAINTAINERS b/MAINTAINERS > index f0dd1f01703a..87e20680c104 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11910,7 +11910,7 @@ M: Stefan Agner > L: dri-devel@lists.freedesktop.org > S: Supported > T: git git://anongit.freedesktop.org/drm/drm-misc > -F: Documentation/devicetree/bindings/display/mxsfb.txt > +F: Documentation/devicetree/bindings/display/fsl,lcdif.yaml > F: drivers/gpu/drm/mxsfb/ > > MYLEX DAC960 PCI RAID Controller > -- > Regards, > > Laurent Pinchart >