From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7283C433E7 for ; Mon, 12 Oct 2020 16:11:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EACD2087E for ; Mon, 12 Oct 2020 16:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602519119; bh=TsAyoB579mGihPKYmNtmzxka6uXk07nBUIi8B/J2dWY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2QVDfNZM8W7JIUMKd3ue4x9IPXBn282BkmDb4Gv+PxlpOFxruKN3ogCVJOnw/6TEN FlfOAMFfipLmHLDxB+/v5HnqNP0rEjBK24AkKP4TGXcgTB0JDts7Mlxo7SXLe+kace F9CMSE1pJnnCmPRdddI7u7QUHD+d86p4RyIm5Nk0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390576AbgJLQL6 (ORCPT ); Mon, 12 Oct 2020 12:11:58 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:41446 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390543AbgJLQL6 (ORCPT ); Mon, 12 Oct 2020 12:11:58 -0400 Received: by mail-ot1-f67.google.com with SMTP id q21so16275495ota.8; Mon, 12 Oct 2020 09:11:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FBN0i7koeveN6LV2jTrTmRFBh0GWC3oxf9cjLV0OmvE=; b=fO+OGasTjp2D2UTewOwfFHGMRNj2sXdceIu9ZAS9ftTyAuTJsbCVbkOck78tpQlMhX Zsbf7hqwjknqMjGXSwqWgDHtDMeLQu4iTnfuol48wPqWvsff1IboQKwkFWYHTLx3V5VZ LYWuojqO4pWvsabbaIaer/3IOwFFdgqM+7cneK169F903aOXAbxxuovWGiPFRkgflziX aabbT4pUBab9QFZ5meAmflqoNzEwm+QIzs1/pEhiQkdbJyWULUBWZ57Sn4Biyrco1Se4 DOv2LEzC5jznV1lnlUctv8UalNAcjsjcuNFN6LzFvZjGmzIewXRSFUxTn+tTTscCacrE XTRA== X-Gm-Message-State: AOAM530tNiAGiEU6MqxIbW9jAVIvqvIYnhCUmbSgADz+bRsBiL9VPg0x GWGcRUAanzi+WqCHsIi7Fg== X-Google-Smtp-Source: ABdhPJxd+irepjSAW9fP8Aa4hfahEirk3nmWjcRyyszeGcM8hryXomN6TH6qhmZCrZNvsRa4b9k9aw== X-Received: by 2002:a9d:1406:: with SMTP id h6mr18026315oth.59.1602519117323; Mon, 12 Oct 2020 09:11:57 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l184sm6711195ooc.10.2020.10.12.09.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 09:11:56 -0700 (PDT) Received: (nullmailer pid 1636788 invoked by uid 1000); Mon, 12 Oct 2020 16:11:56 -0000 Date: Mon, 12 Oct 2020 11:11:56 -0500 From: Rob Herring To: Daniel Palmer Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver Message-ID: <20201012161156.GA1635284@bogus> References: <20201011024831.3868571-1-daniel@0x0f.com> <20201011024831.3868571-3-daniel@0x0f.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201011024831.3868571-3-daniel@0x0f.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Oct 11, 2020 at 11:48:28AM +0900, Daniel Palmer wrote: > The driver uses the pin names to find the right interrupt for > a pin from the device tree so this header reduces the need to > have multiple copies of the same string all over the place. > > This header also adds defines for the gpio number of each pin > from the driver view. The gpio block seems to support 128 lines > but what line is mapped to a physical pin depends on the chip. > The driver itself uses the index of a pin's offset in an array > of the possible offsets for a chip as the gpio number. > > The defines remove the need to work out that index to consume > a pin in the device tree. > > Signed-off-by: Daniel Palmer > --- > MAINTAINERS | 1 + > include/dt-bindings/gpio/msc313-gpio.h | 95 ++++++++++++++++++++++++++ > 2 files changed, 96 insertions(+) > create mode 100644 include/dt-bindings/gpio/msc313-gpio.h This should be part of the previous patch to avoid the error. > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4594b70f2e3a..ec5b49b9955f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2158,6 +2158,7 @@ F: Documentation/devicetree/bindings/arm/mstar/* > F: Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml > F: arch/arm/boot/dts/mstar-* > F: arch/arm/mach-mstar/ > +F: include/dt-bindings/gpio/msc313-gpio.h > > ARM/NEC MOBILEPRO 900/c MACHINE SUPPORT > M: Michael Petchkovsky > diff --git a/include/dt-bindings/gpio/msc313-gpio.h b/include/dt-bindings/gpio/msc313-gpio.h > new file mode 100644 > index 000000000000..655fe03de519 > --- /dev/null > +++ b/include/dt-bindings/gpio/msc313-gpio.h > @@ -0,0 +1,95 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ Don't use DT on non-GPL systems? > +/* > + * GPIO definitions for MStar/SigmaStar MSC313 and later SoCs > + * > + * Copyright (C) 2020 Daniel Palmer > + */ > + > +#ifndef _DT_BINDINGS_MSC313_GPIO_H > +#define _DT_BINDINGS_MSC313_GPIO_H > + > +/* pin names for fuart, same for all SoCs so far */ > +#define MSC313_PINNAME_FUART_RX "fuart_rx" > +#define MSC313_PINNAME_FUART_TX "fuart_tx" > +#define MSC313_PINNAME_FUART_CTS "fuart_cts" > +#define MSC313_PINNAME_FUART_RTS "fuart_rts" > + > +/* pin names for sr, mercury5 is different */ > +#define MSC313_PINNAME_SR_IO2 "sr_io2" > +#define MSC313_PINNAME_SR_IO3 "sr_io3" > +#define MSC313_PINNAME_SR_IO4 "sr_io4" > +#define MSC313_PINNAME_SR_IO5 "sr_io5" > +#define MSC313_PINNAME_SR_IO6 "sr_io6" > +#define MSC313_PINNAME_SR_IO7 "sr_io7" > +#define MSC313_PINNAME_SR_IO8 "sr_io8" > +#define MSC313_PINNAME_SR_IO9 "sr_io9" > +#define MSC313_PINNAME_SR_IO10 "sr_io10" > +#define MSC313_PINNAME_SR_IO11 "sr_io11" > +#define MSC313_PINNAME_SR_IO12 "sr_io12" > +#define MSC313_PINNAME_SR_IO13 "sr_io13" > +#define MSC313_PINNAME_SR_IO14 "sr_io14" > +#define MSC313_PINNAME_SR_IO15 "sr_io15" > +#define MSC313_PINNAME_SR_IO16 "sr_io16" > +#define MSC313_PINNAME_SR_IO17 "sr_io17" > + > +/* pin names for sd, same for all SoCs so far */ > +#define MSC313_PINNAME_SD_CLK "sd_clk" > +#define MSC313_PINNAME_SD_CMD "sd_cmd" > +#define MSC313_PINNAME_SD_D0 "sd_d0" > +#define MSC313_PINNAME_SD_D1 "sd_d1" > +#define MSC313_PINNAME_SD_D2 "sd_d2" > +#define MSC313_PINNAME_SD_D3 "sd_d3" > + > +/* pin names for i2c1, same for all SoCs so for */ > +#define MSC313_PINNAME_I2C1_SCL "i2c1_scl" > +#define MSC313_PINNAME_I2C1_SCA "i2c1_sda" > + > +/* pin names for spi0, same for all SoCs so far */ > +#define MSC313_PINNAME_SPI0_CZ "spi0_cz" > +#define MSC313_PINNAME_SPI0_CK "spi0_ck" > +#define MSC313_PINNAME_SPI0_DI "spi0_di" > +#define MSC313_PINNAME_SPI0_DO "spi0_do" > + > +#define MSC313_GPIO_FUART 0 > +#define MSC313_GPIO_FUART_RX (MSC313_GPIO_FUART + 0) > +#define MSC313_GPIO_FUART_TX (MSC313_GPIO_FUART + 1) > +#define MSC313_GPIO_FUART_CTS (MSC313_GPIO_FUART + 2) > +#define MSC313_GPIO_FUART_RTS (MSC313_GPIO_FUART + 3) > + > +#define MSC313_GPIO_SR (MSC313_GPIO_FUART_RTS + 1) > +#define MSC313_GPIO_SR_IO2 (MSC313_GPIO_SR + 0) > +#define MSC313_GPIO_SR_IO3 (MSC313_GPIO_SR + 1) > +#define MSC313_GPIO_SR_IO4 (MSC313_GPIO_SR + 2) > +#define MSC313_GPIO_SR_IO5 (MSC313_GPIO_SR + 3) > +#define MSC313_GPIO_SR_IO6 (MSC313_GPIO_SR + 4) > +#define MSC313_GPIO_SR_IO7 (MSC313_GPIO_SR + 5) > +#define MSC313_GPIO_SR_IO8 (MSC313_GPIO_SR + 6) > +#define MSC313_GPIO_SR_IO9 (MSC313_GPIO_SR + 7) > +#define MSC313_GPIO_SR_IO10 (MSC313_GPIO_SR + 8) > +#define MSC313_GPIO_SR_IO11 (MSC313_GPIO_SR + 9) > +#define MSC313_GPIO_SR_IO12 (MSC313_GPIO_SR + 10) > +#define MSC313_GPIO_SR_IO13 (MSC313_GPIO_SR + 11) > +#define MSC313_GPIO_SR_IO14 (MSC313_GPIO_SR + 12) > +#define MSC313_GPIO_SR_IO15 (MSC313_GPIO_SR + 13) > +#define MSC313_GPIO_SR_IO16 (MSC313_GPIO_SR + 14) > +#define MSC313_GPIO_SR_IO17 (MSC313_GPIO_SR + 15) > + > +#define MSC313_GPIO_SD (MSC313_GPIO_SR_IO17 + 1) > +#define MSC313_GPIO_SD_CLK (MSC313_GPIO_SD + 0) > +#define MSC313_GPIO_SD_CMD (MSC313_GPIO_SD + 1) > +#define MSC313_GPIO_SD_D0 (MSC313_GPIO_SD + 2) > +#define MSC313_GPIO_SD_D1 (MSC313_GPIO_SD + 3) > +#define MSC313_GPIO_SD_D2 (MSC313_GPIO_SD + 4) > +#define MSC313_GPIO_SD_D3 (MSC313_GPIO_SD + 5) > + > +#define MSC313_GPIO_I2C1 (MSC313_GPIO_SD_D3 + 1) > +#define MSC313_GPIO_I2C1_SCL (MSC313_GPIO_I2C1 + 0) > +#define MSC313_GPIO_I2C1_SDA (MSC313_GPIO_I2C1 + 1) > + > +#define MSC313_GPIO_SPI0 (MSC313_GPIO_I2C1_SDA + 1) > +#define MSC313_GPIO_SPI0_CZ (MSC313_GPIO_SPI0 + 0) > +#define MSC313_GPIO_SPI0_CK (MSC313_GPIO_SPI0 + 1) > +#define MSC313_GPIO_SPI0_DI (MSC313_GPIO_SPI0 + 2) > +#define MSC313_GPIO_SPI0_DO (MSC313_GPIO_SPI0 + 3) > + > +#endif /* _DT_BINDINGS_MSC313_GPIO_H */ > -- > 2.27.0 >