From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61216C433E7 for ; Fri, 16 Oct 2020 17:21:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 055A320704 for ; Fri, 16 Oct 2020 17:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602868896; bh=kslQP6wCGwy3KVF+afhPyklxGHKJfNNcVorEV9KkZ1s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BW9jjM+GdJjknhtdcGFBCSFAgDlxJVuEs78/dwc/1NAWWXXdI4FwSw6oPqnLGBFPu fYD9/sTNMCw21J25uTEmC8Zl/tAj/ttPmGAr7/DIKiADmrGab3xaeBozPOUDpH3M+V SB0fB6exWy7lZZOfb8Pq3jIMasmyA3P0lfNC3Dv0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390834AbgJPRVf (ORCPT ); Fri, 16 Oct 2020 13:21:35 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:41532 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390433AbgJPRVd (ORCPT ); Fri, 16 Oct 2020 13:21:33 -0400 Received: by mail-ot1-f65.google.com with SMTP id n15so3062940otl.8; Fri, 16 Oct 2020 10:21:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cuu3XyjKtEmeq+Akh/2IqEbAQRGMvswQSSuIN5iYFL8=; b=Nz0iteIVo7NmHLqE7B3Zz5W5Uvs4qxX5jfMo3BhPpQX5f5KifGvuSFQW8zPYdRdTHt t0QOlMnphHawQrs8+zTv4eDKvJrGl6gf1YgvFHmynx2oFMvMl83unYFbBGss+xMx/+Jl DK9n4WgIXYNgi0xUtinV0+FQkEZEiNZH5C3S+lEgcoG0l1ttGz/JLgyW3elKaBT/LQW6 Sm9PSZ4X758I890XmQS5OWXG8aIAcOVFYd45yRxldTZFFtl+WmaEY0RtoIJdyQ4t0+42 MkMiVAKPpuQBpHEHBsZAtI/dPWe6N8bv+pVz8KR0gewU2UwfDn1Vy/c/QKlUKVnIkNQu rTyg== X-Gm-Message-State: AOAM532mn5cVgJHj6RE5OtsqOfAt8G9wy9P58yF166xk6Md3Epb+tmJp cXi4Tuuol+6C+EfIgBL+Ow== X-Google-Smtp-Source: ABdhPJxp6hO1e2GFF+46cRfsByTXMzBlFBNBzxrIs7A5OIEpQioC0M9ZdrZj4e5mZiyAKdN2X7X3Fg== X-Received: by 2002:a9d:73c6:: with SMTP id m6mr3381977otk.105.1602868891876; Fri, 16 Oct 2020 10:21:31 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id c18sm1226145oib.34.2020.10.16.10.21.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2020 10:21:31 -0700 (PDT) Received: (nullmailer pid 1602664 invoked by uid 1000); Fri, 16 Oct 2020 17:21:29 -0000 Date: Fri, 16 Oct 2020 12:21:29 -0500 From: Rob Herring To: Tomasz Figa Cc: Sakari Ailus , Dongchun Zhu , Mauro Carvalho Chehab , Andy Shevchenko , Mark Rutland , Nicolas Boichat , Matthias Brugger , Cao Bing Bu , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Sj Huang , Linux Media Mailing List , linux-devicetree , Louis Kuo , Shengnan Wang =?utf-8?B?KOeOi+Wco+eUtyk=?= Subject: Re: [PATCH v15 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Message-ID: <20201016172129.GA1598042@bogus> References: <20201013130503.2412-1-dongchun.zhu@mediatek.com> <20201013130503.2412-2-dongchun.zhu@mediatek.com> <20201013161938.GE13341@paasikivi.fi.intel.com> <1602641418.4733.80.camel@mhfsdcap03> <20201014083139.GG13341@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Oct 14, 2020 at 01:48:00PM +0200, Tomasz Figa wrote: > On Wed, Oct 14, 2020 at 10:31 AM Sakari Ailus > wrote: > > > > On Wed, Oct 14, 2020 at 10:10:18AM +0800, Dongchun Zhu wrote: > > > Hello Sakari, > > > > > > Thanks for your timely review. > > > > > > On Tue, 2020-10-13 at 19:19 +0300, Sakari Ailus wrote: > > > > Hi Dongchun, > > > > > > > > On Tue, Oct 13, 2020 at 09:05:02PM +0800, Dongchun Zhu wrote: > > > > > Add YAML device tree binding for OV02A10 CMOS image sensor, and the > > > > > relevant MAINTAINERS entries. > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > --- > > > > > .../bindings/media/i2c/ovti,ov02a10.yaml | 162 +++++++++++++++++++++ > > > > > MAINTAINERS | 7 + > > > > > 2 files changed, 169 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > > > > > > [snip]... > > > > > > > > + ovti,mipi-clock-voltage: > > > > > + description: > > > > > + An array of 2-tuples items, and each item consists of link frequency and > > > > > + MIPI clock voltage unit like . Clock voltage unit is > > > > > + dependent upon link speed, indicating MIPI transmission speed select that > > > > > + controls D-PHY timing setting by adjusting MIPI clock voltage to improve > > > > > + the clock driver capability. > > > > > + $ref: "/schemas/types.yaml#/definitions/uint32-array" > > > > > + minItems: 2 > > > > > + default: [390000, 4] > > > > > > > > Why do you have the link frequency here as well? > > > > > > > > In principle this does belong to the endpoint as link frequencies are > > > > specific to that, but I don't mind; there's just a single port anyway. > > > > > > > > > > This is an optional property which we model as an array of > > clock voltage> pairs. An example to have all link speeds up to 390MHz > > > use the value 4 for current driver. If one wants to select different > > > voltage for different link, they could do so as well. > > > > If you think you'd need that, then you need to put this to the endpoint. > > The mipi-clock-voltage property is not a property of the endpoint. The > link frequency there does not set the link frequency - it only > specifies which link frequency the given voltage should be used for. Seems to me it's in the right place. Rob