From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5352BC388EC for ; Mon, 19 Oct 2020 08:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9D212225F for ; Mon, 19 Oct 2020 08:04:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603094653; bh=7fgajnOQSM7B/+cKJc84EGHLV3zHY5ZxYix7uHpO6O4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Frdrib71oAg5xPXXCMobxf7Eg103jgArRSeiC6Enshy1BxlnwujLH+U8MmCODcrhn MePAuyoIds7viEfuYgRiY+CLQU20QRmKCuJreYMhDCBg1oYvXeSFXPfldSpmraXkcV MrM7LnmpQrbsOcn7+ZRlYDwussX820qUJqoRR+qg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbgJSIEM (ORCPT ); Mon, 19 Oct 2020 04:04:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:42612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727349AbgJSIEM (ORCPT ); Mon, 19 Oct 2020 04:04:12 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BBF92224D; Mon, 19 Oct 2020 08:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603094651; bh=7fgajnOQSM7B/+cKJc84EGHLV3zHY5ZxYix7uHpO6O4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hw/kPg7Xl3a0wPXfyoSA+NkMy8bC8FTxoKFyYm+YUeJJL3Np4/2DDpEE+fl3JjZ/3 8x90mpPWvGYPfGV7+UYl5pfqG2TbWaIh3ABZDouKG9K8iE1QxgdVhDWJf58tVjvpUu ts1o6jvLSm6KzgITZCJQeAULiyNu2/Dun5sv53gs= Received: by pali.im (Postfix) id 17853B70; Mon, 19 Oct 2020 10:04:09 +0200 (CEST) Date: Mon, 19 Oct 2020 10:04:08 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Gregory CLEMENT , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Andre Heider , =?utf-8?Q?G=C3=A9rald?= Kerma Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2 Message-ID: <20201019080408.iv7vmj63cgt2i6vg@pali> References: <20201006124455.16617-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201006124455.16617-1-pali@kernel.org> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello! Gregory, I would like to remind you following patch. Andre, if you have a time, could you test it too? On Tuesday 06 October 2020 14:44:55 Pali Rohár wrote: > LED2 is connected to MPP1_2 pin. It is working only on V7 boards. > V5 boards have hw bug which cause that LED2 is non-working. > > So enable LED2 only for Espressobin V7 boards. > > Note that LED1 is connected to LED_WLAN# pin on miniPCIe card and LED3 to > power supply. Therefore on Espressobin board only LED2 can be controlled > directly from the host. LED1 is possible to control via WiFi card inserted > in miniPCIe slot if driver for particular card supports it. > > Signed-off-by: Pali Rohár > Tested-by: Gérald Kerma > > --- > > Previous version of this patch was sent by Uwe in March 2018, but it did > not work on any tested V5 board. Now we know it was due to V5 HW bug. > > https://lore.kernel.org/linux-arm-kernel/20180321105005.18426-3-u.kleine-koenig@pengutronix.de/ > --- > .../dts/marvell/armada-3720-espressobin-v7-emmc.dts | 4 ++++ > .../boot/dts/marvell/armada-3720-espressobin-v7.dts | 4 ++++ > .../boot/dts/marvell/armada-3720-espressobin.dtsi | 13 +++++++++++++ > 3 files changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > index 4775a7eda481..75401eab4d42 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > @@ -39,3 +39,7 @@ > &sdhci0 { > status = "okay"; > }; > + > +&led2 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > index c47a93978386..48a7f50fb427 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > @@ -34,3 +34,7 @@ > &switch0port3 { > label = "wan"; > }; > + > +&led2 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > index 8a1c678bea5f..daffe136c523 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > @@ -41,6 +41,19 @@ > 3300000 0x0>; > enable-active-high; > }; > + > + led2: gpio-led2 { > + /* led2 is working only on v7 board */ > + status = "disabled"; > + > + compatible = "gpio-leds"; > + > + led2 { > + label = "led2"; > + gpios = <&gpionb 2 GPIO_ACTIVE_LOW>; > + default-state = "off"; > + }; > + }; > }; > > /* J9 */ > -- > 2.20.1 >