From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A15F4C433E7 for ; Mon, 19 Oct 2020 20:01:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D21E222C2 for ; Mon, 19 Oct 2020 20:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603137661; bh=Fd5FD2x8oKPSBvpm+famFToo2yZY11kE6RZeDHRdyXg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=U+BecS3eZeMB9EtfjI0Va4+XCG/WFsObJWacpvvhBrOYGr+5hbFw7ZzlzjZYLVBvy R+u5PizbUhMDROuYGDg0kqB7XSZbmtj7/MXCv+WDpzadpzEbyJpnxgsgCD4Q8IJIhh ccALGMC1vknAtvmVPsOzYVTSfnJ0oAKfO6EFoADU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726820AbgJSUBA (ORCPT ); Mon, 19 Oct 2020 16:01:00 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:39372 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726385AbgJSUBA (ORCPT ); Mon, 19 Oct 2020 16:01:00 -0400 Received: by mail-ot1-f68.google.com with SMTP id f10so881397otb.6; Mon, 19 Oct 2020 13:00:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Da7ya6emMHC4LYDLkt7SqxYDT2kSeTgqpP+oqA7M45A=; b=iyXEPYjyFt01F2FuYiY7jVUF8/aDFtx4e3ZmxFOMRdcIW6L6F/qTn49fIWmdSpyqZ1 LnZiTl9+kxn+jdJo/wpZPPIb7DoSuNomUXibpDZVBxTUX//DcjRIW/IY9UP5ujoUba1N /vHVnk1toFBq/eZcDTrvvWpe7FGCE29AscCxfd+ym6a5sKwesFDnd7Vba27accBLCGlq KO6tvsScCeFrq+824Em/8vw/SNDvQRbP9uZxIf5/gvsVDN3l9+1L1DhEmMQM5zbmCPPX ceD1vJzDJhjON5kwbv+e2aGelIRZ2l9Cys5shN7wCGDGVfBxyPCe7t9oxrInZUv0uWb/ q6XA== X-Gm-Message-State: AOAM530fiqI6XYwxLLYtboVQMoiyfrTCId6wBu4kxrubh4yNORSrb3P6 bbOcdDwqfYZxV/rg1xAF1Q== X-Google-Smtp-Source: ABdhPJxMsLhO7PPQQEdGXUqCu/yMiGgrMSZWxreCIQDpQYjXxCREoewKO2+zDxOeRV56rpipzN5OGg== X-Received: by 2002:a05:6830:1282:: with SMTP id z2mr1094401otp.301.1603137657384; Mon, 19 Oct 2020 13:00:57 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id e76sm216475oib.16.2020.10.19.13.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 13:00:56 -0700 (PDT) Received: (nullmailer pid 3512358 invoked by uid 1000); Mon, 19 Oct 2020 20:00:55 -0000 Date: Mon, 19 Oct 2020 15:00:55 -0500 From: Rob Herring To: Yifeng Zhao Cc: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 1/8] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller Message-ID: <20201019200055.GB3508930@bogus> References: <20201019083358.32621-1-yifeng.zhao@rock-chips.com> <20201019083358.32621-2-yifeng.zhao@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201019083358.32621-2-yifeng.zhao@rock-chips.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Oct 19, 2020 at 04:33:55PM +0800, Yifeng Zhao wrote: > Documentation support for Rockchip RK3xxx NAND flash controllers > > Signed-off-by: Yifeng Zhao > --- > > (no changes since v8) > > Changes in v8: > - Fix make dt_binding_check error > > Changes in v7: > - Fix some wrong define > > Changes in v6: > - Fix some wrong define > - Modified the definition of compatible > > Changes in v5: > - Fix some wrong define. > - Add boot-medium define. > - Remove some compatible define. > > Changes in v4: > - The compatible define with rkxx_nfc. > - Add assigned-clocks. > - Fix some wrong defineChanges in. > > Changes in v3: > - Change the title for the dt-bindings. > > .../mtd/rockchip,nand-controller.yaml | 162 ++++++++++++++++++ > 1 file changed, 162 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > > diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > new file mode 100644 > index 000000000000..b9d7a8c79402 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > @@ -0,0 +1,162 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/rockchip,nand-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip SoCs NAND FLASH Controller (NFC) > + > +allOf: > + - $ref: "nand-controller.yaml#" > + > +maintainers: > + - Heiko Stuebner > + > +properties: > + compatible: > + oneOf: > + - const: rockchip,px30-nfc > + - const: rockchip,rk2928-nfc > + - const: rockchip,rv1108-nfc > + - items: > + - const: rockchip,rk3036-nfc > + - const: rockchip,rk2928-nfc > + - items: > + - const: rockchip,rk3308-nfc > + - const: rockchip,rv1108-nfc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + items: > + - description: Bus Clock > + - description: Module Clock > + > + clock-names: > + minItems: 1 > + items: > + - const: ahb > + - const: nfc > + > + assigned-clocks: > + maxItems: 1 > + > + assigned-clock-rates: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +patternProperties: > + "^nand@[0-7]$": > + type: object > + properties: > + reg: > + minimum: 0 > + maximum: 7 > + > + nand-ecc-mode: > + const: hw > + > + nand-ecc-step-size: > + const: 1024 > + > + nand-ecc-strength: > + enum: [16, 24, 40, 60, 70] > + description: > + The ECC configurations that can be supported are as follows. > + NFC v600 ECC 16, 24, 40, 60 > + RK2928, RK3066, RK3188 > + > + NFC v622 ECC 16, 24, 40, 60 > + RK3036, RK3128 > + > + NFC v800 ECC 16 > + RK3308, RV1108 > + > + NFC v900 ECC 16, 40, 60, 70 > + RK3326, PX30 If you want this formatting preserved, you need a '|' after 'description: '. > + > + nand-bus-width: > + const: 8 > + > + rockchip,boot-blks: > + minimum: 2 > + default: 16 > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 You can drop 'allOf' here now. > + description: > + The NFC driver need this information to select ECC > + algorithms supported by the boot ROM. > + Only used in combination with 'nand-is-boot-medium'. > + > + rockchip,boot-ecc-strength: > + enum: [16, 24, 40, 60, 70] > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + If specified it indicates that a different BCH/ECC setting is > + supported by the boot ROM. > + NFC v600 ECC 16, 24 > + RK2928, RK3066, RK3188 > + > + NFC v622 ECC 16, 24, 40, 60 > + RK3036, RK3128 > + > + NFC v800 ECC 16 > + RK3308, RV1108 > + > + NFC v900 ECC 16, 70 > + RK3326, PX30 > + > + Only used in combination with 'nand-is-boot-medium'. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + nfc: nand-controller@ff4b0000 { > + compatible = "rockchip,rk3308-nfc", > + "rockchip,rv1108-nfc"; > + reg = <0xff4b0000 0x4000>; > + interrupts = ; > + clocks = <&cru HCLK_NANDC>, <&cru SCLK_NANDC>; > + clock-names = "ahb", "nfc"; > + assigned-clocks = <&clks SCLK_NANDC>; > + assigned-clock-rates = <150000000>; > + > + pinctrl-0 = <&flash_ale &flash_bus8 &flash_cle &flash_csn0 > + &flash_rdn &flash_rdy &flash_wrn>; > + pinctrl-names = "default"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + nand@0 { > + reg = <0>; > + label = "rk-nand"; > + nand-bus-width = <8>; > + nand-ecc-mode = "hw"; > + nand-ecc-step-size = <1024>; > + nand-ecc-strength = <16>; > + nand-is-boot-medium; > + rockchip,boot-blks = <8>; > + rockchip,boot-ecc-strength = <16>; > + }; > + }; > + > +... > -- > 2.17.1 > > >