From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrej Valek <andrej.valek@siemens.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: nick@shmanahar.org, hadess@hadess.net,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] Input: goodix - add option to disable firmware loading
Date: Thu, 29 Oct 2020 13:36:08 -0700 [thread overview]
Message-ID: <20201029203608.GE2547185@dtor-ws> (raw)
In-Reply-To: <20201029170313.25529-2-andrej.valek@siemens.com>
Hi Andrej,
On Thu, Oct 29, 2020 at 06:03:11PM +0100, Andrej Valek wrote:
> Firmware file loadind for GT911 controller takes too much time (~60s).
> There is no check that configuration is the same which is already present.
> This happens always during boot, which makes touchscreen unusable.
>
> Add there an option to prevent firmware file loading, but keep it enabled
> by default.
I thought that Goodix was losing firmware loading at poweroff. Is this
not the case with this model?
Adding Hans as he was working with this driver/code.
>
> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
> ---
> drivers/input/touchscreen/goodix.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index 02c75ea385e08..44336ecd2acdf 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -941,7 +941,9 @@ static int goodix_get_gpio_config(struct goodix_ts_data *ts)
> default:
> if (ts->gpiod_int && ts->gpiod_rst) {
> ts->reset_controller_at_probe = true;
> - ts->load_cfg_from_disk = true;
> + /* Prevent cfg loading for each start */
> + ts->load_cfg_from_disk = !device_property_read_bool(dev,
> + "touchscreen-do-not-load-fw");
> ts->irq_pin_access_method = IRQ_PIN_ACCESS_GPIO;
> }
> }
> --
> 2.20.1
>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-10-29 20:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 17:03 [PATCH 0/3] Firmware loading option Andrej Valek
2020-10-29 17:03 ` [PATCH 1/3] Input: goodix - add option to disable firmware loading Andrej Valek
2020-10-29 20:36 ` Dmitry Torokhov [this message]
2020-10-30 8:45 ` Valek, Andrej
2020-10-30 9:56 ` Hans de Goede
2020-10-30 11:02 ` Valek, Andrej
2020-11-23 6:53 ` Dmitry Torokhov
2020-11-23 8:46 ` Hans de Goede
2020-11-10 9:07 ` [PATCH v3 1/4] " Andrej Valek
2020-11-10 18:15 ` [PATCH v4 " Andrej Valek
2020-10-29 17:03 ` [PATCH 2/3] dt-bindings: goodix Andrej Valek
2020-11-04 21:44 ` Rob Herring
2020-11-10 9:07 ` [PATCH v3 2/4] dt-bindings: touchscreen: goodix: add info about disabling FW loading Andrej Valek
2020-11-10 13:43 ` Rob Herring
2020-11-10 18:15 ` [PATCH v4 " Andrej Valek
2020-11-16 17:08 ` Rob Herring
2020-10-29 17:03 ` [PATCH 3/3] Input: atmel_mxt_ts - add option to disable firmware loading Andrej Valek
2020-11-10 9:07 ` [PATCH v3 3/4] " Andrej Valek
2020-11-10 18:15 ` [PATCH v4 " Andrej Valek
2020-11-23 6:56 ` Dmitry Torokhov
2020-11-06 10:05 ` [PATCH v2 0/3] Firmware loading option Andrej Valek
2020-11-06 10:05 ` [PATCH v2 1/3] Input: st1232 - add support resolution reading Andrej Valek
2020-11-10 9:07 ` [PATCH v3 4/4] " Andrej Valek
2020-11-10 18:15 ` [PATCH v4 " Andrej Valek
2020-11-06 10:05 ` [PATCH v2 2/3] dt-bindings: goodix Andrej Valek
2020-11-09 21:37 ` Rob Herring
2020-11-06 10:05 ` [PATCH v2 3/3] Input: goodix - add option to disable firmware loading Andrej Valek
2020-11-10 9:07 ` [PATCH v3 0/4] Firmware loading option Andrej Valek
2020-11-10 18:15 ` [PATCH v4 " Andrej Valek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029203608.GE2547185@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andrej.valek@siemens.com \
--cc=devicetree@vger.kernel.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).