From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5182FC4742C for ; Thu, 29 Oct 2020 20:48:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E65ED2087D for ; Thu, 29 Oct 2020 20:48:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="S1eLSOvx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725780AbgJ2Usp (ORCPT ); Thu, 29 Oct 2020 16:48:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbgJ2Uso (ORCPT ); Thu, 29 Oct 2020 16:48:44 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CE60C0613D2 for ; Thu, 29 Oct 2020 13:48:44 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id f38so3350669pgm.2 for ; Thu, 29 Oct 2020 13:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7jTNHive/FLwf9ZZT3i6CSw/O2mDxcoGdERzu325nls=; b=S1eLSOvxPle2SWTXmcWkjdxAG8gKeMEQNERefUSZtQOj35IZKWi6zQ3XA/x7yozwz8 SuJqxRhbB4i6YZ/pUVv4PdoQ6A/WOXxwmF1BPT1/90DX/CA1WzuJ0SBOp9PqwSiCKXSH F0G3QbbwVleLe5Wk2wNrW1vW/731JkCOacLvw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7jTNHive/FLwf9ZZT3i6CSw/O2mDxcoGdERzu325nls=; b=HCMrFl27NHlG8qCjjgZf61UbcVhWXU8LnTK7o0SCgoPoNmm2vrn0Y7JeLA8uSbBH86 rrdhnwOvoTbr22zVC8nLXjV20f/V38DjlFlKgSL2cyoJXNrK8Tw14S//pJVCsSl54dIT rNsJQ0ZR9bZx8EnElYXWkLVr4io3wsi6ky8KA+XoycF9Jo/AGOI/S2kVkWbg74512nWO dmGTMEPO6h7Wc6yM7Y7Uyvmrr55K0f7/HgJUQeKbo5ZtOVwovNrsoX3V59Vy+qnze9Bi ATp6MSHW+/oN8b680U4CCb1nUkjukCJX9zrdhwEQ2Wc2QctDmt7VnmXcFhRiVrn7IM8W EU3g== X-Gm-Message-State: AOAM530IV9axBiyqbxtCLkArxyByv8V/jw3rEs5FK1IaBWj1+b/69tij Hm3Tihtaaq/VIpxVjyOanvqcAA== X-Google-Smtp-Source: ABdhPJyNFMcPbWUco+Y+QNwEzgo/c6cxhTHy+B3buEgXZaS5imhK9G19CfKi/1d1jqh/zqA5P53RtQ== X-Received: by 2002:a17:90a:6984:: with SMTP id s4mr1082688pjj.206.1604004524081; Thu, 29 Oct 2020 13:48:44 -0700 (PDT) Received: from localhost ([2620:15c:202:1:f693:9fff:fef4:e70a]) by smtp.gmail.com with ESMTPSA id e5sm808565pjd.0.2020.10.29.13.48.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 13:48:43 -0700 (PDT) Date: Thu, 29 Oct 2020 13:48:42 -0700 From: mka@chromium.org To: Akhil P Oommen Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, dri-devel@freedesktop.org Subject: Re: [v4,1/3] drm/msm: Add support for GPU cooling Message-ID: <20201029204842.GC1855806@google.com> References: <1603958841-20233-1-git-send-email-akhilpo@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1603958841-20233-1-git-send-email-akhilpo@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Oct 29, 2020 at 01:37:19PM +0530, Akhil P Oommen wrote: > Register GPU as a devfreq cooling device so that it can be passively > cooled by the thermal framework. > > Signed-off-by: Akhil P Oommen > Reviewed-by: Matthias Kaehlcke Wait, I did not post a 'Reviewed-by' tag for this patch! I think the patch should be ok, but I'm still not super happy about the resource management involving devfreq in general (see discussion on https://patchwork.freedesktop.org/patch/394291/?series=82476&rev=1). It's not really something introduced by this patch, but if it ever gets fixed releasing the cooling device at the end of msm_gpu_cleanup() after everything else might cause trouble. In summary, I'm supportive of landing this patch, but reluctant to 'sign it off' because of the above. In any case: Tested-by: Matthias Kaehlcke